On Mon, Aug 24, 2015 at 06:14:41PM -0400, Paul Gortmaker wrote:
> The Kconfig currently controlling compilation of this code is:
>
> config FRONTSWAP
> bool "Enable frontswap to cache swap pages if tmem is present"
>
> ...meaning that it currently is not being built as a module by anyone.
>
> Lets remove the couple traces of modularity so that when reading the
> driver there is no doubt it is builtin-only.
>
> Since module_init translates to device_initcall in the non-modular
> case, the init ordering remains unchanged with this commit. However
> one could argue that subsys_initcall might make more sense here.
>
> Cc: Konrad Rzeszutek Wilk
Reviewed-by: Konrad Rzeszutek Wilk
I would add to the commit:
Frontswap depends on CONFIG_SWAP and there is currently no way
to make swap dynamically loaded.
> Cc: Andrew Morton
> Cc: linux...@kvack.org
> Signed-off-by: Paul Gortmaker
> ---
> mm/frontswap.c | 5 ++---
> 1 file changed, 2 insertions(+), 3 deletions(-)
>
> diff --git a/mm/frontswap.c b/mm/frontswap.c
> index 27a9924caf61..b36409766831 100644
> --- a/mm/frontswap.c
> +++ b/mm/frontswap.c
> @@ -15,7 +15,7 @@
> #include
> #include
> #include
> -#include
> +#include
> #include
> #include
> #include
> @@ -500,5 +500,4 @@ static int __init init_frontswap(void)
> #endif
> return 0;
> }
> -
> -module_init(init_frontswap);
> +device_initcall(init_frontswap);
> --
> 2.5.0
>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
