Re: [PATCH 09/10] scripts/basic/fixdep: Complete error handling in print_cmdline()
2016-10-29 8:42 GMT+09:00 Jim Davis :
> On Fri, Oct 28, 2016 at 1:40 AM, SF Markus Elfring
> wrote:
>
>> + if (printf("cmd_%s := %s\n\n", target, cmdline) < 10) {
>
> Rather than scatter fragile magic numbers, like 10, throughout the
> code, if you're hell-bent on checking for printf errors you could
> write a little wrapper function that hid the magic number and bundled
> up the errno stuff.
BTW, how the magic number "10" was calculated?
--
Best Regards
Masahiro Yamada
Re: [PATCH 09/10] scripts/basic/fixdep: Complete error handling in print_cmdline()
On Fri, Oct 28, 2016 at 1:40 AM, SF Markus Elfring
wrote:
> + if (printf("cmd_%s := %s\n\n", target, cmdline) < 10) {
Rather than scatter fragile magic numbers, like 10, throughout the
code, if you're hell-bent on checking for printf errors you could
write a little wrapper function that hid the magic number and bundled
up the errno stuff.
But what would you expect printf error checking to tell a user?
Perhaps that he or she ran out of disk space, but that's going to be
painfully obvious anyway in almost every case.
--
Jim
[PATCH 09/10] scripts/basic/fixdep: Complete error handling in print_cmdline()
From: Markus Elfring
Date: Fri, 28 Oct 2016 09:29:59 +0200
A return value was not checked from a call of the function "printf".
This issue was detected also by using the Coccinelle software.
Add a bit of exception handling there.
Signed-off-by: Markus Elfring
---
scripts/basic/fixdep.c | 7 ++-
1 file changed, 6 insertions(+), 1 deletion(-)
diff --git a/scripts/basic/fixdep.c b/scripts/basic/fixdep.c
index f5ff6eea..911347a 100644
--- a/scripts/basic/fixdep.c
+++ b/scripts/basic/fixdep.c
@@ -132,7 +132,12 @@ static void usage(void)
*/
static void print_cmdline(void)
{
- printf("cmd_%s := %s\n\n", target, cmdline);
+ if (printf("cmd_%s := %s\n\n", target, cmdline) < 10) {
+ int code = errno;
+
+ perror("fixdep: print_cmdline");
+ exit(code);
+ }
}
/*
--
2.10.1
