Re: [PATCH 1/1] Input: ims-pcu - fix typo in an error log
On 2017/11/24 15:17, Joe Perches wrote:
> On Fri, 2017-11-24 at 14:59 +0800, Zhen Lei wrote:
>> Tiny typo fixed in an error log.
>>
>> I found this when I backported the CVE-2017-16645 patch:
>> ea04efee7635 ("Input: ims-psu - check if CDC union descriptor is sane")
>>
>> Signed-off-by: Zhen Lei
>> ---
>> drivers/input/misc/ims-pcu.c | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drivers/input/misc/ims-pcu.c b/drivers/input/misc/ims-pcu.c
> []
>> @@ -1651,7 +1651,7 @@ static void ims_pcu_buffers_free(struct ims_pcu *pcu)
>> return union_desc;
>>
>> dev_err(>dev,
>> -"Union descriptor to short (%d vs %zd\n)",
>> +"Union descriptor too short (%d vs %zd\n)",
>
> And this format is incorrect too. It should be:
>
> + "Union descriptor too short (%d vs %zd)\n",
>
> with the close parenthesis before the newline, not after.
You are very observant. Do I need to post v2? It seems that we can simply
modify it directly.
>
>
> .
>
--
Thanks!
BestRegards
Re: [PATCH 1/1] Input: ims-pcu - fix typo in an error log
On 2017/11/24 15:17, Joe Perches wrote:
> On Fri, 2017-11-24 at 14:59 +0800, Zhen Lei wrote:
>> Tiny typo fixed in an error log.
>>
>> I found this when I backported the CVE-2017-16645 patch:
>> ea04efee7635 ("Input: ims-psu - check if CDC union descriptor is sane")
>>
>> Signed-off-by: Zhen Lei
>> ---
>> drivers/input/misc/ims-pcu.c | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drivers/input/misc/ims-pcu.c b/drivers/input/misc/ims-pcu.c
> []
>> @@ -1651,7 +1651,7 @@ static void ims_pcu_buffers_free(struct ims_pcu *pcu)
>> return union_desc;
>>
>> dev_err(>dev,
>> -"Union descriptor to short (%d vs %zd\n)",
>> +"Union descriptor too short (%d vs %zd\n)",
>
> And this format is incorrect too. It should be:
>
> + "Union descriptor too short (%d vs %zd)\n",
>
> with the close parenthesis before the newline, not after.
You are very observant. Do I need to post v2? It seems that we can simply
modify it directly.
>
>
> .
>
--
Thanks!
BestRegards
Re: [PATCH 1/1] Input: ims-pcu - fix typo in an error log
On Fri, 2017-11-24 at 14:59 +0800, Zhen Lei wrote:
> Tiny typo fixed in an error log.
>
> I found this when I backported the CVE-2017-16645 patch:
> ea04efee7635 ("Input: ims-psu - check if CDC union descriptor is sane")
>
> Signed-off-by: Zhen Lei
> ---
> drivers/input/misc/ims-pcu.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/input/misc/ims-pcu.c b/drivers/input/misc/ims-pcu.c
[]
> @@ -1651,7 +1651,7 @@ static void ims_pcu_buffers_free(struct ims_pcu *pcu)
> return union_desc;
>
> dev_err(>dev,
> - "Union descriptor to short (%d vs %zd\n)",
> + "Union descriptor too short (%d vs %zd\n)",
And this format is incorrect too. It should be:
+ "Union descriptor too short (%d vs %zd)\n",
with the close parenthesis before the newline, not after.
Re: [PATCH 1/1] Input: ims-pcu - fix typo in an error log
On Fri, 2017-11-24 at 14:59 +0800, Zhen Lei wrote:
> Tiny typo fixed in an error log.
>
> I found this when I backported the CVE-2017-16645 patch:
> ea04efee7635 ("Input: ims-psu - check if CDC union descriptor is sane")
>
> Signed-off-by: Zhen Lei
> ---
> drivers/input/misc/ims-pcu.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/input/misc/ims-pcu.c b/drivers/input/misc/ims-pcu.c
[]
> @@ -1651,7 +1651,7 @@ static void ims_pcu_buffers_free(struct ims_pcu *pcu)
> return union_desc;
>
> dev_err(>dev,
> - "Union descriptor to short (%d vs %zd\n)",
> + "Union descriptor too short (%d vs %zd\n)",
And this format is incorrect too. It should be:
+ "Union descriptor too short (%d vs %zd)\n",
with the close parenthesis before the newline, not after.
[PATCH 1/1] Input: ims-pcu - fix typo in an error log
Tiny typo fixed in an error log.
I found this when I backported the CVE-2017-16645 patch:
ea04efee7635 ("Input: ims-psu - check if CDC union descriptor is sane")
Signed-off-by: Zhen Lei
---
drivers/input/misc/ims-pcu.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/input/misc/ims-pcu.c b/drivers/input/misc/ims-pcu.c
index ae47312..253ae8e 100644
--- a/drivers/input/misc/ims-pcu.c
+++ b/drivers/input/misc/ims-pcu.c
@@ -1651,7 +1651,7 @@ static void ims_pcu_buffers_free(struct ims_pcu *pcu)
return union_desc;
dev_err(>dev,
- "Union descriptor to short (%d vs %zd\n)",
+ "Union descriptor too short (%d vs %zd\n)",
union_desc->bLength, sizeof(*union_desc));
return NULL;
}
--
1.8.3
[PATCH 1/1] Input: ims-pcu - fix typo in an error log
Tiny typo fixed in an error log.
I found this when I backported the CVE-2017-16645 patch:
ea04efee7635 ("Input: ims-psu - check if CDC union descriptor is sane")
Signed-off-by: Zhen Lei
---
drivers/input/misc/ims-pcu.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/input/misc/ims-pcu.c b/drivers/input/misc/ims-pcu.c
index ae47312..253ae8e 100644
--- a/drivers/input/misc/ims-pcu.c
+++ b/drivers/input/misc/ims-pcu.c
@@ -1651,7 +1651,7 @@ static void ims_pcu_buffers_free(struct ims_pcu *pcu)
return union_desc;
dev_err(>dev,
- "Union descriptor to short (%d vs %zd\n)",
+ "Union descriptor too short (%d vs %zd\n)",
union_desc->bLength, sizeof(*union_desc));
return NULL;
}
--
1.8.3
