Re: [PATCH 1/1] arm: add bandgap DT entry for OMAP5
On 19-06-2013 06:36, Benoit Cousson wrote: > Hi Eduardo, > > On 06/18/2013 09:36 PM, Eduardo Valentin wrote: >> Add bandgap device DT entry for OMAP5 dtsi. >> >> Cc: "Benoît Cousson" >> Cc: Tony Lindgren >> Cc: Russell King >> Cc: linux-o...@vger.kernel.org >> Cc: devicetree-disc...@lists.ozlabs.org >> Cc: linux-arm-ker...@lists.infradead.org >> Cc: linux-kernel@vger.kernel.org >> Signed-off-by: Eduardo Valentin >> Signed-off-by: J Keerthy >> --- >> arch/arm/boot/dts/omap5.dtsi | 8 >> 1 file changed, 8 insertions(+) >> --- >> >> Benoit, >> >> Sorry for this very late request, but can you please consider >> these patches for 3.11 still? >> >> I completely forgot to send these on my "Enable TI SoC thermal driver" >> series. >> >> All best, >> >> Eduardo >> >> diff --git a/arch/arm/boot/dts/omap5.dtsi b/arch/arm/boot/dts/omap5.dtsi >> index 2ad63c4..5ede6e1 100644 >> --- a/arch/arm/boot/dts/omap5.dtsi >> +++ b/arch/arm/boot/dts/omap5.dtsi >> @@ -615,5 +615,13 @@ >> interrupts = <0 80 0x4>; >> ti,hwmods = "wd_timer2"; >> }; > > missing blank line > >> +bandgap { > > You must use the first address in that case. Otherwise DT will affect a > random number and provide a non-standard device name. That does not really > matter in theory, but it will looks ugly in the /sys/devices list. > >> +reg = <0x4a0021e0 0xc >> +0x4a00232c 0xc >> +0x4a002380 0x2c >> +0x4a0023C0 0x3c>; >> +interrupts = <0 126 4>; /* talert */ > > Not well aligned and should use the macros. > >> +compatible = "ti,omap5430-bandgap"; >> +}; >> }; >> }; >> > > I did the update for you :-) > > Here is the version I've just applied. > > Benoit > > >>From f0160bb93467e22f2f8bc77591dcd7e35cdee999 Mon Sep 17 00:00:00 2001 > From: Eduardo Valentin > Date: Tue, 18 Jun 2013 22:36:38 -0400 > Subject: [PATCH] ARM: dts: Add bandgap DT entry for OMAP5 > > Add bandgap device DT entry for OMAP5 dtsi. > > Cc: Tony Lindgren > Cc: Russell King > Signed-off-by: Eduardo Valentin > Signed-off-by: J Keerthy > Signed-off-by: Benoit Cousson > --- > arch/arm/boot/dts/omap5.dtsi |9 + > 1 file changed, 9 insertions(+) > > diff --git a/arch/arm/boot/dts/omap5.dtsi b/arch/arm/boot/dts/omap5.dtsi > index accab62..47693c9 100644 > --- a/arch/arm/boot/dts/omap5.dtsi > +++ b/arch/arm/boot/dts/omap5.dtsi > @@ -696,5 +696,14 @@ > interrupts = ; > }; > }; > + > + bandgap@4a0021e0 { > + reg = <0x4a0021e0 0xc > +0x4a00232c 0xc > +0x4a002380 0x2c > +0x4a0023C0 0x3c>; > + interrupts = ; > + compatible = "ti,omap5430-bandgap"; > + }; > }; > }; > Looks good to me. Tks Benoit! -- You have got to be excited about what you are doing. (L. Lamport) Eduardo Valentin signature.asc Description: OpenPGP digital signature
Re: [PATCH 1/1] arm: add bandgap DT entry for OMAP5
Hi Eduardo, On 06/18/2013 09:36 PM, Eduardo Valentin wrote: > Add bandgap device DT entry for OMAP5 dtsi. > > Cc: "Benoît Cousson" > Cc: Tony Lindgren > Cc: Russell King > Cc: linux-o...@vger.kernel.org > Cc: devicetree-disc...@lists.ozlabs.org > Cc: linux-arm-ker...@lists.infradead.org > Cc: linux-kernel@vger.kernel.org > Signed-off-by: Eduardo Valentin > Signed-off-by: J Keerthy > --- > arch/arm/boot/dts/omap5.dtsi | 8 > 1 file changed, 8 insertions(+) > --- > > Benoit, > > Sorry for this very late request, but can you please consider > these patches for 3.11 still? > > I completely forgot to send these on my "Enable TI SoC thermal driver" series. > > All best, > > Eduardo > > diff --git a/arch/arm/boot/dts/omap5.dtsi b/arch/arm/boot/dts/omap5.dtsi > index 2ad63c4..5ede6e1 100644 > --- a/arch/arm/boot/dts/omap5.dtsi > +++ b/arch/arm/boot/dts/omap5.dtsi > @@ -615,5 +615,13 @@ > interrupts = <0 80 0x4>; > ti,hwmods = "wd_timer2"; > }; missing blank line > + bandgap { You must use the first address in that case. Otherwise DT will affect a random number and provide a non-standard device name. That does not really matter in theory, but it will looks ugly in the /sys/devices list. > + reg = <0x4a0021e0 0xc > + 0x4a00232c 0xc > + 0x4a002380 0x2c > + 0x4a0023C0 0x3c>; > + interrupts = <0 126 4>; /* talert */ Not well aligned and should use the macros. > + compatible = "ti,omap5430-bandgap"; > + }; > }; > }; > I did the update for you :-) Here is the version I've just applied. Benoit >From f0160bb93467e22f2f8bc77591dcd7e35cdee999 Mon Sep 17 00:00:00 2001 From: Eduardo Valentin Date: Tue, 18 Jun 2013 22:36:38 -0400 Subject: [PATCH] ARM: dts: Add bandgap DT entry for OMAP5 Add bandgap device DT entry for OMAP5 dtsi. Cc: Tony Lindgren Cc: Russell King Signed-off-by: Eduardo Valentin Signed-off-by: J Keerthy Signed-off-by: Benoit Cousson --- arch/arm/boot/dts/omap5.dtsi |9 + 1 file changed, 9 insertions(+) diff --git a/arch/arm/boot/dts/omap5.dtsi b/arch/arm/boot/dts/omap5.dtsi index accab62..47693c9 100644 --- a/arch/arm/boot/dts/omap5.dtsi +++ b/arch/arm/boot/dts/omap5.dtsi @@ -696,5 +696,14 @@ interrupts = ; }; }; + + bandgap@4a0021e0 { + reg = <0x4a0021e0 0xc + 0x4a00232c 0xc + 0x4a002380 0x2c + 0x4a0023C0 0x3c>; + interrupts = ; + compatible = "ti,omap5430-bandgap"; + }; }; }; -- 1.7.9.5 -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
[PATCH 1/1] arm: add bandgap DT entry for OMAP5
Add bandgap device DT entry for OMAP5 dtsi. Cc: "Benoît Cousson" Cc: Tony Lindgren Cc: Russell King Cc: linux-o...@vger.kernel.org Cc: devicetree-disc...@lists.ozlabs.org Cc: linux-arm-ker...@lists.infradead.org Cc: linux-kernel@vger.kernel.org Signed-off-by: Eduardo Valentin Signed-off-by: J Keerthy --- arch/arm/boot/dts/omap5.dtsi | 8 1 file changed, 8 insertions(+) --- Benoit, Sorry for this very late request, but can you please consider these patches for 3.11 still? I completely forgot to send these on my "Enable TI SoC thermal driver" series. All best, Eduardo diff --git a/arch/arm/boot/dts/omap5.dtsi b/arch/arm/boot/dts/omap5.dtsi index 2ad63c4..5ede6e1 100644 --- a/arch/arm/boot/dts/omap5.dtsi +++ b/arch/arm/boot/dts/omap5.dtsi @@ -615,5 +615,13 @@ interrupts = <0 80 0x4>; ti,hwmods = "wd_timer2"; }; + bandgap { + reg = <0x4a0021e0 0xc + 0x4a00232c 0xc + 0x4a002380 0x2c + 0x4a0023C0 0x3c>; + interrupts = <0 126 4>; /* talert */ + compatible = "ti,omap5430-bandgap"; + }; }; }; -- 1.8.2.1.342.gfa7285d -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/