Re: [PATCH 1/1] arm64: dts: mt8183-kukui: Enable thermal Tboard

2021-04-09 Thread Hsin-Yi Wang
On Fri, Apr 9, 2021 at 3:12 PM Michael Kao  wrote:
>
> Add Tboard thermal sensor settings.
>
> pull-up voltage: 1800 mv
> pull-up resistor: 75K
>
> Vsense = pull-up voltage * Rntc / ( pull-up resistor + Rntc )
> AuxIn = Vsense * 4096 / 1500
>
> TEST=boot kukui
>  check /sys/class/thermal/thermal_zone*/type
>  check /sys/class/thermal/thermal_zone*/temp
the TEST lines can be removed.

>
> Signed-off-by: Michael Kao 
> Signed-off-by: Nicolas Boichat 
> ---

Tested-by: Hsin-Yi Wang 

This removes following error:
[   10.882325] generic-adc-thermal thermal-sensor1: Thermal zone
sensor register failed: -19
[   10.911912] generic-adc-thermal thermal-sensor2: Thermal zone
sensor register failed: -19

>  arch/arm64/boot/dts/mediatek/mt8183-kukui.dtsi | 14 ++
>  arch/arm64/boot/dts/mediatek/mt8183.dtsi   |  2 +-
>  2 files changed, 15 insertions(+), 1 deletion(-)
>
> diff --git a/arch/arm64/boot/dts/mediatek/mt8183-kukui.dtsi 
> b/arch/arm64/boot/dts/mediatek/mt8183-kukui.dtsi
> index bf2ad1294dd3..202acb542b12 100644
> --- a/arch/arm64/boot/dts/mediatek/mt8183-kukui.dtsi
> +++ b/arch/arm64/boot/dts/mediatek/mt8183-kukui.dtsi
> @@ -801,6 +801,20 @@
> status = "okay";
>  };
>
> +_zones {
> +   Tboard1 {
> +   polling-delay = <1000>; /* milliseconds */
> +   polling-delay-passive = <0>; /* milliseconds */
> +   thermal-sensors = <_thermistor1>;
> +   };
> +
> +   Tboard2 {
> +   polling-delay = <1000>; /* milliseconds */
> +   polling-delay-passive = <0>; /* milliseconds */
> +   thermal-sensors = <_thermistor2>;
> +   };
> +};
> +
>   {
> status = "okay";
>  };
> diff --git a/arch/arm64/boot/dts/mediatek/mt8183.dtsi 
> b/arch/arm64/boot/dts/mediatek/mt8183.dtsi
> index 1ad0a1d55d53..f0719dbef249 100644
> --- a/arch/arm64/boot/dts/mediatek/mt8183.dtsi
> +++ b/arch/arm64/boot/dts/mediatek/mt8183.dtsi
> @@ -673,7 +673,7 @@
> nvmem-cell-names = "calibration-data";
> };
>
> -   thermal-zones {
> +   thermal_zones: thermal-zones {
> cpu_thermal: cpu_thermal {
> polling-delay-passive = <100>;
> polling-delay = <500>;
> --
> 2.18.0
>


[PATCH 1/1] arm64: dts: mt8183-kukui: Enable thermal Tboard

2021-04-09 Thread Michael Kao
Add Tboard thermal sensor settings.

pull-up voltage: 1800 mv
pull-up resistor: 75K

Vsense = pull-up voltage * Rntc / ( pull-up resistor + Rntc )
AuxIn = Vsense * 4096 / 1500

TEST=boot kukui
 check /sys/class/thermal/thermal_zone*/type
 check /sys/class/thermal/thermal_zone*/temp

Signed-off-by: Michael Kao 
Signed-off-by: Nicolas Boichat 
---
 arch/arm64/boot/dts/mediatek/mt8183-kukui.dtsi | 14 ++
 arch/arm64/boot/dts/mediatek/mt8183.dtsi   |  2 +-
 2 files changed, 15 insertions(+), 1 deletion(-)

diff --git a/arch/arm64/boot/dts/mediatek/mt8183-kukui.dtsi 
b/arch/arm64/boot/dts/mediatek/mt8183-kukui.dtsi
index bf2ad1294dd3..202acb542b12 100644
--- a/arch/arm64/boot/dts/mediatek/mt8183-kukui.dtsi
+++ b/arch/arm64/boot/dts/mediatek/mt8183-kukui.dtsi
@@ -801,6 +801,20 @@
status = "okay";
 };
 
+_zones {
+   Tboard1 {
+   polling-delay = <1000>; /* milliseconds */
+   polling-delay-passive = <0>; /* milliseconds */
+   thermal-sensors = <_thermistor1>;
+   };
+
+   Tboard2 {
+   polling-delay = <1000>; /* milliseconds */
+   polling-delay-passive = <0>; /* milliseconds */
+   thermal-sensors = <_thermistor2>;
+   };
+};
+
  {
status = "okay";
 };
diff --git a/arch/arm64/boot/dts/mediatek/mt8183.dtsi 
b/arch/arm64/boot/dts/mediatek/mt8183.dtsi
index 1ad0a1d55d53..f0719dbef249 100644
--- a/arch/arm64/boot/dts/mediatek/mt8183.dtsi
+++ b/arch/arm64/boot/dts/mediatek/mt8183.dtsi
@@ -673,7 +673,7 @@
nvmem-cell-names = "calibration-data";
};
 
-   thermal-zones {
+   thermal_zones: thermal-zones {
cpu_thermal: cpu_thermal {
polling-delay-passive = <100>;
polling-delay = <500>;
-- 
2.18.0