Re: [PATCH 1/1] edac: fix improper return value
On Sun, Dec 04, 2016 at 02:07:18PM +0800, Pan Bian wrote: > From: Pan Bian> > When the call to zalloc_cpumask_var() fails, returning "false" seems > improper. The real value of macro "false" is 0, and 0 means no error. > This patch fixes the bug, returning "-ENOMEM". > > Bugzilla: https://bugzilla.kernel.org/show_bug.cgi?id=189071 That bugzilla entry wasn't really needed. > Signed-off-by: Pan Bian > --- > drivers/edac/amd64_edac.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) Applied, thanks. -- Regards/Gruss, Boris. Good mailing practices for 400: avoid top-posting and trim the reply.
Re: [PATCH 1/1] edac: fix improper return value
On Sun, Dec 04, 2016 at 02:07:18PM +0800, Pan Bian wrote: > From: Pan Bian > > When the call to zalloc_cpumask_var() fails, returning "false" seems > improper. The real value of macro "false" is 0, and 0 means no error. > This patch fixes the bug, returning "-ENOMEM". > > Bugzilla: https://bugzilla.kernel.org/show_bug.cgi?id=189071 That bugzilla entry wasn't really needed. > Signed-off-by: Pan Bian > --- > drivers/edac/amd64_edac.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) Applied, thanks. -- Regards/Gruss, Boris. Good mailing practices for 400: avoid top-posting and trim the reply.
[PATCH 1/1] edac: fix improper return value
From: Pan BianWhen the call to zalloc_cpumask_var() fails, returning "false" seems improper. The real value of macro "false" is 0, and 0 means no error. This patch fixes the bug, returning "-ENOMEM". Bugzilla: https://bugzilla.kernel.org/show_bug.cgi?id=189071 Signed-off-by: Pan Bian --- drivers/edac/amd64_edac.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/edac/amd64_edac.c b/drivers/edac/amd64_edac.c index ee181c5..72a2c75 100644 --- a/drivers/edac/amd64_edac.c +++ b/drivers/edac/amd64_edac.c @@ -2539,7 +2539,7 @@ static int toggle_ecc_err_reporting(struct ecc_settings *s, u16 nid, bool on) if (!zalloc_cpumask_var(, GFP_KERNEL)) { amd64_warn("%s: error allocating mask\n", __func__); - return false; + return -ENOMEM; } get_cpus_on_this_dct_cpumask(cmask, nid); -- 1.9.1
[PATCH 1/1] edac: fix improper return value
From: Pan Bian When the call to zalloc_cpumask_var() fails, returning "false" seems improper. The real value of macro "false" is 0, and 0 means no error. This patch fixes the bug, returning "-ENOMEM". Bugzilla: https://bugzilla.kernel.org/show_bug.cgi?id=189071 Signed-off-by: Pan Bian --- drivers/edac/amd64_edac.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/edac/amd64_edac.c b/drivers/edac/amd64_edac.c index ee181c5..72a2c75 100644 --- a/drivers/edac/amd64_edac.c +++ b/drivers/edac/amd64_edac.c @@ -2539,7 +2539,7 @@ static int toggle_ecc_err_reporting(struct ecc_settings *s, u16 nid, bool on) if (!zalloc_cpumask_var(, GFP_KERNEL)) { amd64_warn("%s: error allocating mask\n", __func__); - return false; + return -ENOMEM; } get_cpus_on_this_dct_cpumask(cmask, nid); -- 1.9.1