Re: [PATCH 1/1] gpio/vt8500: Convert to devm_ioremap_resource()
On Mon, Mar 4, 2013 at 10:09 AM, Sachin Kamat wrote: > Use the newly introduced devm_ioremap_resource() instead of > devm_request_and_ioremap() which provides more consistent error handling. > > devm_ioremap_resource() provides its own error messages; so all explicit > error messages can be removed from the failure code paths. > > Signed-off-by: Sachin Kamat Patch applied with Tony's and Thierry's ACKs/Reviewed-by. Yours, Linus Walleij -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH 1/1] gpio/vt8500: Convert to devm_ioremap_resource()
Hi Linus, On 4 March 2013 22:38, Tony Prisk wrote: > On Mon, 2013-03-04 at 14:39 +0530, Sachin Kamat wrote: >> Use the newly introduced devm_ioremap_resource() instead of >> devm_request_and_ioremap() which provides more consistent error handling. >> >> devm_ioremap_resource() provides its own error messages; so all explicit >> error messages can be removed from the failure code paths. >> >> Signed-off-by: Sachin Kamat > Acked-by: Tony Prisk Would you be picking this patch up or Grant is gonna handle it? -- With warm regards, Sachin -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH 1/1] gpio/vt8500: Convert to devm_ioremap_resource()
On Mon, 2013-03-04 at 14:39 +0530, Sachin Kamat wrote:
> Use the newly introduced devm_ioremap_resource() instead of
> devm_request_and_ioremap() which provides more consistent error handling.
>
> devm_ioremap_resource() provides its own error messages; so all explicit
> error messages can be removed from the failure code paths.
>
> Signed-off-by: Sachin Kamat
> ---
> drivers/gpio/gpio-vt8500.c |8 +++-
> 1 files changed, 3 insertions(+), 5 deletions(-)
>
> diff --git a/drivers/gpio/gpio-vt8500.c b/drivers/gpio/gpio-vt8500.c
> index 81683ca..b2d8d6f 100644
> --- a/drivers/gpio/gpio-vt8500.c
> +++ b/drivers/gpio/gpio-vt8500.c
> @@ -309,11 +309,9 @@ static int vt8500_gpio_probe(struct platform_device
> *pdev)
> return -ENODEV;
> }
>
> - gpio_base = devm_request_and_ioremap(&pdev->dev, res);
> - if (!gpio_base) {
> - dev_err(&pdev->dev, "Unable to map GPIO registers\n");
> - return -ENOMEM;
> - }
> + gpio_base = devm_ioremap_resource(&pdev->dev, res);
> + if (IS_ERR(gpio_base))
> + return PTR_ERR(gpio_base);
>
> ret = vt8500_add_chips(pdev, gpio_base, of_id->data);
>
Acked-by: Tony Prisk
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH 1/1] gpio/vt8500: Convert to devm_ioremap_resource()
On Mon, Mar 04, 2013 at 02:39:39PM +0530, Sachin Kamat wrote: > Use the newly introduced devm_ioremap_resource() instead of > devm_request_and_ioremap() which provides more consistent error handling. > > devm_ioremap_resource() provides its own error messages; so all explicit > error messages can be removed from the failure code paths. > > Signed-off-by: Sachin Kamat > --- > drivers/gpio/gpio-vt8500.c |8 +++- > 1 files changed, 3 insertions(+), 5 deletions(-) Reviewed-by: Thierry Reding pgpOSHhYaknJl.pgp Description: PGP signature
[PATCH 1/1] gpio/vt8500: Convert to devm_ioremap_resource()
Use the newly introduced devm_ioremap_resource() instead of
devm_request_and_ioremap() which provides more consistent error handling.
devm_ioremap_resource() provides its own error messages; so all explicit
error messages can be removed from the failure code paths.
Signed-off-by: Sachin Kamat
---
drivers/gpio/gpio-vt8500.c |8 +++-
1 files changed, 3 insertions(+), 5 deletions(-)
diff --git a/drivers/gpio/gpio-vt8500.c b/drivers/gpio/gpio-vt8500.c
index 81683ca..b2d8d6f 100644
--- a/drivers/gpio/gpio-vt8500.c
+++ b/drivers/gpio/gpio-vt8500.c
@@ -309,11 +309,9 @@ static int vt8500_gpio_probe(struct platform_device *pdev)
return -ENODEV;
}
- gpio_base = devm_request_and_ioremap(&pdev->dev, res);
- if (!gpio_base) {
- dev_err(&pdev->dev, "Unable to map GPIO registers\n");
- return -ENOMEM;
- }
+ gpio_base = devm_ioremap_resource(&pdev->dev, res);
+ if (IS_ERR(gpio_base))
+ return PTR_ERR(gpio_base);
ret = vt8500_add_chips(pdev, gpio_base, of_id->data);
--
1.7.4.1
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
