Re: [PATCH 1/1] mfd: wm8994: Use devm_regulator_bulk_get API
Hi Sachin, On Tue, Jan 08, 2013 at 02:01:22PM +0530, Sachin Kamat wrote: > devm_regulator_bulk_get is device managed and saves some cleanup > and exit code. > > Signed-off-by: Sachin Kamat > --- > Compile tested against linux-next tree (20130108). > --- > drivers/mfd/wm8994-core.c |7 ++- > 1 files changed, 2 insertions(+), 5 deletions(-) Applied, thanks. Cheers, Samuel. -- Intel Open Source Technology Centre http://oss.intel.com/ -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH 1/1] mfd: wm8994: Use devm_regulator_bulk_get API
Hi Sachin, On Tue, Jan 08, 2013 at 02:01:22PM +0530, Sachin Kamat wrote: devm_regulator_bulk_get is device managed and saves some cleanup and exit code. Signed-off-by: Sachin Kamat sachin.ka...@linaro.org --- Compile tested against linux-next tree (20130108). --- drivers/mfd/wm8994-core.c |7 ++- 1 files changed, 2 insertions(+), 5 deletions(-) Applied, thanks. Cheers, Samuel. -- Intel Open Source Technology Centre http://oss.intel.com/ -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH 1/1] mfd: wm8994: Use devm_regulator_bulk_get API
On 27 January 2013 05:52, Samuel Ortiz wrote: > Hi Sachin, > > On Thu, Jan 24, 2013 at 09:13:20AM +0530, Sachin Kamat wrote: >> Hi Samuel, >> >> On 8 January 2013 16:06, Mark Brown >> wrote: >> > On Tue, Jan 08, 2013 at 02:01:22PM +0530, Sachin Kamat wrote: >> >> devm_regulator_bulk_get is device managed and saves some cleanup >> >> and exit code. >> > >> > Acked-by: Mark Brown >> >> Would you be picking this patch up? > I will, yes. Thanks Samuel. There is also another patch that needs your attention (pending for a while). https://lkml.org/lkml/2012/12/7/65 -- With warm regards, Sachin -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH 1/1] mfd: wm8994: Use devm_regulator_bulk_get API
On 27 January 2013 05:52, Samuel Ortiz sa...@linux.intel.com wrote: Hi Sachin, On Thu, Jan 24, 2013 at 09:13:20AM +0530, Sachin Kamat wrote: Hi Samuel, On 8 January 2013 16:06, Mark Brown broo...@opensource.wolfsonmicro.com wrote: On Tue, Jan 08, 2013 at 02:01:22PM +0530, Sachin Kamat wrote: devm_regulator_bulk_get is device managed and saves some cleanup and exit code. Acked-by: Mark Brown broo...@opensource.wolfsonmicro.com Would you be picking this patch up? I will, yes. Thanks Samuel. There is also another patch that needs your attention (pending for a while). https://lkml.org/lkml/2012/12/7/65 -- With warm regards, Sachin -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH 1/1] mfd: wm8994: Use devm_regulator_bulk_get API
Hi Sachin, On Thu, Jan 24, 2013 at 09:13:20AM +0530, Sachin Kamat wrote: > Hi Samuel, > > On 8 January 2013 16:06, Mark Brown > wrote: > > On Tue, Jan 08, 2013 at 02:01:22PM +0530, Sachin Kamat wrote: > >> devm_regulator_bulk_get is device managed and saves some cleanup > >> and exit code. > > > > Acked-by: Mark Brown > > Would you be picking this patch up? I will, yes. Cheers, Samuel. -- Intel Open Source Technology Centre http://oss.intel.com/ -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH 1/1] mfd: wm8994: Use devm_regulator_bulk_get API
Hi Sachin, On Thu, Jan 24, 2013 at 09:13:20AM +0530, Sachin Kamat wrote: Hi Samuel, On 8 January 2013 16:06, Mark Brown broo...@opensource.wolfsonmicro.com wrote: On Tue, Jan 08, 2013 at 02:01:22PM +0530, Sachin Kamat wrote: devm_regulator_bulk_get is device managed and saves some cleanup and exit code. Acked-by: Mark Brown broo...@opensource.wolfsonmicro.com Would you be picking this patch up? I will, yes. Cheers, Samuel. -- Intel Open Source Technology Centre http://oss.intel.com/ -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH 1/1] mfd: wm8994: Use devm_regulator_bulk_get API
Hi Samuel, On 8 January 2013 16:06, Mark Brown wrote: > On Tue, Jan 08, 2013 at 02:01:22PM +0530, Sachin Kamat wrote: >> devm_regulator_bulk_get is device managed and saves some cleanup >> and exit code. > > Acked-by: Mark Brown Would you be picking this patch up? -- With warm regards, Sachin -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH 1/1] mfd: wm8994: Use devm_regulator_bulk_get API
Hi Samuel, On 8 January 2013 16:06, Mark Brown broo...@opensource.wolfsonmicro.com wrote: On Tue, Jan 08, 2013 at 02:01:22PM +0530, Sachin Kamat wrote: devm_regulator_bulk_get is device managed and saves some cleanup and exit code. Acked-by: Mark Brown broo...@opensource.wolfsonmicro.com Would you be picking this patch up? -- With warm regards, Sachin -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH 1/1] mfd: wm8994: Use devm_regulator_bulk_get API
On Tue, Jan 08, 2013 at 02:01:22PM +0530, Sachin Kamat wrote: > devm_regulator_bulk_get is device managed and saves some cleanup > and exit code. Acked-by: Mark Brown signature.asc Description: Digital signature
[PATCH 1/1] mfd: wm8994: Use devm_regulator_bulk_get API
devm_regulator_bulk_get is device managed and saves some cleanup
and exit code.
Signed-off-by: Sachin Kamat
---
Compile tested against linux-next tree (20130108).
---
drivers/mfd/wm8994-core.c |7 ++-
1 files changed, 2 insertions(+), 5 deletions(-)
diff --git a/drivers/mfd/wm8994-core.c b/drivers/mfd/wm8994-core.c
index 57c488d..803e93f 100644
--- a/drivers/mfd/wm8994-core.c
+++ b/drivers/mfd/wm8994-core.c
@@ -467,7 +467,7 @@ static int wm8994_device_init(struct wm8994 *wm8994, int
irq)
goto err;
}
- ret = regulator_bulk_get(wm8994->dev, wm8994->num_supplies,
+ ret = devm_regulator_bulk_get(wm8994->dev, wm8994->num_supplies,
wm8994->supplies);
if (ret != 0) {
dev_err(wm8994->dev, "Failed to get supplies: %d\n", ret);
@@ -478,7 +478,7 @@ static int wm8994_device_init(struct wm8994 *wm8994, int
irq)
wm8994->supplies);
if (ret != 0) {
dev_err(wm8994->dev, "Failed to enable supplies: %d\n", ret);
- goto err_get;
+ goto err;
}
ret = wm8994_reg_read(wm8994, WM8994_SOFTWARE_RESET);
@@ -658,8 +658,6 @@ err_irq:
err_enable:
regulator_bulk_disable(wm8994->num_supplies,
wm8994->supplies);
-err_get:
- regulator_bulk_free(wm8994->num_supplies, wm8994->supplies);
err:
mfd_remove_devices(wm8994->dev);
return ret;
@@ -672,7 +670,6 @@ static void wm8994_device_exit(struct wm8994 *wm8994)
wm8994_irq_exit(wm8994);
regulator_bulk_disable(wm8994->num_supplies,
wm8994->supplies);
- regulator_bulk_free(wm8994->num_supplies, wm8994->supplies);
}
static const struct of_device_id wm8994_of_match[] = {
--
1.7.4.1
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
[PATCH 1/1] mfd: wm8994: Use devm_regulator_bulk_get API
devm_regulator_bulk_get is device managed and saves some cleanup
and exit code.
Signed-off-by: Sachin Kamat sachin.ka...@linaro.org
---
Compile tested against linux-next tree (20130108).
---
drivers/mfd/wm8994-core.c |7 ++-
1 files changed, 2 insertions(+), 5 deletions(-)
diff --git a/drivers/mfd/wm8994-core.c b/drivers/mfd/wm8994-core.c
index 57c488d..803e93f 100644
--- a/drivers/mfd/wm8994-core.c
+++ b/drivers/mfd/wm8994-core.c
@@ -467,7 +467,7 @@ static int wm8994_device_init(struct wm8994 *wm8994, int
irq)
goto err;
}
- ret = regulator_bulk_get(wm8994-dev, wm8994-num_supplies,
+ ret = devm_regulator_bulk_get(wm8994-dev, wm8994-num_supplies,
wm8994-supplies);
if (ret != 0) {
dev_err(wm8994-dev, Failed to get supplies: %d\n, ret);
@@ -478,7 +478,7 @@ static int wm8994_device_init(struct wm8994 *wm8994, int
irq)
wm8994-supplies);
if (ret != 0) {
dev_err(wm8994-dev, Failed to enable supplies: %d\n, ret);
- goto err_get;
+ goto err;
}
ret = wm8994_reg_read(wm8994, WM8994_SOFTWARE_RESET);
@@ -658,8 +658,6 @@ err_irq:
err_enable:
regulator_bulk_disable(wm8994-num_supplies,
wm8994-supplies);
-err_get:
- regulator_bulk_free(wm8994-num_supplies, wm8994-supplies);
err:
mfd_remove_devices(wm8994-dev);
return ret;
@@ -672,7 +670,6 @@ static void wm8994_device_exit(struct wm8994 *wm8994)
wm8994_irq_exit(wm8994);
regulator_bulk_disable(wm8994-num_supplies,
wm8994-supplies);
- regulator_bulk_free(wm8994-num_supplies, wm8994-supplies);
}
static const struct of_device_id wm8994_of_match[] = {
--
1.7.4.1
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH 1/1] mfd: wm8994: Use devm_regulator_bulk_get API
On Tue, Jan 08, 2013 at 02:01:22PM +0530, Sachin Kamat wrote: devm_regulator_bulk_get is device managed and saves some cleanup and exit code. Acked-by: Mark Brown broo...@opensource.wolfsonmicro.com signature.asc Description: Digital signature
