Re: [PATCH 1/1] net: dcb: set error code on failures

[David Miller]

From: Pan Bian 
Date: Sat,  3 Dec 2016 21:49:08 +0800

> From: Pan Bian 
> 
> In function dcbnl_cee_fill(), returns the value of variable err on
> errors. However, on some error paths (e.g. nla put fails), its value may
> be 0. It may be better to explicitly set a negative errno to variable
> err before returning.
> 
> Bugzilla: https://bugzilla.kernel.org/show_bug.cgi?id=11
> 
> Signed-off-by: Pan Bian 

Applied, thanks.

Re: [PATCH 1/1] net: dcb: set error code on failures

[David Miller]

From: Pan Bian 
Date: Sat,  3 Dec 2016 21:49:08 +0800

> From: Pan Bian 
> 
> In function dcbnl_cee_fill(), returns the value of variable err on
> errors. However, on some error paths (e.g. nla put fails), its value may
> be 0. It may be better to explicitly set a negative errno to variable
> err before returning.
> 
> Bugzilla: https://bugzilla.kernel.org/show_bug.cgi?id=11
> 
> Signed-off-by: Pan Bian 

Applied, thanks.

[PATCH 1/1] net: dcb: set error code on failures

[Pan Bian]

From: Pan Bian 

In function dcbnl_cee_fill(), returns the value of variable err on
errors. However, on some error paths (e.g. nla put fails), its value may
be 0. It may be better to explicitly set a negative errno to variable
err before returning.

Bugzilla: https://bugzilla.kernel.org/show_bug.cgi?id=11

Signed-off-by: Pan Bian 
---
 net/dcb/dcbnl.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/net/dcb/dcbnl.c b/net/dcb/dcbnl.c
index 4f6c186..3202d75 100644
--- a/net/dcb/dcbnl.c
+++ b/net/dcb/dcbnl.c
@@ -1353,6 +1353,7 @@ static int dcbnl_cee_fill(struct sk_buff *skb, struct 
net_device *netdev)
 dcb_unlock:
spin_unlock_bh(_lock);
 nla_put_failure:
+   err = -EMSGSIZE;
return err;
 }
 
-- 
1.9.1

[PATCH 1/1] net: dcb: set error code on failures

[Pan Bian]

From: Pan Bian 

In function dcbnl_cee_fill(), returns the value of variable err on
errors. However, on some error paths (e.g. nla put fails), its value may
be 0. It may be better to explicitly set a negative errno to variable
err before returning.

Bugzilla: https://bugzilla.kernel.org/show_bug.cgi?id=11

Signed-off-by: Pan Bian 
---
 net/dcb/dcbnl.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/net/dcb/dcbnl.c b/net/dcb/dcbnl.c
index 4f6c186..3202d75 100644
--- a/net/dcb/dcbnl.c
+++ b/net/dcb/dcbnl.c
@@ -1353,6 +1353,7 @@ static int dcbnl_cee_fill(struct sk_buff *skb, struct 
net_device *netdev)
 dcb_unlock:
spin_unlock_bh(_lock);
 nla_put_failure:
+   err = -EMSGSIZE;
return err;
 }
 
-- 
1.9.1