Re: [PATCH 1/1] scripts/package/Makefile: remove useless KBUILD_OUTPUT test
On Mon, Jan 21, 2013 at 03:28:05PM +0800, Bin Wang wrote: > The test of KBUILD_OUTPUT in "rpm-pkg rpm" target is useless. > KBUILD_OUTPUT is always empty here. Right, but the error message is valid, make rpm-pkg does not work with O=. So I suggest to either fix make O=... rpm-pkg, or fix the test to compare $(srctree) and $(objtree) instead. Michal -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH 1/1] scripts/package/Makefile: remove useless KBUILD_OUTPUT test
On Mon, Jan 21, 2013 at 03:28:05PM +0800, Bin Wang wrote: The test of KBUILD_OUTPUT in rpm-pkg rpm target is useless. KBUILD_OUTPUT is always empty here. Right, but the error message is valid, make rpm-pkg does not work with O=. So I suggest to either fix make O=... rpm-pkg, or fix the test to compare $(srctree) and $(objtree) instead. Michal -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
[PATCH 1/1] scripts/package/Makefile: remove useless KBUILD_OUTPUT test
The test of KBUILD_OUTPUT in "rpm-pkg rpm" target is useless. KBUILD_OUTPUT is always empty here. Signed-off-by: Bin Wang --- scripts/package/Makefile | 6 -- 1 file changed, 6 deletions(-) diff --git a/scripts/package/Makefile b/scripts/package/Makefile index 87bf080..ba073a6 100644 --- a/scripts/package/Makefile +++ b/scripts/package/Makefile @@ -36,12 +36,6 @@ $(objtree)/kernel.spec: $(MKSPEC) $(srctree)/Makefile $(CONFIG_SHELL) $(MKSPEC) > $@ rpm-pkg rpm: $(objtree)/kernel.spec FORCE - @if test -n "$(KBUILD_OUTPUT)"; then \ - echo "Building source + binary RPM is not possible outside the"; \ - echo "kernel source tree. Don't set KBUILD_OUTPUT, or use the"; \ - echo "binrpm-pkg target instead."; \ - false; \ - fi $(MAKE) clean $(PREV) ln -sf $(srctree) $(KERNELPATH) $(CONFIG_SHELL) $(srctree)/scripts/setlocalversion --save-scmversion -- 1.7.11.7 -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
[PATCH 1/1] scripts/package/Makefile: remove useless KBUILD_OUTPUT test
The test of KBUILD_OUTPUT in rpm-pkg rpm target is useless. KBUILD_OUTPUT is always empty here. Signed-off-by: Bin Wang wbi...@gmail.com --- scripts/package/Makefile | 6 -- 1 file changed, 6 deletions(-) diff --git a/scripts/package/Makefile b/scripts/package/Makefile index 87bf080..ba073a6 100644 --- a/scripts/package/Makefile +++ b/scripts/package/Makefile @@ -36,12 +36,6 @@ $(objtree)/kernel.spec: $(MKSPEC) $(srctree)/Makefile $(CONFIG_SHELL) $(MKSPEC) $@ rpm-pkg rpm: $(objtree)/kernel.spec FORCE - @if test -n $(KBUILD_OUTPUT); then \ - echo Building source + binary RPM is not possible outside the; \ - echo kernel source tree. Don't set KBUILD_OUTPUT, or use the; \ - echo binrpm-pkg target instead.; \ - false; \ - fi $(MAKE) clean $(PREV) ln -sf $(srctree) $(KERNELPATH) $(CONFIG_SHELL) $(srctree)/scripts/setlocalversion --save-scmversion -- 1.7.11.7 -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
