Re: [PATCH 1/1 v2] isdn: hisax: set error code on failure

2016-12-05 Thread David Miller 
From: Pan Bian 
Date: Sun,  4 Dec 2016 18:43:31 +0800

> From: Pan Bian 
> 
> In function hfc4s8s_probe(), the value of return variable err should be
> negative on failures. However, when the call to request_region() returns
> NULL, the value of err is 0. This patch fixes the bug, assigning
> "-EBUSY" to err on the path that request_region() fails.
> 
> Bugzilla: https://bugzilla.kernel.org/show_bug.cgi?id=188931
> 
> Signed-off-by: Pan Bian 

Applied.

Re: [PATCH 1/1 v2] isdn: hisax: set error code on failure

2016-12-05 Thread David Miller 
From: Pan Bian 
Date: Sun,  4 Dec 2016 18:43:31 +0800

> From: Pan Bian 
> 
> In function hfc4s8s_probe(), the value of return variable err should be
> negative on failures. However, when the call to request_region() returns
> NULL, the value of err is 0. This patch fixes the bug, assigning
> "-EBUSY" to err on the path that request_region() fails.
> 
> Bugzilla: https://bugzilla.kernel.org/show_bug.cgi?id=188931
> 
> Signed-off-by: Pan Bian 

Applied.

[PATCH 1/1 v2] isdn: hisax: set error code on failure

2016-12-04 Thread Pan Bian 
From: Pan Bian 

In function hfc4s8s_probe(), the value of return variable err should be
negative on failures. However, when the call to request_region() returns
NULL, the value of err is 0. This patch fixes the bug, assigning
"-EBUSY" to err on the path that request_region() fails.

Bugzilla: https://bugzilla.kernel.org/show_bug.cgi?id=188931

Signed-off-by: Pan Bian 
---
 drivers/isdn/hisax/hfc4s8s_l1.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/isdn/hisax/hfc4s8s_l1.c b/drivers/isdn/hisax/hfc4s8s_l1.c
index 9600cd7..3172cee 100644
--- a/drivers/isdn/hisax/hfc4s8s_l1.c
+++ b/drivers/isdn/hisax/hfc4s8s_l1.c
@@ -1499,6 +1499,7 @@ struct hfc4s8s_l1 {
printk(KERN_INFO
   "HFC-4S/8S: failed to request address space at 0x%04x\n",
   hw->iobase);
+   err = -EBUSY;
goto out;
}
 
-- 
1.9.1

[PATCH 1/1 v2] isdn: hisax: set error code on failure

2016-12-04 Thread Pan Bian 
From: Pan Bian 

In function hfc4s8s_probe(), the value of return variable err should be
negative on failures. However, when the call to request_region() returns
NULL, the value of err is 0. This patch fixes the bug, assigning
"-EBUSY" to err on the path that request_region() fails.

Bugzilla: https://bugzilla.kernel.org/show_bug.cgi?id=188931

Signed-off-by: Pan Bian 
---
 drivers/isdn/hisax/hfc4s8s_l1.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/isdn/hisax/hfc4s8s_l1.c b/drivers/isdn/hisax/hfc4s8s_l1.c
index 9600cd7..3172cee 100644
--- a/drivers/isdn/hisax/hfc4s8s_l1.c
+++ b/drivers/isdn/hisax/hfc4s8s_l1.c
@@ -1499,6 +1499,7 @@ struct hfc4s8s_l1 {
printk(KERN_INFO
   "HFC-4S/8S: failed to request address space at 0x%04x\n",
   hw->iobase);
+   err = -EBUSY;
goto out;
}
 
-- 
1.9.1