Re: [PATCH 1/2] [net/wireless/iwlwifi] : iwlwifi 3945 Fix raceconditional panic.

2007-12-12 Thread Joonwoo Park 
2007/12/12, Andrew Morton <[EMAIL PROTECTED]>:
>
> Did drivers/net/wireless/iwlwifi/iwl4965-base.c get fixed in a simlar
> fashion?
>

Hi Andrew,
Both of them was applied to mainline.

commit 3ae6a054553ee8b7f74bf7de8904022b26705778
Author: Joonwoo Park <[EMAIL PROTECTED]>
Date:   Thu Nov 29 10:43:16 2007 +0900

iwlwifi 4965 Fix race conditional panic.

Signed-off-by: Joonwoo Park <[EMAIL PROTECTED]>
Signed-off-by: John W. Linville <[EMAIL PROTECTED]>

commit e47eb6ad41e8fc4c2696665512b70d1fd4cf3f22
Author: Joonwoo Park <[EMAIL PROTECTED]>
Date:   Thu Nov 29 10:42:49 2007 +0900

iwlwifi 3945 Fix race conditional panic.

Signed-off-by: Joonwoo Park <[EMAIL PROTECTED]>
Signed-off-by: John W. Linville <[EMAIL PROTECTED]>

Thanks,
Joonwoo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Re: [PATCH 1/2] [net/wireless/iwlwifi] : iwlwifi 3945 Fix raceconditional panic.

2007-12-12 Thread Andrew Morton 
On Thu, 29 Nov 2007 10:42:49 +0900 "Joonwoo Park" <[EMAIL PROTECTED]> wrote:

> 2007/11/29, Zhu Yi <[EMAIL PROTECTED]>:
> > 
> > Good catch. But it will be better if you add it into
> > iwl_cancel_deferred_work().
> > 
> 
> Thanks.
> I agree with you. 
> Actually, I considered it, but I was afraid of side effect.
> Anyway, I'm attaching a new one.
> 
> Thanks.
> Joonwoo
> 
> [net/wireless/iwlwifi] : iwlwifi 3945 Fix race conditional panic.
> 
> Signed-off-by: Joonwoo Park <[EMAIL PROTECTED]>
> ---
> diff --git a/drivers/net/wireless/iwlwifi/iwl3945-base.c 
> b/drivers/net/wireless/iwlwifi/iwl3945-base.c
> index 465da4f..e51e872 100644
> --- a/drivers/net/wireless/iwlwifi/iwl3945-base.c
> +++ b/drivers/net/wireless/iwlwifi/iwl3945-base.c
> @@ -8270,6 +8270,7 @@ static void iwl_cancel_deferred_work(struct iwl_priv 
> *priv)
>  {
>   iwl_hw_cancel_deferred_work(priv);
>  
> + cancel_delayed_work_sync(>init_alive_start);
>   cancel_delayed_work(>scan_check);
>   cancel_delayed_work(>alive_start);
>   cancel_delayed_work(>post_associate);

Did drivers/net/wireless/iwlwifi/iwl4965-base.c get fixed in a simlar
fashion?
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Re: [PATCH 1/2] [net/wireless/iwlwifi] : iwlwifi 3945 Fix raceconditional panic.

2007-12-12 Thread Andrew Morton 
On Thu, 29 Nov 2007 10:42:49 +0900 Joonwoo Park [EMAIL PROTECTED] wrote:

 2007/11/29, Zhu Yi [EMAIL PROTECTED]:
  
  Good catch. But it will be better if you add it into
  iwl_cancel_deferred_work().
  
 
 Thanks.
 I agree with you. 
 Actually, I considered it, but I was afraid of side effect.
 Anyway, I'm attaching a new one.
 
 Thanks.
 Joonwoo
 
 [net/wireless/iwlwifi] : iwlwifi 3945 Fix race conditional panic.
 
 Signed-off-by: Joonwoo Park [EMAIL PROTECTED]
 ---
 diff --git a/drivers/net/wireless/iwlwifi/iwl3945-base.c 
 b/drivers/net/wireless/iwlwifi/iwl3945-base.c
 index 465da4f..e51e872 100644
 --- a/drivers/net/wireless/iwlwifi/iwl3945-base.c
 +++ b/drivers/net/wireless/iwlwifi/iwl3945-base.c
 @@ -8270,6 +8270,7 @@ static void iwl_cancel_deferred_work(struct iwl_priv 
 *priv)
  {
   iwl_hw_cancel_deferred_work(priv);
  
 + cancel_delayed_work_sync(priv-init_alive_start);
   cancel_delayed_work(priv-scan_check);
   cancel_delayed_work(priv-alive_start);
   cancel_delayed_work(priv-post_associate);

Did drivers/net/wireless/iwlwifi/iwl4965-base.c get fixed in a simlar
fashion?
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to [EMAIL PROTECTED]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Re: [PATCH 1/2] [net/wireless/iwlwifi] : iwlwifi 3945 Fix raceconditional panic.

2007-12-12 Thread Joonwoo Park 
2007/12/12, Andrew Morton [EMAIL PROTECTED]:

 Did drivers/net/wireless/iwlwifi/iwl4965-base.c get fixed in a simlar
 fashion?


Hi Andrew,
Both of them was applied to mainline.

commit 3ae6a054553ee8b7f74bf7de8904022b26705778
Author: Joonwoo Park [EMAIL PROTECTED]
Date:   Thu Nov 29 10:43:16 2007 +0900

iwlwifi 4965 Fix race conditional panic.

Signed-off-by: Joonwoo Park [EMAIL PROTECTED]
Signed-off-by: John W. Linville [EMAIL PROTECTED]

commit e47eb6ad41e8fc4c2696665512b70d1fd4cf3f22
Author: Joonwoo Park [EMAIL PROTECTED]
Date:   Thu Nov 29 10:42:49 2007 +0900

iwlwifi 3945 Fix race conditional panic.

Signed-off-by: Joonwoo Park [EMAIL PROTECTED]
Signed-off-by: John W. Linville [EMAIL PROTECTED]

Thanks,
Joonwoo
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to [EMAIL PROTECTED]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

RE: [PATCH 1/2] [net/wireless/iwlwifi] : iwlwifi 3945 Fix raceconditional panic.

2007-11-28 Thread Joonwoo Park 
2007/11/29, Zhu Yi <[EMAIL PROTECTED]>:
> 
> Good catch. But it will be better if you add it into
> iwl_cancel_deferred_work().
> 

Thanks.
I agree with you. 
Actually, I considered it, but I was afraid of side effect.
Anyway, I'm attaching a new one.

Thanks.
Joonwoo

[net/wireless/iwlwifi] : iwlwifi 3945 Fix race conditional panic.

Signed-off-by: Joonwoo Park <[EMAIL PROTECTED]>
---
diff --git a/drivers/net/wireless/iwlwifi/iwl3945-base.c 
b/drivers/net/wireless/iwlwifi/iwl3945-base.c
index 465da4f..e51e872 100644
--- a/drivers/net/wireless/iwlwifi/iwl3945-base.c
+++ b/drivers/net/wireless/iwlwifi/iwl3945-base.c
@@ -8270,6 +8270,7 @@ static void iwl_cancel_deferred_work(struct iwl_priv 
*priv)
 {
iwl_hw_cancel_deferred_work(priv);
 
+   cancel_delayed_work_sync(>init_alive_start);
cancel_delayed_work(>scan_check);
cancel_delayed_work(>alive_start);
cancel_delayed_work(>post_associate);
---

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

RE: [PATCH 1/2] [net/wireless/iwlwifi] : iwlwifi 3945 Fix raceconditional panic.

2007-11-28 Thread Joonwoo Park 
2007/11/29, Zhu Yi [EMAIL PROTECTED]:
 
 Good catch. But it will be better if you add it into
 iwl_cancel_deferred_work().
 

Thanks.
I agree with you. 
Actually, I considered it, but I was afraid of side effect.
Anyway, I'm attaching a new one.

Thanks.
Joonwoo

[net/wireless/iwlwifi] : iwlwifi 3945 Fix race conditional panic.

Signed-off-by: Joonwoo Park [EMAIL PROTECTED]
---
diff --git a/drivers/net/wireless/iwlwifi/iwl3945-base.c 
b/drivers/net/wireless/iwlwifi/iwl3945-base.c
index 465da4f..e51e872 100644
--- a/drivers/net/wireless/iwlwifi/iwl3945-base.c
+++ b/drivers/net/wireless/iwlwifi/iwl3945-base.c
@@ -8270,6 +8270,7 @@ static void iwl_cancel_deferred_work(struct iwl_priv 
*priv)
 {
iwl_hw_cancel_deferred_work(priv);
 
+   cancel_delayed_work_sync(priv-init_alive_start);
cancel_delayed_work(priv-scan_check);
cancel_delayed_work(priv-alive_start);
cancel_delayed_work(priv-post_associate);
---

-
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to [EMAIL PROTECTED]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/