Re: [PATCH 1/2] Documentation: devicetree: Add new compatible string for eeprom microchip 93LC46B
Hi Rob, On 01/01/21 12:47 am, Rob Herring wrote: > On Fri, Dec 18, 2020 at 07:38:10PM +0530, Aswath Govindraju wrote: >> Add a new compatible string for eeprom microchip 93LC46B in eeprom-93xx46 >> dt-binding file as it belongs to the 93xx46 family of devices. >> >> Signed-off-by: Aswath Govindraju >> --- >> Documentation/devicetree/bindings/misc/eeprom-93xx46.txt | 1 + >> 1 file changed, 1 insertion(+) >> >> diff --git a/Documentation/devicetree/bindings/misc/eeprom-93xx46.txt >> b/Documentation/devicetree/bindings/misc/eeprom-93xx46.txt >> index a8ebb4621f79..9f272361f117 100644 >> --- a/Documentation/devicetree/bindings/misc/eeprom-93xx46.txt >> +++ b/Documentation/devicetree/bindings/misc/eeprom-93xx46.txt >> @@ -4,6 +4,7 @@ Required properties: >> - compatible : shall be one of: >> "atmel,at93c46d" >> "eeprom-93xx46" >> +"microchip,93LC46B" > > Generally, we use lowercase and that's the existing pattern here. ohh ok. I was trying to match the compatible string exactly with the the device name. I will make this change in the respin. Thanks, Aswath > >> - data-size : number of data bits per word (either 8 or 16) >> >> Optional properties: >> -- >> 2.17.1 >>
Re: [PATCH 1/2] Documentation: devicetree: Add new compatible string for eeprom microchip 93LC46B
On Fri, Dec 18, 2020 at 07:38:10PM +0530, Aswath Govindraju wrote: > Add a new compatible string for eeprom microchip 93LC46B in eeprom-93xx46 > dt-binding file as it belongs to the 93xx46 family of devices. > > Signed-off-by: Aswath Govindraju > --- > Documentation/devicetree/bindings/misc/eeprom-93xx46.txt | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/Documentation/devicetree/bindings/misc/eeprom-93xx46.txt > b/Documentation/devicetree/bindings/misc/eeprom-93xx46.txt > index a8ebb4621f79..9f272361f117 100644 > --- a/Documentation/devicetree/bindings/misc/eeprom-93xx46.txt > +++ b/Documentation/devicetree/bindings/misc/eeprom-93xx46.txt > @@ -4,6 +4,7 @@ Required properties: > - compatible : shall be one of: > "atmel,at93c46d" > "eeprom-93xx46" > +"microchip,93LC46B" Generally, we use lowercase and that's the existing pattern here. > - data-size : number of data bits per word (either 8 or 16) > > Optional properties: > -- > 2.17.1 >
[PATCH 1/2] Documentation: devicetree: Add new compatible string for eeprom microchip 93LC46B
Add a new compatible string for eeprom microchip 93LC46B in eeprom-93xx46 dt-binding file as it belongs to the 93xx46 family of devices. Signed-off-by: Aswath Govindraju --- Documentation/devicetree/bindings/misc/eeprom-93xx46.txt | 1 + 1 file changed, 1 insertion(+) diff --git a/Documentation/devicetree/bindings/misc/eeprom-93xx46.txt b/Documentation/devicetree/bindings/misc/eeprom-93xx46.txt index a8ebb4621f79..9f272361f117 100644 --- a/Documentation/devicetree/bindings/misc/eeprom-93xx46.txt +++ b/Documentation/devicetree/bindings/misc/eeprom-93xx46.txt @@ -4,6 +4,7 @@ Required properties: - compatible : shall be one of: "atmel,at93c46d" "eeprom-93xx46" +"microchip,93LC46B" - data-size : number of data bits per word (either 8 or 16) Optional properties: -- 2.17.1
