Re: [PATCH 1/2] MIPS: ralink: Fix build error due to missing header

[Harvey Hunt]

Hi Ralf,

On 18/07/17 23:01, Ralf Baechle wrote:

On Tue, Jul 18, 2017 at 02:25:45PM +0100, Harvey Hunt wrote:


Previously,  was included before ralink_regs.h in all
ralink files - leading to  being implicitly included.

After commit 26dd3e4ff9ac ("MIPS: Audit and remove any unnecessary
uses of module.h") removed the inclusion of module.h from multiple
places, some ralink platforms failed to build with the following error:

In file included from arch/mips/ralink/mt7620.c:17:0:
./arch/mips/include/asm/mach-ralink/ralink_regs.h: In function ‘rt_sysc_w32’:
./arch/mips/include/asm/mach-ralink/ralink_regs.h:38:2: error: implicit 
declaration of function ‘__raw_writel’ [-Werror=implicit-function-declaration]
   __raw_writel(val, rt_sysc_membase + reg);
   ^
./arch/mips/include/asm/mach-ralink/ralink_regs.h: In function ‘rt_sysc_r32’:
./arch/mips/include/asm/mach-ralink/ralink_regs.h:43:2: error: implicit 
declaration of function ‘__raw_readl’ [-Werror=implicit-function-declaration]
   return __raw_readl(rt_sysc_membase + reg);

Fix this by including .


Looks sensible, applied.  But I'm wondering why I don't see this in my
test builds.


Thanks for merging them. There isn't currently a defconfig for this 
platform, but I am working on adding one.




   Ralf



Thanks,

Harvey

Re: [PATCH 1/2] MIPS: ralink: Fix build error due to missing header

[Ralf Baechle]

On Tue, Jul 18, 2017 at 02:25:45PM +0100, Harvey Hunt wrote:

> Previously,  was included before ralink_regs.h in all
> ralink files - leading to  being implicitly included.
> 
> After commit 26dd3e4ff9ac ("MIPS: Audit and remove any unnecessary
> uses of module.h") removed the inclusion of module.h from multiple
> places, some ralink platforms failed to build with the following error:
> 
> In file included from arch/mips/ralink/mt7620.c:17:0:
> ./arch/mips/include/asm/mach-ralink/ralink_regs.h: In function ‘rt_sysc_w32’:
> ./arch/mips/include/asm/mach-ralink/ralink_regs.h:38:2: error: implicit 
> declaration of function ‘__raw_writel’ [-Werror=implicit-function-declaration]
>   __raw_writel(val, rt_sysc_membase + reg);
>   ^
> ./arch/mips/include/asm/mach-ralink/ralink_regs.h: In function ‘rt_sysc_r32’:
> ./arch/mips/include/asm/mach-ralink/ralink_regs.h:43:2: error: implicit 
> declaration of function ‘__raw_readl’ [-Werror=implicit-function-declaration]
>   return __raw_readl(rt_sysc_membase + reg);
> 
> Fix this by including .

Looks sensible, applied.  But I'm wondering why I don't see this in my
test builds.

  Ralf

[PATCH 1/2] MIPS: ralink: Fix build error due to missing header

[Harvey Hunt]

Previously,  was included before ralink_regs.h in all
ralink files - leading to  being implicitly included.

After commit 26dd3e4ff9ac ("MIPS: Audit and remove any unnecessary
uses of module.h") removed the inclusion of module.h from multiple
places, some ralink platforms failed to build with the following error:

In file included from arch/mips/ralink/mt7620.c:17:0:
./arch/mips/include/asm/mach-ralink/ralink_regs.h: In function ‘rt_sysc_w32’:
./arch/mips/include/asm/mach-ralink/ralink_regs.h:38:2: error: implicit 
declaration of function ‘__raw_writel’ [-Werror=implicit-function-declaration]
  __raw_writel(val, rt_sysc_membase + reg);
  ^
./arch/mips/include/asm/mach-ralink/ralink_regs.h: In function ‘rt_sysc_r32’:
./arch/mips/include/asm/mach-ralink/ralink_regs.h:43:2: error: implicit 
declaration of function ‘__raw_readl’ [-Werror=implicit-function-declaration]
  return __raw_readl(rt_sysc_membase + reg);

Fix this by including .

Signed-off-by: Harvey Hunt 
Fixes: 26dd3e4ff9ac ("MIPS: Audit and remove any unnecessary uses of module.h")
Cc:  #4.11+
Cc: John Crispin 
Cc: linux-m...@linux-mips.org
Cc: linux-kernel@vger.kernel.org
---
 arch/mips/include/asm/mach-ralink/ralink_regs.h | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/arch/mips/include/asm/mach-ralink/ralink_regs.h 
b/arch/mips/include/asm/mach-ralink/ralink_regs.h
index 9df1a53..b4e7dfa 100644
--- a/arch/mips/include/asm/mach-ralink/ralink_regs.h
+++ b/arch/mips/include/asm/mach-ralink/ralink_regs.h
@@ -13,6 +13,8 @@
 #ifndef _RALINK_REGS_H_
 #define _RALINK_REGS_H_
 
+#include 
+
 enum ralink_soc_type {
RALINK_UNKNOWN = 0,
RT2880_SOC,
-- 
2.7.4