Re: [PATCH 1/2] arm64: dts: imx8mm: Add SAI nodes
On Mon, Apr 22, 2019 at 9:51 AM Daniel Baluta wrote:
>
> On Mon, Apr 22, 2019 at 5:45 AM Shawn Guo wrote:
> >
> > On Fri, Apr 19, 2019 at 08:20:39PM +, Daniel Baluta wrote:
> > > i.MX8MM has 5 SAI instances with the following base
> > > addresses according to RM.
> > >
> > > SAI1 base address: 3001_h
> > > SAI2 base address: 3002_h
> > > SAI3 base address: 3003_h
> > > SAI5 base address: 3005_h
> > > SAI6 base address: 3006_h
> > >
> > > Signed-off-by: Bai Ping
> > > Signed-off-by: Daniel Baluta
> > > ---
> > > arch/arm64/boot/dts/freescale/imx8mm.dtsi | 68 +++
> > > 1 file changed, 68 insertions(+)
> > >
> > > diff --git a/arch/arm64/boot/dts/freescale/imx8mm.dtsi
> > > b/arch/arm64/boot/dts/freescale/imx8mm.dtsi
> > > index de3498c2dd44..e9a0b2b6063a 100644
> > > --- a/arch/arm64/boot/dts/freescale/imx8mm.dtsi
> > > +++ b/arch/arm64/boot/dts/freescale/imx8mm.dtsi
> > > @@ -171,6 +171,74 @@
> > > #size-cells = <1>;
> > > ranges;
> > >
> > > + sai1: sai@3001 {
> > > + compatible = "fsl,imx8mq-sai",
> >
> > Should be "fsl,imx8mm-sai"?
>
> SAI IP on imx8mm is identical with the one on imx8mq. There is no need
> to differentiate with a compatible string.
On a second thought sai on i.MX8M is not compatible with SAI on i.MX6.
So, the correct
compatbile should be:
compatible = "fsl,imx8mm-sai", "fsl,imx8mq-sai";
Will fix this in v2.
Re: [PATCH 1/2] arm64: dts: imx8mm: Add SAI nodes
On Mon, Apr 22, 2019 at 5:45 AM Shawn Guo wrote:
>
> On Fri, Apr 19, 2019 at 08:20:39PM +, Daniel Baluta wrote:
> > i.MX8MM has 5 SAI instances with the following base
> > addresses according to RM.
> >
> > SAI1 base address: 3001_h
> > SAI2 base address: 3002_h
> > SAI3 base address: 3003_h
> > SAI5 base address: 3005_h
> > SAI6 base address: 3006_h
> >
> > Signed-off-by: Bai Ping
> > Signed-off-by: Daniel Baluta
> > ---
> > arch/arm64/boot/dts/freescale/imx8mm.dtsi | 68 +++
> > 1 file changed, 68 insertions(+)
> >
> > diff --git a/arch/arm64/boot/dts/freescale/imx8mm.dtsi
> > b/arch/arm64/boot/dts/freescale/imx8mm.dtsi
> > index de3498c2dd44..e9a0b2b6063a 100644
> > --- a/arch/arm64/boot/dts/freescale/imx8mm.dtsi
> > +++ b/arch/arm64/boot/dts/freescale/imx8mm.dtsi
> > @@ -171,6 +171,74 @@
> > #size-cells = <1>;
> > ranges;
> >
> > + sai1: sai@3001 {
> > + compatible = "fsl,imx8mq-sai",
>
> Should be "fsl,imx8mm-sai"?
SAI IP on imx8mm is identical with the one on imx8mq. There is no need
to differentiate with a compatible string.
What is the common practice for such cases?
Re: [PATCH 1/2] arm64: dts: imx8mm: Add SAI nodes
On Fri, Apr 19, 2019 at 08:20:39PM +, Daniel Baluta wrote:
> i.MX8MM has 5 SAI instances with the following base
> addresses according to RM.
>
> SAI1 base address: 3001_h
> SAI2 base address: 3002_h
> SAI3 base address: 3003_h
> SAI5 base address: 3005_h
> SAI6 base address: 3006_h
>
> Signed-off-by: Bai Ping
> Signed-off-by: Daniel Baluta
> ---
> arch/arm64/boot/dts/freescale/imx8mm.dtsi | 68 +++
> 1 file changed, 68 insertions(+)
>
> diff --git a/arch/arm64/boot/dts/freescale/imx8mm.dtsi
> b/arch/arm64/boot/dts/freescale/imx8mm.dtsi
> index de3498c2dd44..e9a0b2b6063a 100644
> --- a/arch/arm64/boot/dts/freescale/imx8mm.dtsi
> +++ b/arch/arm64/boot/dts/freescale/imx8mm.dtsi
> @@ -171,6 +171,74 @@
> #size-cells = <1>;
> ranges;
>
> + sai1: sai@3001 {
> + compatible = "fsl,imx8mq-sai",
Should be "fsl,imx8mm-sai"?
Shawn
> + "fsl,imx6sx-sai";
> + reg = <0x3001 0x1>;
> + interrupts = ;
> + clocks = < IMX8MM_CLK_SAI1_IPG>,
> + < IMX8MM_CLK_SAI1_ROOT>,
> + < IMX8MM_CLK_DUMMY>, <
> IMX8MM_CLK_DUMMY>;
> + clock-names = "bus", "mclk1", "mclk2", "mclk3";
> + dmas = < 0 2 0>, < 1 2 0>;
> + dma-names = "rx", "tx";
> + status = "disabled";
> + };
> +
> + sai2: sai@3002 {
> + compatible = "fsl,imx8mq-sai",
> + "fsl,imx6sx-sai";
> + reg = <0x3002 0x1>;
> + interrupts = ;
> + clocks = < IMX8MM_CLK_SAI2_IPG>,
> + < IMX8MM_CLK_SAI2_ROOT>,
> + < IMX8MM_CLK_DUMMY>, <
> IMX8MM_CLK_DUMMY>;
> + clock-names = "bus", "mclk1", "mclk2", "mclk3";
> + dmas = < 2 2 0>, < 3 2 0>;
> + dma-names = "rx", "tx";
> + status = "disabled";
> + };
> +
> + sai3: sai@3003 {
> + #sound-dai-cells = <0>;
> + compatible = "fsl,imx8mm-sai",
> "fsl,imx8mq-sai", "fsl,imx6sx-sai";
> + reg = <0x3003 0x1>;
> + interrupts = ;
> + clocks = < IMX8MM_CLK_SAI3_IPG>,
> + < IMX8MM_CLK_SAI3_ROOT>,
> + < IMX8MM_CLK_DUMMY>, <
> IMX8MM_CLK_DUMMY>;
> + clock-names = "bus", "mclk1", "mclk2", "mclk3";
> + dmas = < 4 2 0>, < 5 2 0>;
> + dma-names = "rx", "tx";
> + status = "disabled";
> + };
> +
> + sai5: sai@3005 {
> + compatible = "fsl,imx8mq-sai", "fsl,imx6sx-sai";
> + reg = <0x3005 0x1>;
> + interrupts = ;
> + clocks = < IMX8MM_CLK_SAI5_IPG>,
> + < IMX8MM_CLK_SAI5_ROOT>,
> + < IMX8MM_CLK_DUMMY>, <
> IMX8MM_CLK_DUMMY>;
> + clock-names = "bus", "mclk1", "mclk2", "mclk3";
> + dmas = < 8 2 0>, < 9 2 0>;
> + dma-names = "rx", "tx";
> + status = "disabled";
> + };
> +
> + sai6: sai@3006 {
> + compatible = "fsl,imx8mq-sai", "fsl,imx6sx-sai";
> + reg = <0x3006 0x1>;
> + interrupts = ;
> + clocks = < IMX8MM_CLK_SAI6_IPG>,
> + < IMX8MM_CLK_SAI6_ROOT>,
> + < IMX8MM_CLK_DUMMY>, <
> IMX8MM_CLK_DUMMY>;
> + clock-names = "bus", "mclk1", "mclk2", "mclk3";
> + dmas = < 10 2 0>, < 11 2 0>;
> + dma-names = "rx", "tx";
> + status = "disabled";
> + };
> +
> gpio1: gpio@3020 {
> compatible = "fsl,imx8mm-gpio",
> "fsl,imx35-gpio";
> reg = <0x3020 0x1>;
> --
> 2.17.1
>
[PATCH 1/2] arm64: dts: imx8mm: Add SAI nodes
i.MX8MM has 5 SAI instances with the following base
addresses according to RM.
SAI1 base address: 3001_h
SAI2 base address: 3002_h
SAI3 base address: 3003_h
SAI5 base address: 3005_h
SAI6 base address: 3006_h
Signed-off-by: Bai Ping
Signed-off-by: Daniel Baluta
---
arch/arm64/boot/dts/freescale/imx8mm.dtsi | 68 +++
1 file changed, 68 insertions(+)
diff --git a/arch/arm64/boot/dts/freescale/imx8mm.dtsi
b/arch/arm64/boot/dts/freescale/imx8mm.dtsi
index de3498c2dd44..e9a0b2b6063a 100644
--- a/arch/arm64/boot/dts/freescale/imx8mm.dtsi
+++ b/arch/arm64/boot/dts/freescale/imx8mm.dtsi
@@ -171,6 +171,74 @@
#size-cells = <1>;
ranges;
+ sai1: sai@3001 {
+ compatible = "fsl,imx8mq-sai",
+"fsl,imx6sx-sai";
+ reg = <0x3001 0x1>;
+ interrupts = ;
+ clocks = < IMX8MM_CLK_SAI1_IPG>,
+< IMX8MM_CLK_SAI1_ROOT>,
+< IMX8MM_CLK_DUMMY>, <
IMX8MM_CLK_DUMMY>;
+ clock-names = "bus", "mclk1", "mclk2", "mclk3";
+ dmas = < 0 2 0>, < 1 2 0>;
+ dma-names = "rx", "tx";
+ status = "disabled";
+ };
+
+ sai2: sai@3002 {
+ compatible = "fsl,imx8mq-sai",
+"fsl,imx6sx-sai";
+ reg = <0x3002 0x1>;
+ interrupts = ;
+ clocks = < IMX8MM_CLK_SAI2_IPG>,
+ < IMX8MM_CLK_SAI2_ROOT>,
+ < IMX8MM_CLK_DUMMY>, <
IMX8MM_CLK_DUMMY>;
+ clock-names = "bus", "mclk1", "mclk2", "mclk3";
+ dmas = < 2 2 0>, < 3 2 0>;
+ dma-names = "rx", "tx";
+ status = "disabled";
+ };
+
+ sai3: sai@3003 {
+ #sound-dai-cells = <0>;
+ compatible = "fsl,imx8mm-sai",
"fsl,imx8mq-sai", "fsl,imx6sx-sai";
+ reg = <0x3003 0x1>;
+ interrupts = ;
+ clocks = < IMX8MM_CLK_SAI3_IPG>,
+< IMX8MM_CLK_SAI3_ROOT>,
+< IMX8MM_CLK_DUMMY>, <
IMX8MM_CLK_DUMMY>;
+ clock-names = "bus", "mclk1", "mclk2", "mclk3";
+ dmas = < 4 2 0>, < 5 2 0>;
+ dma-names = "rx", "tx";
+ status = "disabled";
+ };
+
+ sai5: sai@3005 {
+ compatible = "fsl,imx8mq-sai", "fsl,imx6sx-sai";
+ reg = <0x3005 0x1>;
+ interrupts = ;
+ clocks = < IMX8MM_CLK_SAI5_IPG>,
+< IMX8MM_CLK_SAI5_ROOT>,
+< IMX8MM_CLK_DUMMY>, <
IMX8MM_CLK_DUMMY>;
+ clock-names = "bus", "mclk1", "mclk2", "mclk3";
+ dmas = < 8 2 0>, < 9 2 0>;
+ dma-names = "rx", "tx";
+ status = "disabled";
+ };
+
+ sai6: sai@3006 {
+ compatible = "fsl,imx8mq-sai", "fsl,imx6sx-sai";
+ reg = <0x3006 0x1>;
+ interrupts = ;
+ clocks = < IMX8MM_CLK_SAI6_IPG>,
+< IMX8MM_CLK_SAI6_ROOT>,
+< IMX8MM_CLK_DUMMY>, <
IMX8MM_CLK_DUMMY>;
+ clock-names = "bus", "mclk1", "mclk2", "mclk3";
+ dmas = < 10 2 0>, < 11 2 0>;
+ dma-names = "rx", "tx";
+ status = "disabled";
+ };
+
gpio1: gpio@3020 {
compatible = "fsl,imx8mm-gpio",
"fsl,imx35-gpio";
reg = <0x3020 0x1>;
--
2.17.1
