Re: [PATCH 1/2] clk: imx8mm: Unregister clks when of_clk_add_provider failed

2019-08-12 Thread Shawn Guo
On Tue, Aug 06, 2019 at 02:46:13PM +0800, anson.hu...@nxp.com wrote:
> From: Anson Huang 
> 
> When of_clk_add_provider failed, all clks should be unregistered.
> 
> Signed-off-by: Anson Huang 

Applied both, thanks.


Re: [PATCH 1/2] clk: imx8mm: Unregister clks when of_clk_add_provider failed

2019-08-06 Thread Daniel Baluta
On Tue, 2019-08-06 at 14:46 +0800, anson.hu...@nxp.com wrote:
> From: Anson Huang 
> 
> When of_clk_add_provider failed, all clks should be unregistered.
> 
> Signed-off-by: Anson Huang 


Reviewed-by: Daniel Baluta 

Thanks Anson for the patch!


[PATCH 1/2] clk: imx8mm: Unregister clks when of_clk_add_provider failed

2019-08-06 Thread Anson . Huang
From: Anson Huang 

When of_clk_add_provider failed, all clks should be unregistered.

Signed-off-by: Anson Huang 
---
 drivers/clk/imx/clk-imx8mm.c | 7 ++-
 1 file changed, 6 insertions(+), 1 deletion(-)

diff --git a/drivers/clk/imx/clk-imx8mm.c b/drivers/clk/imx/clk-imx8mm.c
index e494e99..49ad761 100644
--- a/drivers/clk/imx/clk-imx8mm.c
+++ b/drivers/clk/imx/clk-imx8mm.c
@@ -661,12 +661,17 @@ static int imx8mm_clocks_probe(struct platform_device 
*pdev)
ret = of_clk_add_provider(np, of_clk_src_onecell_get, _data);
if (ret < 0) {
pr_err("failed to register clks for i.MX8MM\n");
-   return -EINVAL;
+   goto unregister_clks;
}
 
imx_register_uart_clocks(uart_clks);
 
return 0;
+
+unregister_clks:
+   imx_unregister_clocks(clks, ARRAY_SIZE(clks));
+
+   return ret;
 }
 
 static const struct of_device_id imx8mm_clk_of_match[] = {
-- 
2.7.4