Re: [PATCH 1/2] coresight: replicator: Add Qualcomm CoreSight Replicator driver
On Thu, 2015-05-07 at 17:46 +0300, Ivan T. Ivanov wrote: > Thank you. I am going to fallow approach taken by Mathieu in [1]. > Is this OK with you? I'm OK with anything that is coherent (ie, anything better than built-in only code cross-dressing as modular code). I think Mathieu's approach clears that bar. (Please note that macros like module_amba_driver() are basically just a pet peeve.) And, at the end of the day, what matters is what the maintainer of this code accepts. I'm not the maintainer here. Thanks, Paul Bolle -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH 1/2] coresight: replicator: Add Qualcomm CoreSight Replicator driver
On Thu, 2015-04-30 at 22:53 +0200, Paul Bolle wrote: > On Wed, 2015-04-29 at 15:19 +0300, Ivan T. Ivanov wrote: > > > +config CORESIGHT_QCOM_REPLICATOR > > + bool "Qualcomm CoreSight Replicator driver" > > + help > > + This enables support for CoreSight link and sink > > driver that are > > + responsible for transporting and collecting the > > trace data > > + respectively. Link and sinks are dynamically > > aggregated with a trace > > + entity at run time to form a complete trace path. > > > --- a/drivers/hwtracing/coresight/Makefile > > +++ b/drivers/hwtracing/coresight/Makefile > > > +obj-$(CONFIG_CORESIGHT_QCOM_REPLICATOR) += coresight-replicator-qcom.o > > CORESIGHT_QCOM_REPLICATOR is a bool symbol. So > coresight-replicator-qcom.o will never be part of a module. > Thank you. I am going to fallow approach taken by Mathieu in [1]. Is this OK with you? Regards, Ivan [1] https://lkml.org/lkml/2015/5/6/524 -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH 1/2] coresight: replicator: Add Qualcomm CoreSight Replicator driver
On Thu, 2015-04-30 at 22:53 +0200, Paul Bolle wrote: On Wed, 2015-04-29 at 15:19 +0300, Ivan T. Ivanov wrote: +config CORESIGHT_QCOM_REPLICATOR + bool Qualcomm CoreSight Replicator driver + help + This enables support for CoreSight link and sink driver that are + responsible for transporting and collecting the trace data + respectively. Link and sinks are dynamically aggregated with a trace + entity at run time to form a complete trace path. --- a/drivers/hwtracing/coresight/Makefile +++ b/drivers/hwtracing/coresight/Makefile +obj-$(CONFIG_CORESIGHT_QCOM_REPLICATOR) += coresight-replicator-qcom.o CORESIGHT_QCOM_REPLICATOR is a bool symbol. So coresight-replicator-qcom.o will never be part of a module. Thank you. I am going to fallow approach taken by Mathieu in [1]. Is this OK with you? Regards, Ivan [1] https://lkml.org/lkml/2015/5/6/524 -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH 1/2] coresight: replicator: Add Qualcomm CoreSight Replicator driver
On Thu, 2015-05-07 at 17:46 +0300, Ivan T. Ivanov wrote: Thank you. I am going to fallow approach taken by Mathieu in [1]. Is this OK with you? I'm OK with anything that is coherent (ie, anything better than built-in only code cross-dressing as modular code). I think Mathieu's approach clears that bar. (Please note that macros like module_amba_driver() are basically just a pet peeve.) And, at the end of the day, what matters is what the maintainer of this code accepts. I'm not the maintainer here. Thanks, Paul Bolle -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH 1/2] coresight: replicator: Add Qualcomm CoreSight Replicator driver
On Wed, 2015-04-29 at 15:19 +0300, Ivan T. Ivanov wrote:
> +config CORESIGHT_QCOM_REPLICATOR
> + bool "Qualcomm CoreSight Replicator driver"
> + help
> + This enables support for CoreSight link and sink driver that are
> + responsible for transporting and collecting the trace data
> + respectively. Link and sinks are dynamically aggregated with a trace
> + entity at run time to form a complete trace path.
> --- a/drivers/hwtracing/coresight/Makefile
> +++ b/drivers/hwtracing/coresight/Makefile
> +obj-$(CONFIG_CORESIGHT_QCOM_REPLICATOR) += coresight-replicator-qcom.o
CORESIGHT_QCOM_REPLICATOR is a bool symbol. So
coresight-replicator-qcom.o will never be part of a module.
(If that's incorrect, you can stop reading here.)
> --- /dev/null
> +++ b/drivers/hwtracing/coresight/coresight-replicator-qcom.c
> +#include
Is this include needed?
> +static struct amba_driver replicator_driver = {
> + .drv = {
> + .name = "coresight-replicator-qcom",
> + .owner = THIS_MODULE,
For built-in only code THIS_MODULE will be, basically, equivalent to
NULL (see include/linux/export.h). So I suppose this line can be
dropped.
> + .pm = _dev_pm_ops,
> + },
> + .probe = replicator_probe,
> + .remove = replicator_remove,
> + .id_table = replicator_ids,
> +};
> +
> +module_amba_driver(replicator_driver);
For built-in only code this is, assuming I grepped this correctly,
equivalent to calling
amba_driver_register(_driver);
from within a function marked with some sort of *initcall().
> +MODULE_LICENSE("GPL v2");
> +MODULE_DESCRIPTION("Qualcomm CoreSight Replicator driver");
For built-in only code these macros will be effectively preprocessed
away.
Thanks,
Paul Bolle
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH 1/2] coresight: replicator: Add Qualcomm CoreSight Replicator driver
On 30 April 2015 at 01:21, Ivan T. Ivanov wrote: > > On Wed, 2015-04-29 at 10:28 -0600, Mathieu Poirier wrote: >> On 29 April 2015 at 06:19, Ivan T. Ivanov iva...@linaro.org> wrote: > > > >> > - "arm,coresight-etm4x", "arm,primecell"; >> > + - "qcom,coresight-replicator", "arm,primecell"; >> >> Is there some sort of versioning information we can add like it was >> done for the "coresight-etmXY" bindings? It makes things a lot >> cleaner when a new (and possibly not backward compatible) version gets >> released. >> > > From what I can see, it is version 1. I could add it to compatible > string, but suldn't we use amba_id for this reason. amba_id work well for devices within the same family and compatible up to a certain point. When revisions change backward compatibility is usually not kept and it becomes a nightmare to maintain. > >> > * reg: physical base address and length of the register >> > set(s) of the component. >> > diff --git a/drivers/hwtracing/coresight/Kconfig >> > b/drivers/hwtracing/coresight/Kconfig >> > index 6b331d4..165b681 100644 >> > --- a/drivers/hwtracing/coresight/Kconfig >> > +++ b/drivers/hwtracing/coresight/Kconfig >> > @@ -68,4 +68,13 @@ config CORESIGHT_SOURCE_ETM4X >> > instructions that a processor is executing. This is primarily >> > useful >> > for instruction level tracing. Depending on the implemented >> > version >> > data tracing may also be available. >> > + >> > +config CORESIGHT_QCOM_REPLICATOR >> > + bool "Qualcomm CoreSight Replicator driver" >> > + help >> > + This enables support for CoreSight link and sink driver that are >> > + responsible for transporting and collecting the trace data >> > + respectively. Link and sinks are dynamically aggregated with a >> > trace >> > + entity at run time to form a complete trace path. >> >> The replicator is only a link entity. It is only transporting trace >> data information rather than collecting it. Please review the >> comment. > > True, sorry. copy and paste from CORESIGHT_LINKS_AND_SINKS. > >> Also, can this specific version run on both V7 and V8 >> architecture. If not the proper "depends" should be added. >> > > Same driver/device on both architectures. > > Will fix rest of the comments and will resend. > > Thank you, > Ivan -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH 1/2] coresight: replicator: Add Qualcomm CoreSight Replicator driver
On Wed, 2015-04-29 at 10:28 -0600, Mathieu Poirier wrote: > On 29 April 2015 at 06:19, Ivan T. Ivanov iva...@linaro.org> wrote: > > - "arm,coresight-etm4x", "arm,primecell"; > > + - "qcom,coresight-replicator", "arm,primecell"; > > Is there some sort of versioning information we can add like it was > done for the "coresight-etmXY" bindings? It makes things a lot > cleaner when a new (and possibly not backward compatible) version gets > released. > >From what I can see, it is version 1. I could add it to compatible string, but suldn't we use amba_id for this reason. > > * reg: physical base address and length of the register > > set(s) of the component. > > diff --git a/drivers/hwtracing/coresight/Kconfig > > b/drivers/hwtracing/coresight/Kconfig > > index 6b331d4..165b681 100644 > > --- a/drivers/hwtracing/coresight/Kconfig > > +++ b/drivers/hwtracing/coresight/Kconfig > > @@ -68,4 +68,13 @@ config CORESIGHT_SOURCE_ETM4X > > instructions that a processor is executing. This is primarily > > useful > > for instruction level tracing. Depending on the implemented > > version > > data tracing may also be available. > > + > > +config CORESIGHT_QCOM_REPLICATOR > > + bool "Qualcomm CoreSight Replicator driver" > > + help > > + This enables support for CoreSight link and sink driver that are > > + responsible for transporting and collecting the trace data > > + respectively. Link and sinks are dynamically aggregated with a > > trace > > + entity at run time to form a complete trace path. > > The replicator is only a link entity. It is only transporting trace > data information rather than collecting it. Please review the > comment. True, sorry. copy and paste from CORESIGHT_LINKS_AND_SINKS. > Also, can this specific version run on both V7 and V8 > architecture. If not the proper "depends" should be added. > Same driver/device on both architectures. Will fix rest of the comments and will resend. Thank you, Ivan -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH 1/2] coresight: replicator: Add Qualcomm CoreSight Replicator driver
On Wed, 2015-04-29 at 10:28 -0600, Mathieu Poirier wrote: On 29 April 2015 at 06:19, Ivan T. Ivanov iva...@linaro.org wrote: snip - arm,coresight-etm4x, arm,primecell; + - qcom,coresight-replicator, arm,primecell; Is there some sort of versioning information we can add like it was done for the coresight-etmXY bindings? It makes things a lot cleaner when a new (and possibly not backward compatible) version gets released. From what I can see, it is version 1. I could add it to compatible string, but suldn't we use amba_id for this reason. * reg: physical base address and length of the register set(s) of the component. diff --git a/drivers/hwtracing/coresight/Kconfig b/drivers/hwtracing/coresight/Kconfig index 6b331d4..165b681 100644 --- a/drivers/hwtracing/coresight/Kconfig +++ b/drivers/hwtracing/coresight/Kconfig @@ -68,4 +68,13 @@ config CORESIGHT_SOURCE_ETM4X instructions that a processor is executing. This is primarily useful for instruction level tracing. Depending on the implemented version data tracing may also be available. + +config CORESIGHT_QCOM_REPLICATOR + bool Qualcomm CoreSight Replicator driver + help + This enables support for CoreSight link and sink driver that are + responsible for transporting and collecting the trace data + respectively. Link and sinks are dynamically aggregated with a trace + entity at run time to form a complete trace path. The replicator is only a link entity. It is only transporting trace data information rather than collecting it. Please review the comment. True, sorry. copy and paste from CORESIGHT_LINKS_AND_SINKS. Also, can this specific version run on both V7 and V8 architecture. If not the proper depends should be added. Same driver/device on both architectures. Will fix rest of the comments and will resend. Thank you, Ivan -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH 1/2] coresight: replicator: Add Qualcomm CoreSight Replicator driver
On 30 April 2015 at 01:21, Ivan T. Ivanov ivan.iva...@linaro.org wrote: On Wed, 2015-04-29 at 10:28 -0600, Mathieu Poirier wrote: On 29 April 2015 at 06:19, Ivan T. Ivanov iva...@linaro.org wrote: snip - arm,coresight-etm4x, arm,primecell; + - qcom,coresight-replicator, arm,primecell; Is there some sort of versioning information we can add like it was done for the coresight-etmXY bindings? It makes things a lot cleaner when a new (and possibly not backward compatible) version gets released. From what I can see, it is version 1. I could add it to compatible string, but suldn't we use amba_id for this reason. amba_id work well for devices within the same family and compatible up to a certain point. When revisions change backward compatibility is usually not kept and it becomes a nightmare to maintain. * reg: physical base address and length of the register set(s) of the component. diff --git a/drivers/hwtracing/coresight/Kconfig b/drivers/hwtracing/coresight/Kconfig index 6b331d4..165b681 100644 --- a/drivers/hwtracing/coresight/Kconfig +++ b/drivers/hwtracing/coresight/Kconfig @@ -68,4 +68,13 @@ config CORESIGHT_SOURCE_ETM4X instructions that a processor is executing. This is primarily useful for instruction level tracing. Depending on the implemented version data tracing may also be available. + +config CORESIGHT_QCOM_REPLICATOR + bool Qualcomm CoreSight Replicator driver + help + This enables support for CoreSight link and sink driver that are + responsible for transporting and collecting the trace data + respectively. Link and sinks are dynamically aggregated with a trace + entity at run time to form a complete trace path. The replicator is only a link entity. It is only transporting trace data information rather than collecting it. Please review the comment. True, sorry. copy and paste from CORESIGHT_LINKS_AND_SINKS. Also, can this specific version run on both V7 and V8 architecture. If not the proper depends should be added. Same driver/device on both architectures. Will fix rest of the comments and will resend. Thank you, Ivan -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH 1/2] coresight: replicator: Add Qualcomm CoreSight Replicator driver
On Wed, 2015-04-29 at 15:19 +0300, Ivan T. Ivanov wrote:
+config CORESIGHT_QCOM_REPLICATOR
+ bool Qualcomm CoreSight Replicator driver
+ help
+ This enables support for CoreSight link and sink driver that are
+ responsible for transporting and collecting the trace data
+ respectively. Link and sinks are dynamically aggregated with a trace
+ entity at run time to form a complete trace path.
--- a/drivers/hwtracing/coresight/Makefile
+++ b/drivers/hwtracing/coresight/Makefile
+obj-$(CONFIG_CORESIGHT_QCOM_REPLICATOR) += coresight-replicator-qcom.o
CORESIGHT_QCOM_REPLICATOR is a bool symbol. So
coresight-replicator-qcom.o will never be part of a module.
(If that's incorrect, you can stop reading here.)
--- /dev/null
+++ b/drivers/hwtracing/coresight/coresight-replicator-qcom.c
+#include linux/module.h
Is this include needed?
+static struct amba_driver replicator_driver = {
+ .drv = {
+ .name = coresight-replicator-qcom,
+ .owner = THIS_MODULE,
For built-in only code THIS_MODULE will be, basically, equivalent to
NULL (see include/linux/export.h). So I suppose this line can be
dropped.
+ .pm = replicator_dev_pm_ops,
+ },
+ .probe = replicator_probe,
+ .remove = replicator_remove,
+ .id_table = replicator_ids,
+};
+
+module_amba_driver(replicator_driver);
For built-in only code this is, assuming I grepped this correctly,
equivalent to calling
amba_driver_register(replicator_driver);
from within a function marked with some sort of *initcall().
+MODULE_LICENSE(GPL v2);
+MODULE_DESCRIPTION(Qualcomm CoreSight Replicator driver);
For built-in only code these macros will be effectively preprocessed
away.
Thanks,
Paul Bolle
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH 1/2] coresight: replicator: Add Qualcomm CoreSight Replicator driver
On 29 April 2015 at 06:19, Ivan T. Ivanov wrote: > From: Pratik Patel Thanks for crediting the original author. > > This driver manages Qualcomm CoreSight Replicator device, which > resides on the AMBA bus. Replicator has been made programmable to > allow software to turn of the replicator branch to sink that is not > being used. This avoids trace traffic to the unused/non-current sink > from causing back pressure that results in overflows at the source. > > Signed-off-by: Pratik Patel > Signed-off-by: Ivan T. Ivanov > --- > .../devicetree/bindings/arm/coresight.txt | 1 + > drivers/hwtracing/coresight/Kconfig| 9 + > drivers/hwtracing/coresight/Makefile | 1 + > .../coresight/coresight-replicator-qcom.c | 211 > + > 4 files changed, 222 insertions(+) > create mode 100644 drivers/hwtracing/coresight/coresight-replicator-qcom.c > > diff --git a/Documentation/devicetree/bindings/arm/coresight.txt > b/Documentation/devicetree/bindings/arm/coresight.txt > index f4d6a86..2314f2b 100644 > --- a/Documentation/devicetree/bindings/arm/coresight.txt > +++ b/Documentation/devicetree/bindings/arm/coresight.txt > @@ -18,6 +18,7 @@ its hardware characteristcs. > - "arm,coresight-funnel", "arm,primecell"; > - "arm,coresight-etm3x", "arm,primecell"; > - "arm,coresight-etm4x", "arm,primecell"; > + - "qcom,coresight-replicator", "arm,primecell"; Is there some sort of versioning information we can add like it was done for the "coresight-etmXY" bindings? It makes things a lot cleaner when a new (and possibly not backward compatible) version gets released. > > * reg: physical base address and length of the register > set(s) of the component. > diff --git a/drivers/hwtracing/coresight/Kconfig > b/drivers/hwtracing/coresight/Kconfig > index 6b331d4..165b681 100644 > --- a/drivers/hwtracing/coresight/Kconfig > +++ b/drivers/hwtracing/coresight/Kconfig > @@ -68,4 +68,13 @@ config CORESIGHT_SOURCE_ETM4X > instructions that a processor is executing. This is primarily useful > for instruction level tracing. Depending on the implemented version > data tracing may also be available. > + > +config CORESIGHT_QCOM_REPLICATOR > + bool "Qualcomm CoreSight Replicator driver" > + help > + This enables support for CoreSight link and sink driver that are > + responsible for transporting and collecting the trace data > + respectively. Link and sinks are dynamically aggregated with a trace > + entity at run time to form a complete trace path. The replicator is only a link entity. It is only transporting trace data information rather than collecting it. Please review the comment. Also, can this specific version run on both V7 and V8 architecture. If not the proper "depends" should be added. > + > endif > diff --git a/drivers/hwtracing/coresight/Makefile > b/drivers/hwtracing/coresight/Makefile > index 0af28d4..99f8e5f 100644 > --- a/drivers/hwtracing/coresight/Makefile > +++ b/drivers/hwtracing/coresight/Makefile > @@ -10,3 +10,4 @@ obj-$(CONFIG_CORESIGHT_LINKS_AND_SINKS) += > coresight-funnel.o \ >coresight-replicator.o > obj-$(CONFIG_CORESIGHT_SOURCE_ETM3X) += coresight-etm3x.o > coresight-etm-cp14.o > obj-$(CONFIG_CORESIGHT_SOURCE_ETM4X) += coresight-etm4x.o > +obj-$(CONFIG_CORESIGHT_QCOM_REPLICATOR) += coresight-replicator-qcom.o > diff --git a/drivers/hwtracing/coresight/coresight-replicator-qcom.c > b/drivers/hwtracing/coresight/coresight-replicator-qcom.c > new file mode 100644 > index 000..961f389 > --- /dev/null > +++ b/drivers/hwtracing/coresight/coresight-replicator-qcom.c > @@ -0,0 +1,211 @@ > +/* > + * Copyright (c) 2011-2015, The Linux Foundation. All rights reserved. > + * > + * This program is free software; you can redistribute it and/or modify > + * it under the terms of the GNU General Public License version 2 and > + * only version 2 as published by the Free Software Foundation. > + * > + * This program is distributed in the hope that it will be useful, > + * but WITHOUT ANY WARRANTY; without even the implied warranty of > + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the > + * GNU General Public License for more details. > + */ > + > +#include > +#include > +#include > +#include > +#include > +#include > +#include > +#include > +#include > +#include > +#include > +#include > + > +#include "coresight-priv.h" > + > +#define REPLICATOR_IDFILTER0 0x000 > +#define REPLICATOR_IDFILTER1 0x004 > + > +/** > + * struct replicator_state - specifics associated to a replicator component > + * @base: memory mapped base address for this component. > + * @dev: the device entity associated with this component > + * @atclk: optional clock for the core parts of the replicator. > + *
[PATCH 1/2] coresight: replicator: Add Qualcomm CoreSight Replicator driver
From: Pratik Patel
This driver manages Qualcomm CoreSight Replicator device, which
resides on the AMBA bus. Replicator has been made programmable to
allow software to turn of the replicator branch to sink that is not
being used. This avoids trace traffic to the unused/non-current sink
from causing back pressure that results in overflows at the source.
Signed-off-by: Pratik Patel
Signed-off-by: Ivan T. Ivanov
---
.../devicetree/bindings/arm/coresight.txt | 1 +
drivers/hwtracing/coresight/Kconfig| 9 +
drivers/hwtracing/coresight/Makefile | 1 +
.../coresight/coresight-replicator-qcom.c | 211 +
4 files changed, 222 insertions(+)
create mode 100644 drivers/hwtracing/coresight/coresight-replicator-qcom.c
diff --git a/Documentation/devicetree/bindings/arm/coresight.txt
b/Documentation/devicetree/bindings/arm/coresight.txt
index f4d6a86..2314f2b 100644
--- a/Documentation/devicetree/bindings/arm/coresight.txt
+++ b/Documentation/devicetree/bindings/arm/coresight.txt
@@ -18,6 +18,7 @@ its hardware characteristcs.
- "arm,coresight-funnel", "arm,primecell";
- "arm,coresight-etm3x", "arm,primecell";
- "arm,coresight-etm4x", "arm,primecell";
+ - "qcom,coresight-replicator", "arm,primecell";
* reg: physical base address and length of the register
set(s) of the component.
diff --git a/drivers/hwtracing/coresight/Kconfig
b/drivers/hwtracing/coresight/Kconfig
index 6b331d4..165b681 100644
--- a/drivers/hwtracing/coresight/Kconfig
+++ b/drivers/hwtracing/coresight/Kconfig
@@ -68,4 +68,13 @@ config CORESIGHT_SOURCE_ETM4X
instructions that a processor is executing. This is primarily useful
for instruction level tracing. Depending on the implemented version
data tracing may also be available.
+
+config CORESIGHT_QCOM_REPLICATOR
+ bool "Qualcomm CoreSight Replicator driver"
+ help
+ This enables support for CoreSight link and sink driver that are
+ responsible for transporting and collecting the trace data
+ respectively. Link and sinks are dynamically aggregated with a trace
+ entity at run time to form a complete trace path.
+
endif
diff --git a/drivers/hwtracing/coresight/Makefile
b/drivers/hwtracing/coresight/Makefile
index 0af28d4..99f8e5f 100644
--- a/drivers/hwtracing/coresight/Makefile
+++ b/drivers/hwtracing/coresight/Makefile
@@ -10,3 +10,4 @@ obj-$(CONFIG_CORESIGHT_LINKS_AND_SINKS) += coresight-funnel.o
\
coresight-replicator.o
obj-$(CONFIG_CORESIGHT_SOURCE_ETM3X) += coresight-etm3x.o coresight-etm-cp14.o
obj-$(CONFIG_CORESIGHT_SOURCE_ETM4X) += coresight-etm4x.o
+obj-$(CONFIG_CORESIGHT_QCOM_REPLICATOR) += coresight-replicator-qcom.o
diff --git a/drivers/hwtracing/coresight/coresight-replicator-qcom.c
b/drivers/hwtracing/coresight/coresight-replicator-qcom.c
new file mode 100644
index 000..961f389
--- /dev/null
+++ b/drivers/hwtracing/coresight/coresight-replicator-qcom.c
@@ -0,0 +1,211 @@
+/*
+ * Copyright (c) 2011-2015, The Linux Foundation. All rights reserved.
+ *
+ * This program is free software; you can redistribute it and/or modify
+ * it under the terms of the GNU General Public License version 2 and
+ * only version 2 as published by the Free Software Foundation.
+ *
+ * This program is distributed in the hope that it will be useful,
+ * but WITHOUT ANY WARRANTY; without even the implied warranty of
+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
+ * GNU General Public License for more details.
+ */
+
+#include
+#include
+#include
+#include
+#include
+#include
+#include
+#include
+#include
+#include
+#include
+#include
+
+#include "coresight-priv.h"
+
+#define REPLICATOR_IDFILTER0 0x000
+#define REPLICATOR_IDFILTER1 0x004
+
+/**
+ * struct replicator_state - specifics associated to a replicator component
+ * @base: memory mapped base address for this component.
+ * @dev: the device entity associated with this component
+ * @atclk: optional clock for the core parts of the replicator.
+ * @csdev: component vitals needed by the framework
+ */
+struct replicator_state {
+ void __iomem*base;
+ struct device *dev;
+ struct clk *atclk;
+ struct coresight_device *csdev;
+};
+
+static int replicator_enable(struct coresight_device *csdev, int inport,
+int outport)
+{
+ struct replicator_state *drvdata = dev_get_drvdata(csdev->dev.parent);
+
+ pm_runtime_get_sync(drvdata->dev);
+
+ CS_UNLOCK(drvdata->base);
+
+ if (outport == 0) {
+ writel_relaxed(0x00, drvdata->base + REPLICATOR_IDFILTER0);
+ writel_relaxed(0xff, drvdata->base + REPLICATOR_IDFILTER1);
+ } else {
+ writel_relaxed(0x00, drvdata->base +
[PATCH 1/2] coresight: replicator: Add Qualcomm CoreSight Replicator driver
From: Pratik Patel prat...@codeaurora.org
This driver manages Qualcomm CoreSight Replicator device, which
resides on the AMBA bus. Replicator has been made programmable to
allow software to turn of the replicator branch to sink that is not
being used. This avoids trace traffic to the unused/non-current sink
from causing back pressure that results in overflows at the source.
Signed-off-by: Pratik Patel prat...@codeaurora.org
Signed-off-by: Ivan T. Ivanov ivan.iva...@linaro.org
---
.../devicetree/bindings/arm/coresight.txt | 1 +
drivers/hwtracing/coresight/Kconfig| 9 +
drivers/hwtracing/coresight/Makefile | 1 +
.../coresight/coresight-replicator-qcom.c | 211 +
4 files changed, 222 insertions(+)
create mode 100644 drivers/hwtracing/coresight/coresight-replicator-qcom.c
diff --git a/Documentation/devicetree/bindings/arm/coresight.txt
b/Documentation/devicetree/bindings/arm/coresight.txt
index f4d6a86..2314f2b 100644
--- a/Documentation/devicetree/bindings/arm/coresight.txt
+++ b/Documentation/devicetree/bindings/arm/coresight.txt
@@ -18,6 +18,7 @@ its hardware characteristcs.
- arm,coresight-funnel, arm,primecell;
- arm,coresight-etm3x, arm,primecell;
- arm,coresight-etm4x, arm,primecell;
+ - qcom,coresight-replicator, arm,primecell;
* reg: physical base address and length of the register
set(s) of the component.
diff --git a/drivers/hwtracing/coresight/Kconfig
b/drivers/hwtracing/coresight/Kconfig
index 6b331d4..165b681 100644
--- a/drivers/hwtracing/coresight/Kconfig
+++ b/drivers/hwtracing/coresight/Kconfig
@@ -68,4 +68,13 @@ config CORESIGHT_SOURCE_ETM4X
instructions that a processor is executing. This is primarily useful
for instruction level tracing. Depending on the implemented version
data tracing may also be available.
+
+config CORESIGHT_QCOM_REPLICATOR
+ bool Qualcomm CoreSight Replicator driver
+ help
+ This enables support for CoreSight link and sink driver that are
+ responsible for transporting and collecting the trace data
+ respectively. Link and sinks are dynamically aggregated with a trace
+ entity at run time to form a complete trace path.
+
endif
diff --git a/drivers/hwtracing/coresight/Makefile
b/drivers/hwtracing/coresight/Makefile
index 0af28d4..99f8e5f 100644
--- a/drivers/hwtracing/coresight/Makefile
+++ b/drivers/hwtracing/coresight/Makefile
@@ -10,3 +10,4 @@ obj-$(CONFIG_CORESIGHT_LINKS_AND_SINKS) += coresight-funnel.o
\
coresight-replicator.o
obj-$(CONFIG_CORESIGHT_SOURCE_ETM3X) += coresight-etm3x.o coresight-etm-cp14.o
obj-$(CONFIG_CORESIGHT_SOURCE_ETM4X) += coresight-etm4x.o
+obj-$(CONFIG_CORESIGHT_QCOM_REPLICATOR) += coresight-replicator-qcom.o
diff --git a/drivers/hwtracing/coresight/coresight-replicator-qcom.c
b/drivers/hwtracing/coresight/coresight-replicator-qcom.c
new file mode 100644
index 000..961f389
--- /dev/null
+++ b/drivers/hwtracing/coresight/coresight-replicator-qcom.c
@@ -0,0 +1,211 @@
+/*
+ * Copyright (c) 2011-2015, The Linux Foundation. All rights reserved.
+ *
+ * This program is free software; you can redistribute it and/or modify
+ * it under the terms of the GNU General Public License version 2 and
+ * only version 2 as published by the Free Software Foundation.
+ *
+ * This program is distributed in the hope that it will be useful,
+ * but WITHOUT ANY WARRANTY; without even the implied warranty of
+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
+ * GNU General Public License for more details.
+ */
+
+#include linux/amba/bus.h
+#include linux/clk.h
+#include linux/coresight.h
+#include linux/device.h
+#include linux/err.h
+#include linux/init.h
+#include linux/io.h
+#include linux/kernel.h
+#include linux/module.h
+#include linux/of.h
+#include linux/pm_runtime.h
+#include linux/slab.h
+
+#include coresight-priv.h
+
+#define REPLICATOR_IDFILTER0 0x000
+#define REPLICATOR_IDFILTER1 0x004
+
+/**
+ * struct replicator_state - specifics associated to a replicator component
+ * @base: memory mapped base address for this component.
+ * @dev: the device entity associated with this component
+ * @atclk: optional clock for the core parts of the replicator.
+ * @csdev: component vitals needed by the framework
+ */
+struct replicator_state {
+ void __iomem*base;
+ struct device *dev;
+ struct clk *atclk;
+ struct coresight_device *csdev;
+};
+
+static int replicator_enable(struct coresight_device *csdev, int inport,
+int outport)
+{
+ struct replicator_state *drvdata = dev_get_drvdata(csdev-dev.parent);
+
+ pm_runtime_get_sync(drvdata-dev);
+
+ CS_UNLOCK(drvdata-base);
+
+ if (outport == 0) {
+
Re: [PATCH 1/2] coresight: replicator: Add Qualcomm CoreSight Replicator driver
On 29 April 2015 at 06:19, Ivan T. Ivanov ivan.iva...@linaro.org wrote: From: Pratik Patel prat...@codeaurora.org Thanks for crediting the original author. This driver manages Qualcomm CoreSight Replicator device, which resides on the AMBA bus. Replicator has been made programmable to allow software to turn of the replicator branch to sink that is not being used. This avoids trace traffic to the unused/non-current sink from causing back pressure that results in overflows at the source. Signed-off-by: Pratik Patel prat...@codeaurora.org Signed-off-by: Ivan T. Ivanov ivan.iva...@linaro.org --- .../devicetree/bindings/arm/coresight.txt | 1 + drivers/hwtracing/coresight/Kconfig| 9 + drivers/hwtracing/coresight/Makefile | 1 + .../coresight/coresight-replicator-qcom.c | 211 + 4 files changed, 222 insertions(+) create mode 100644 drivers/hwtracing/coresight/coresight-replicator-qcom.c diff --git a/Documentation/devicetree/bindings/arm/coresight.txt b/Documentation/devicetree/bindings/arm/coresight.txt index f4d6a86..2314f2b 100644 --- a/Documentation/devicetree/bindings/arm/coresight.txt +++ b/Documentation/devicetree/bindings/arm/coresight.txt @@ -18,6 +18,7 @@ its hardware characteristcs. - arm,coresight-funnel, arm,primecell; - arm,coresight-etm3x, arm,primecell; - arm,coresight-etm4x, arm,primecell; + - qcom,coresight-replicator, arm,primecell; Is there some sort of versioning information we can add like it was done for the coresight-etmXY bindings? It makes things a lot cleaner when a new (and possibly not backward compatible) version gets released. * reg: physical base address and length of the register set(s) of the component. diff --git a/drivers/hwtracing/coresight/Kconfig b/drivers/hwtracing/coresight/Kconfig index 6b331d4..165b681 100644 --- a/drivers/hwtracing/coresight/Kconfig +++ b/drivers/hwtracing/coresight/Kconfig @@ -68,4 +68,13 @@ config CORESIGHT_SOURCE_ETM4X instructions that a processor is executing. This is primarily useful for instruction level tracing. Depending on the implemented version data tracing may also be available. + +config CORESIGHT_QCOM_REPLICATOR + bool Qualcomm CoreSight Replicator driver + help + This enables support for CoreSight link and sink driver that are + responsible for transporting and collecting the trace data + respectively. Link and sinks are dynamically aggregated with a trace + entity at run time to form a complete trace path. The replicator is only a link entity. It is only transporting trace data information rather than collecting it. Please review the comment. Also, can this specific version run on both V7 and V8 architecture. If not the proper depends should be added. + endif diff --git a/drivers/hwtracing/coresight/Makefile b/drivers/hwtracing/coresight/Makefile index 0af28d4..99f8e5f 100644 --- a/drivers/hwtracing/coresight/Makefile +++ b/drivers/hwtracing/coresight/Makefile @@ -10,3 +10,4 @@ obj-$(CONFIG_CORESIGHT_LINKS_AND_SINKS) += coresight-funnel.o \ coresight-replicator.o obj-$(CONFIG_CORESIGHT_SOURCE_ETM3X) += coresight-etm3x.o coresight-etm-cp14.o obj-$(CONFIG_CORESIGHT_SOURCE_ETM4X) += coresight-etm4x.o +obj-$(CONFIG_CORESIGHT_QCOM_REPLICATOR) += coresight-replicator-qcom.o diff --git a/drivers/hwtracing/coresight/coresight-replicator-qcom.c b/drivers/hwtracing/coresight/coresight-replicator-qcom.c new file mode 100644 index 000..961f389 --- /dev/null +++ b/drivers/hwtracing/coresight/coresight-replicator-qcom.c @@ -0,0 +1,211 @@ +/* + * Copyright (c) 2011-2015, The Linux Foundation. All rights reserved. + * + * This program is free software; you can redistribute it and/or modify + * it under the terms of the GNU General Public License version 2 and + * only version 2 as published by the Free Software Foundation. + * + * This program is distributed in the hope that it will be useful, + * but WITHOUT ANY WARRANTY; without even the implied warranty of + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the + * GNU General Public License for more details. + */ + +#include linux/amba/bus.h +#include linux/clk.h +#include linux/coresight.h +#include linux/device.h +#include linux/err.h +#include linux/init.h +#include linux/io.h +#include linux/kernel.h +#include linux/module.h +#include linux/of.h +#include linux/pm_runtime.h +#include linux/slab.h + +#include coresight-priv.h + +#define REPLICATOR_IDFILTER0 0x000 +#define REPLICATOR_IDFILTER1 0x004 + +/** + * struct replicator_state - specifics associated to a replicator component + * @base: memory mapped base address for this component. + * @dev: the device
