Re: [PATCH 1/2] drivers/irqchip: Fixup csky,mpintc compile error with CPU_CK610
Thx Marc, On Wed, Feb 3, 2021 at 11:44 PM Marc Zyngier wrote: > > On 2021-02-03 13:48, guo...@kernel.org wrote: > > From: Guo Ren > > > > The irq-csky-mpintc.c only could support CPU_CK860 and it will > > compile error with CPU_CK610. > > > > Signed-off-by: Guo Ren > > Cc: Marc Zyngier > > --- > > drivers/irqchip/Kconfig | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/drivers/irqchip/Kconfig b/drivers/irqchip/Kconfig > > index b147f22a78f4..9be2dd5c6380 100644 > > --- a/drivers/irqchip/Kconfig > > +++ b/drivers/irqchip/Kconfig > > @@ -433,7 +433,7 @@ config QCOM_PDC > > > > config CSKY_MPINTC > > bool "C-SKY Multi Processor Interrupt Controller" > > - depends on CSKY > > + depends on CSKY && CPU_CK860 > > help > > Say yes here to enable C-SKY SMP interrupt controller driver used > > for C-SKY SMP system. > > I'm not convinced this is the right fix. > > You already select CSKY_MPINTC only when CPU_CK860 is selected, > so preventing the user from selecting it should simply be a matter > of dropping the string after bool. Yes, you are right. I will change it into arch/csky. -- Best Regards Guo Ren ML: https://lore.kernel.org/linux-csky/
Re: [PATCH 1/2] drivers/irqchip: Fixup csky,mpintc compile error with CPU_CK610
On 2021-02-03 13:48, guo...@kernel.org wrote: From: Guo Ren The irq-csky-mpintc.c only could support CPU_CK860 and it will compile error with CPU_CK610. Signed-off-by: Guo Ren Cc: Marc Zyngier --- drivers/irqchip/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/irqchip/Kconfig b/drivers/irqchip/Kconfig index b147f22a78f4..9be2dd5c6380 100644 --- a/drivers/irqchip/Kconfig +++ b/drivers/irqchip/Kconfig @@ -433,7 +433,7 @@ config QCOM_PDC config CSKY_MPINTC bool "C-SKY Multi Processor Interrupt Controller" - depends on CSKY + depends on CSKY && CPU_CK860 help Say yes here to enable C-SKY SMP interrupt controller driver used for C-SKY SMP system. I'm not convinced this is the right fix. You already select CSKY_MPINTC only when CPU_CK860 is selected, so preventing the user from selecting it should simply be a matter of dropping the string after bool. Thanks, M. diff --git a/drivers/irqchip/Kconfig b/drivers/irqchip/Kconfig index 94920a51c628..2e7b562bbaac 100644 --- a/drivers/irqchip/Kconfig +++ b/drivers/irqchip/Kconfig @@ -432,7 +432,7 @@ config QCOM_PDC IRQs for Qualcomm Technologies Inc (QTI) mobile chips. config CSKY_MPINTC - bool "C-SKY Multi Processor Interrupt Controller" + bool depends on CSKY help Say yes here to enable C-SKY SMP interrupt controller driver used -- Jazz is not dead. It just smells funny...
[PATCH 1/2] drivers/irqchip: Fixup csky,mpintc compile error with CPU_CK610
From: Guo Ren The irq-csky-mpintc.c only could support CPU_CK860 and it will compile error with CPU_CK610. Signed-off-by: Guo Ren Cc: Marc Zyngier --- drivers/irqchip/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/irqchip/Kconfig b/drivers/irqchip/Kconfig index b147f22a78f4..9be2dd5c6380 100644 --- a/drivers/irqchip/Kconfig +++ b/drivers/irqchip/Kconfig @@ -433,7 +433,7 @@ config QCOM_PDC config CSKY_MPINTC bool "C-SKY Multi Processor Interrupt Controller" - depends on CSKY + depends on CSKY && CPU_CK860 help Say yes here to enable C-SKY SMP interrupt controller driver used for C-SKY SMP system. -- 2.17.1
