Re: [PATCH 1/2] dt-bindings: clock: Introduce QCOM RPMh clock bindings

2018-05-02 Thread Stephen Boyd 
Quoting Taniya Das (2018-05-02 03:51:16)
> Add RPMh clock device bindings for Qualcomm Technology Inc's SoCs. These
> devices would be used for communicating resource state requests to control
> the clocks managed by RPMh.
> 
> Signed-off-by: Taniya Das 
> Reviewed-by: Rob Herring 

When you change things you shouldn't keep around reviewed-by tags if it
significantly changes..

> +Example :
> +
> +#include 
> +
> +   _rsc {
> +   rpmhcc: clock-controller {
> +   compatible = "qcom,sdm845-rpmh-clk";
> +   #clock-cells = <1>;
> +   assigned-clocks = <_rpmh RPMH_CXO_CLK>,
> +   <_rpmh RPMH_CXO_CLK_A>,
> +   <_rpmh RPMH_LN_BB_CLK2>,
> +   <_rpmh RPMH_LN_BB_CLK2_A>,
> +   <_rpmh RPMH_LN_BB_CLK3>,
> +   <_rpmh RPMH_LN_BB_CLK3_A>;
> +   assigned-clock-parents = <_board_div>,
> +   <_board_div>,
> +   <_board_div>,
> +   <_board_div>,
> +   <_board_div>,
> +   <_board_div>,

There's only one parent, so assigned-clock-parents doesn't really make
sense. If anything, we would have 'clocks = ' here and specify the xo
board clk and the div 2 clk that live in DT. But I already merged this
binding, two patchsets ago. Please look in clk-next.

> +   };
> +#define RPMH_RF_CLK2   8
> +#define RPMH_RF_CLK2_A 9
> +#define RPMH_RF_CLK3   10
> +#define RPMH_RF_CLK3_A 11
> +

Ok. I dropped CLK4* from the previous patch you sent and dropped Amit's
signed-off-by.

Re: [PATCH 1/2] dt-bindings: clock: Introduce QCOM RPMh clock bindings

2018-05-02 Thread Stephen Boyd 
Quoting Taniya Das (2018-05-02 03:51:16)
> Add RPMh clock device bindings for Qualcomm Technology Inc's SoCs. These
> devices would be used for communicating resource state requests to control
> the clocks managed by RPMh.
> 
> Signed-off-by: Taniya Das 
> Reviewed-by: Rob Herring 

When you change things you shouldn't keep around reviewed-by tags if it
significantly changes..

> +Example :
> +
> +#include 
> +
> +   _rsc {
> +   rpmhcc: clock-controller {
> +   compatible = "qcom,sdm845-rpmh-clk";
> +   #clock-cells = <1>;
> +   assigned-clocks = <_rpmh RPMH_CXO_CLK>,
> +   <_rpmh RPMH_CXO_CLK_A>,
> +   <_rpmh RPMH_LN_BB_CLK2>,
> +   <_rpmh RPMH_LN_BB_CLK2_A>,
> +   <_rpmh RPMH_LN_BB_CLK3>,
> +   <_rpmh RPMH_LN_BB_CLK3_A>;
> +   assigned-clock-parents = <_board_div>,
> +   <_board_div>,
> +   <_board_div>,
> +   <_board_div>,
> +   <_board_div>,
> +   <_board_div>,

There's only one parent, so assigned-clock-parents doesn't really make
sense. If anything, we would have 'clocks = ' here and specify the xo
board clk and the div 2 clk that live in DT. But I already merged this
binding, two patchsets ago. Please look in clk-next.

> +   };
> +#define RPMH_RF_CLK2   8
> +#define RPMH_RF_CLK2_A 9
> +#define RPMH_RF_CLK3   10
> +#define RPMH_RF_CLK3_A 11
> +

Ok. I dropped CLK4* from the previous patch you sent and dropped Amit's
signed-off-by.

[PATCH 1/2] dt-bindings: clock: Introduce QCOM RPMh clock bindings

2018-05-02 Thread Taniya Das 
Add RPMh clock device bindings for Qualcomm Technology Inc's SoCs. These
devices would be used for communicating resource state requests to control
the clocks managed by RPMh.

Signed-off-by: Taniya Das 
Reviewed-by: Rob Herring 
---
 .../devicetree/bindings/clock/qcom,rpmh-clk.txt| 46 ++
 include/dt-bindings/clock/qcom,rpmh.h  | 22 +++
 2 files changed, 68 insertions(+)
 create mode 100644 Documentation/devicetree/bindings/clock/qcom,rpmh-clk.txt
 create mode 100644 include/dt-bindings/clock/qcom,rpmh.h

diff --git a/Documentation/devicetree/bindings/clock/qcom,rpmh-clk.txt 
b/Documentation/devicetree/bindings/clock/qcom,rpmh-clk.txt
new file mode 100644
index 000..2632cae
--- /dev/null
+++ b/Documentation/devicetree/bindings/clock/qcom,rpmh-clk.txt
@@ -0,0 +1,46 @@
+Qualcomm Technologies, Inc. RPMh Clocks
+---
+
+Resource Power Manager Hardened (RPMh) manages shared resources on
+some Qualcomm Technologies Inc. SoCs. It accepts clock requests from
+other hardware subsystems via RSC to control clocks.
+
+Required properties :
+- compatible : shall contain "qcom,sdm845-rpmh-clk"
+
+- #clock-cells : must contain 1
+
+Optional properties :
+
+These below properities would be required in the cases where the parent of the
+clocks would be "xo_board_div". The default parent for the clock is "xo_board".
+
+- assigned-clocks: from the common clock binding;
+   should be: clock specifier for each output clock of this
+   provider node
+
+- assigned-clock-parents: from the common clock binding;
+   should be: phandle of input clock listed in clocks
+   property
+Example :
+
+#include 
+
+   _rsc {
+   rpmhcc: clock-controller {
+   compatible = "qcom,sdm845-rpmh-clk";
+   #clock-cells = <1>;
+   assigned-clocks = <_rpmh RPMH_CXO_CLK>,
+   <_rpmh RPMH_CXO_CLK_A>,
+   <_rpmh RPMH_LN_BB_CLK2>,
+   <_rpmh RPMH_LN_BB_CLK2_A>,
+   <_rpmh RPMH_LN_BB_CLK3>,
+   <_rpmh RPMH_LN_BB_CLK3_A>;
+   assigned-clock-parents = <_board_div>,
+   <_board_div>,
+   <_board_div>,
+   <_board_div>,
+   <_board_div>,
+   <_board_div>,
+   };
+   };
diff --git a/include/dt-bindings/clock/qcom,rpmh.h 
b/include/dt-bindings/clock/qcom,rpmh.h
new file mode 100644
index 000..f48fbd6
--- /dev/null
+++ b/include/dt-bindings/clock/qcom,rpmh.h
@@ -0,0 +1,22 @@
+/* SPDX-License-Identifier: GPL-2.0 */
+/* Copyright (c) 2018, The Linux Foundation. All rights reserved. */
+
+
+#ifndef _DT_BINDINGS_CLK_MSM_RPMH_H
+#define _DT_BINDINGS_CLK_MSM_RPMH_H
+
+/* RPMh controlled clocks */
+#define RPMH_CXO_CLK   0
+#define RPMH_CXO_CLK_A 1
+#define RPMH_LN_BB_CLK22
+#define RPMH_LN_BB_CLK2_A  3
+#define RPMH_LN_BB_CLK34
+#define RPMH_LN_BB_CLK3_A  5
+#define RPMH_RF_CLK1   6
+#define RPMH_RF_CLK1_A 7
+#define RPMH_RF_CLK2   8
+#define RPMH_RF_CLK2_A 9
+#define RPMH_RF_CLK3   10
+#define RPMH_RF_CLK3_A 11
+
+#endif
--
Qualcomm INDIA, on behalf of Qualcomm Innovation Center, Inc.is a member
of the Code Aurora Forum, hosted by the  Linux Foundation.

[PATCH 1/2] dt-bindings: clock: Introduce QCOM RPMh clock bindings

2018-05-02 Thread Taniya Das 
Add RPMh clock device bindings for Qualcomm Technology Inc's SoCs. These
devices would be used for communicating resource state requests to control
the clocks managed by RPMh.

Signed-off-by: Taniya Das 
Reviewed-by: Rob Herring 
---
 .../devicetree/bindings/clock/qcom,rpmh-clk.txt| 46 ++
 include/dt-bindings/clock/qcom,rpmh.h  | 22 +++
 2 files changed, 68 insertions(+)
 create mode 100644 Documentation/devicetree/bindings/clock/qcom,rpmh-clk.txt
 create mode 100644 include/dt-bindings/clock/qcom,rpmh.h

diff --git a/Documentation/devicetree/bindings/clock/qcom,rpmh-clk.txt 
b/Documentation/devicetree/bindings/clock/qcom,rpmh-clk.txt
new file mode 100644
index 000..2632cae
--- /dev/null
+++ b/Documentation/devicetree/bindings/clock/qcom,rpmh-clk.txt
@@ -0,0 +1,46 @@
+Qualcomm Technologies, Inc. RPMh Clocks
+---
+
+Resource Power Manager Hardened (RPMh) manages shared resources on
+some Qualcomm Technologies Inc. SoCs. It accepts clock requests from
+other hardware subsystems via RSC to control clocks.
+
+Required properties :
+- compatible : shall contain "qcom,sdm845-rpmh-clk"
+
+- #clock-cells : must contain 1
+
+Optional properties :
+
+These below properities would be required in the cases where the parent of the
+clocks would be "xo_board_div". The default parent for the clock is "xo_board".
+
+- assigned-clocks: from the common clock binding;
+   should be: clock specifier for each output clock of this
+   provider node
+
+- assigned-clock-parents: from the common clock binding;
+   should be: phandle of input clock listed in clocks
+   property
+Example :
+
+#include 
+
+   _rsc {
+   rpmhcc: clock-controller {
+   compatible = "qcom,sdm845-rpmh-clk";
+   #clock-cells = <1>;
+   assigned-clocks = <_rpmh RPMH_CXO_CLK>,
+   <_rpmh RPMH_CXO_CLK_A>,
+   <_rpmh RPMH_LN_BB_CLK2>,
+   <_rpmh RPMH_LN_BB_CLK2_A>,
+   <_rpmh RPMH_LN_BB_CLK3>,
+   <_rpmh RPMH_LN_BB_CLK3_A>;
+   assigned-clock-parents = <_board_div>,
+   <_board_div>,
+   <_board_div>,
+   <_board_div>,
+   <_board_div>,
+   <_board_div>,
+   };
+   };
diff --git a/include/dt-bindings/clock/qcom,rpmh.h 
b/include/dt-bindings/clock/qcom,rpmh.h
new file mode 100644
index 000..f48fbd6
--- /dev/null
+++ b/include/dt-bindings/clock/qcom,rpmh.h
@@ -0,0 +1,22 @@
+/* SPDX-License-Identifier: GPL-2.0 */
+/* Copyright (c) 2018, The Linux Foundation. All rights reserved. */
+
+
+#ifndef _DT_BINDINGS_CLK_MSM_RPMH_H
+#define _DT_BINDINGS_CLK_MSM_RPMH_H
+
+/* RPMh controlled clocks */
+#define RPMH_CXO_CLK   0
+#define RPMH_CXO_CLK_A 1
+#define RPMH_LN_BB_CLK22
+#define RPMH_LN_BB_CLK2_A  3
+#define RPMH_LN_BB_CLK34
+#define RPMH_LN_BB_CLK3_A  5
+#define RPMH_RF_CLK1   6
+#define RPMH_RF_CLK1_A 7
+#define RPMH_RF_CLK2   8
+#define RPMH_RF_CLK2_A 9
+#define RPMH_RF_CLK3   10
+#define RPMH_RF_CLK3_A 11
+
+#endif
--
Qualcomm INDIA, on behalf of Qualcomm Innovation Center, Inc.is a member
of the Code Aurora Forum, hosted by the  Linux Foundation.