Re: [PATCH 1/2] dt-bindings: phy: Add UniPhier AHCI PHY description
Hi Rob,
On 2020/06/30 6:55, Rob Herring wrote:
On Fri, 19 Jun 2020 11:36:46 +0900, Kunihiko Hayashi wrote:
Add DT bindings for PHY interface built into ahci controller implemented
in UniPhier SoCs.
Signed-off-by: Kunihiko Hayashi
---
.../bindings/phy/socionext,uniphier-ahci-phy.yaml | 76 ++
1 file changed, 76 insertions(+)
create mode 100644
Documentation/devicetree/bindings/phy/socionext,uniphier-ahci-phy.yaml
My bot found errors running 'make dt_binding_check' on your patch:
/builds/robherring/linux-dt-review/Documentation/devicetree/bindings/phy/socionext,uniphier-ahci-phy.yaml:
properties:reset-names: [{'items': [{'const': 'link'}, {'const': 'phy'}]}] is
not of type 'object', 'boolean'
Documentation/devicetree/bindings/Makefile:20: recipe for target
'Documentation/devicetree/bindings/phy/socionext,uniphier-ahci-phy.example.dts'
failed
make[1]: ***
[Documentation/devicetree/bindings/phy/socionext,uniphier-ahci-phy.example.dts]
Error 1
make[1]: *** Waiting for unfinished jobs
Makefile:1347: recipe for target 'dt_binding_check' failed
make: *** [dt_binding_check] Error 2
See https://patchwork.ozlabs.org/patch/1312535
If you already ran 'make dt_binding_check' and didn't see the above
error(s), then make sure dt-schema is up to date:
pip3 install git+https://github.com/devicetree-org/dt-schema.git@master
--upgrade
Please check and re-submit.
I made a mistake when creating the patch.
I've found where it is wrong, so fix it in v2.
Thank you,
---
Best Regards
Kunihiko Hayashi
Re: [PATCH 1/2] dt-bindings: phy: Add UniPhier AHCI PHY description
On Fri, 19 Jun 2020 11:36:46 +0900, Kunihiko Hayashi wrote:
> Add DT bindings for PHY interface built into ahci controller implemented
> in UniPhier SoCs.
>
> Signed-off-by: Kunihiko Hayashi
> ---
> .../bindings/phy/socionext,uniphier-ahci-phy.yaml | 76
> ++
> 1 file changed, 76 insertions(+)
> create mode 100644
> Documentation/devicetree/bindings/phy/socionext,uniphier-ahci-phy.yaml
>
My bot found errors running 'make dt_binding_check' on your patch:
/builds/robherring/linux-dt-review/Documentation/devicetree/bindings/phy/socionext,uniphier-ahci-phy.yaml:
properties:reset-names: [{'items': [{'const': 'link'}, {'const': 'phy'}]}] is
not of type 'object', 'boolean'
Documentation/devicetree/bindings/Makefile:20: recipe for target
'Documentation/devicetree/bindings/phy/socionext,uniphier-ahci-phy.example.dts'
failed
make[1]: ***
[Documentation/devicetree/bindings/phy/socionext,uniphier-ahci-phy.example.dts]
Error 1
make[1]: *** Waiting for unfinished jobs
Makefile:1347: recipe for target 'dt_binding_check' failed
make: *** [dt_binding_check] Error 2
See https://patchwork.ozlabs.org/patch/1312535
If you already ran 'make dt_binding_check' and didn't see the above
error(s), then make sure dt-schema is up to date:
pip3 install git+https://github.com/devicetree-org/dt-schema.git@master
--upgrade
Please check and re-submit.
[PATCH 1/2] dt-bindings: phy: Add UniPhier AHCI PHY description
Add DT bindings for PHY interface built into ahci controller implemented
in UniPhier SoCs.
Signed-off-by: Kunihiko Hayashi
---
.../bindings/phy/socionext,uniphier-ahci-phy.yaml | 76 ++
1 file changed, 76 insertions(+)
create mode 100644
Documentation/devicetree/bindings/phy/socionext,uniphier-ahci-phy.yaml
diff --git
a/Documentation/devicetree/bindings/phy/socionext,uniphier-ahci-phy.yaml
b/Documentation/devicetree/bindings/phy/socionext,uniphier-ahci-phy.yaml
new file mode 100644
index 000..9391e2e
--- /dev/null
+++ b/Documentation/devicetree/bindings/phy/socionext,uniphier-ahci-phy.yaml
@@ -0,0 +1,76 @@
+# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
+%YAML 1.2
+---
+$id: http://devicetree.org/schemas/phy/socionext,uniphier-ahci-phy.yaml#
+$schema: http://devicetree.org/meta-schemas/core.yaml#
+
+title: Socionext UniPhier AHCI PHY
+
+description: |
+ This describes the deivcetree bindings for PHY interfaces built into
+ AHCI controller implemented on Socionext UniPhier SoCs.
+
+maintainers:
+ - Kunihiko Hayashi
+
+properties:
+ compatible:
+enum:
+ - socionext,uniphier-pxs2-ahci-phy
+ - socionext,uniphier-pxs3-ahci-phy
+
+ reg:
+description: PHY register region (offset and length)
+
+ "#phy-cells":
+const: 0
+
+ clocks:
+maxItems: 2
+
+ clock-names:
+oneOf:
+ - items: # for PXs2
+- const: link
+ - items: # for others
+- const: link
+- const: phy
+
+ resets:
+maxItems: 2
+
+ reset-names:
+- items:
+ - const: link
+ - const: phy
+
+required:
+ - compatible
+ - reg
+ - "#phy-cells"
+ - clocks
+ - clock-names
+ - resets
+ - reset-names
+
+additionalProperties: false
+
+examples:
+ - |
+ahci-glue@6570 {
+compatible = "socionext,uniphier-pxs3-ahci-glue",
+ "simple-mfd";
+#address-cells = <1>;
+#size-cells = <1>;
+ranges = <0 0x6570 0x100>;
+
+ahci_phy: phy@10 {
+compatible = "socionext,uniphier-pxs3-ahci-phy";
+reg = <0x10 0x10>;
+#phy-cells = <0>;
+clock-names = "link", "phy";
+clocks = <_clk 28>, <_clk 30>;
+reset-names = "link", "phy";
+resets = <_rst 28>, <_rst 30>;
+};
+};
--
2.7.4
