Re: [PATCH 1/2] fixup! net/macb: Adding comments to various #defs to make interpretation easier

2015-01-14 Thread David Miller 
From: Xander Huff 
Date: Wed, 14 Jan 2015 15:18:34 -0600

> On 1/14/2015 3:09 PM, David Miller wrote:
>>
>> As I mentioned, this won't do.
>>
>> I've already applied your original patches to net-next, therefore you
>> will
>> have to submit fixups relative to that.
>>
> These fixup commits are relative to an updated net-next, specifically
> "237de6e Merge branch 'hip04'".
> 
> Do you need them relative to (what I'm seeing is the latest) "2733135
> Merge branch 'vxlan_rco'"?

Why don't you make your subject lines and commit messages just say what
they are doing, rather than just saying "fix this other change"?
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Re: [PATCH 1/2] fixup! net/macb: Adding comments to various #defs to make interpretation easier

2015-01-14 Thread Xander Huff 

On 1/14/2015 3:09 PM, David Miller wrote:


As I mentioned, this won't do.

I've already applied your original patches to net-next, therefore you will
have to submit fixups relative to that.

These fixup commits are relative to an updated net-next, specifically "237de6e 
Merge branch 'hip04'".


Do you need them relative to (what I'm seeing is the latest) "2733135 Merge 
branch 'vxlan_rco'"?

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Re: [PATCH 1/2] fixup! net/macb: Adding comments to various #defs to make interpretation easier

2015-01-14 Thread David Miller 

As I mentioned, this won't do.

I've already applied your original patches to net-next, therefore you will
have to submit fixups relative to that.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[PATCH 1/2] fixup! net/macb: Adding comments to various #defs to make interpretation easier

2015-01-14 Thread Xander Huff 
Signed-off-by: Xander Huff 
---
 drivers/net/ethernet/cadence/macb.h | 107 +---
 1 file changed, 26 insertions(+), 81 deletions(-)

diff --git a/drivers/net/ethernet/cadence/macb.h 
b/drivers/net/ethernet/cadence/macb.h
index 378b218..d7b93d0 100644
--- a/drivers/net/ethernet/cadence/macb.h
+++ b/drivers/net/ethernet/cadence/macb.h
@@ -275,9 +275,7 @@
 #define MACB_THALT_SIZE1
 #define MACB_NCR_TPF_OFFSET11 /* Transmit pause frame */
 #define MACB_NCR_TPF_SIZE  1
-#define MACB_TZQ_OFFSET12 /* Transmit zero 
quantum
-   * pause frame
-   */
+#define MACB_TZQ_OFFSET12 /* Transmit zero 
quantum pause frame */
 #define MACB_TZQ_SIZE  1
 
 /* Bitfields in NCFGR */
@@ -299,9 +297,7 @@
 #define MACB_UNI_SIZE  1
 #define MACB_BIG_OFFSET8 /* Receive 1536 byte 
frames */
 #define MACB_BIG_SIZE  1
-#define MACB_EAE_OFFSET9 /* External address 
match
-  * enable
-  */
+#define MACB_EAE_OFFSET9 /* External address 
match enable */
 #define MACB_EAE_SIZE  1
 #define MACB_CLK_OFFSET10
 #define MACB_CLK_SIZE  2
@@ -313,9 +309,7 @@
 #define MACB_RM9200_RMII_SIZE  1  /* AT91RM9200 only */
 #define MACB_RBOF_OFFSET   14 /* Receive buffer offset */
 #define MACB_RBOF_SIZE 2
-#define MACB_RLCE_OFFSET   16 /* Length field error frame
-   * discard
-   */
+#define MACB_RLCE_OFFSET   16 /* Length field error frame 
discard */
 #define MACB_RLCE_SIZE 1
 #define MACB_DRFCS_OFFSET  17 /* FCS remove */
 #define MACB_DRFCS_SIZE1
@@ -335,41 +329,22 @@
 #define GEM_RXCOEN_SIZE1
 
 /* Constants for data bus width. */
-#define GEM_DBW32  0 /* 32 bit AMBA AHB data bus
-  * width
-  */
-#define GEM_DBW64  1 /* 64 bit AMBA AHB data bus
-  * width
-  */
-#define GEM_DBW128 2 /* 128 bit AMBA AHB data bus
-  * width
-  */
+#define GEM_DBW32  0 /* 32 bit AMBA AHB data bus 
width */
+#define GEM_DBW64  1 /* 64 bit AMBA AHB data bus 
width */
+#define GEM_DBW128 2 /* 128 bit AMBA AHB data bus 
width */
 
 /* Bitfields in DMACFG. */
-#define GEM_FBLDO_OFFSET   0 /* AHB fixed burst length for
-  * DMA data operations
-  */
+#define GEM_FBLDO_OFFSET   0 /* AHB fixed burst length for 
DMA data operations */
 #define GEM_FBLDO_SIZE 5
-#define GEM_ENDIA_OFFSET   7 /* AHB endian swap mode enable
-  * for packet data accesses
-  */
+#define GEM_ENDIA_OFFSET   7 /* AHB endian swap mode 
enable for packet data accesses */
 #define GEM_ENDIA_SIZE 1
-#define GEM_RXBMS_OFFSET   8 /* Receiver packet buffer
-  * memory size select
-  */
+#define GEM_RXBMS_OFFSET   8 /* Receiver packet buffer 
memory size select */
 #define GEM_RXBMS_SIZE 2
-#define GEM_TXPBMS_OFFSET  10 /* Transmitter packet buffer
-   * memory size select
-   */
+#define GEM_TXPBMS_OFFSET  10 /* Transmitter packet buffer 
memory size select */
 #define GEM_TXPBMS_SIZE1
-#define GEM_TXCOEN_OFFSET  11 /* Transmitter IP, TCP and
-   * UDP checksum generation
-   * offload enable
-