Re: [PATCH 1/2] fsnotify/fdinfo: use named constants instead of hardcoded values
On Tue, Sep 02, 2014 at 12:14:08PM +0400, Cyrill Gorcunov wrote: > On Tue, Sep 02, 2014 at 12:00:14PM +0400, Andrey Vagin wrote: > > MAX_HANDLE_SZ is equal to 128, but currently the size of pad is only 64 > > bytes, so exportfs_encode_inode_fh can return an error. > > > > Cc: Cyrill Gorcunov > > Cc: Alexander Viro > > Cc: Andrew Morton > > Signed-off-by: Andrey Vagin > Acked-by: Cyrill Gorcunov Btw, I think both are good candidates for @stable. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH 1/2] fsnotify/fdinfo: use named constants instead of hardcoded values
On Tue, Sep 02, 2014 at 12:00:14PM +0400, Andrey Vagin wrote: > MAX_HANDLE_SZ is equal to 128, but currently the size of pad is only 64 > bytes, so exportfs_encode_inode_fh can return an error. > > Cc: Cyrill Gorcunov > Cc: Alexander Viro > Cc: Andrew Morton > Signed-off-by: Andrey Vagin Acked-by: Cyrill Gorcunov -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
[PATCH 1/2] fsnotify/fdinfo: use named constants instead of hardcoded values
MAX_HANDLE_SZ is equal to 128, but currently the size of pad is only 64
bytes, so exportfs_encode_inode_fh can return an error.
Cc: Cyrill Gorcunov
Cc: Alexander Viro
Cc: Andrew Morton
Signed-off-by: Andrey Vagin
---
fs/notify/fdinfo.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/fs/notify/fdinfo.c b/fs/notify/fdinfo.c
index 238a593..660d33b 100644
--- a/fs/notify/fdinfo.c
+++ b/fs/notify/fdinfo.c
@@ -42,7 +42,7 @@ static int show_mark_fhandle(struct seq_file *m, struct inode
*inode)
{
struct {
struct file_handle handle;
- u8 pad[64];
+ u8 pad[MAX_HANDLE_SZ];
} f;
int size, ret, i;
@@ -50,7 +50,7 @@ static int show_mark_fhandle(struct seq_file *m, struct inode
*inode)
size = f.handle.handle_bytes >> 2;
ret = exportfs_encode_inode_fh(inode, (struct fid *)f.handle.f_handle,
, 0);
- if ((ret == 255) || (ret == -ENOSPC)) {
+ if ((ret == FILEID_INVALID) || (ret == -ENOSPC)) {
WARN_ONCE(1, "Can't encode file handler for inotify: %d\n",
ret);
return 0;
}
--
1.9.3
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
[PATCH 1/2] fsnotify/fdinfo: use named constants instead of hardcoded values
MAX_HANDLE_SZ is equal to 128, but currently the size of pad is only 64
bytes, so exportfs_encode_inode_fh can return an error.
Cc: Cyrill Gorcunov gorcu...@openvz.org
Cc: Alexander Viro v...@zeniv.linux.org.uk
Cc: Andrew Morton a...@linux-foundation.org
Signed-off-by: Andrey Vagin ava...@openvz.org
---
fs/notify/fdinfo.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/fs/notify/fdinfo.c b/fs/notify/fdinfo.c
index 238a593..660d33b 100644
--- a/fs/notify/fdinfo.c
+++ b/fs/notify/fdinfo.c
@@ -42,7 +42,7 @@ static int show_mark_fhandle(struct seq_file *m, struct inode
*inode)
{
struct {
struct file_handle handle;
- u8 pad[64];
+ u8 pad[MAX_HANDLE_SZ];
} f;
int size, ret, i;
@@ -50,7 +50,7 @@ static int show_mark_fhandle(struct seq_file *m, struct inode
*inode)
size = f.handle.handle_bytes 2;
ret = exportfs_encode_inode_fh(inode, (struct fid *)f.handle.f_handle,
size, 0);
- if ((ret == 255) || (ret == -ENOSPC)) {
+ if ((ret == FILEID_INVALID) || (ret == -ENOSPC)) {
WARN_ONCE(1, Can't encode file handler for inotify: %d\n,
ret);
return 0;
}
--
1.9.3
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH 1/2] fsnotify/fdinfo: use named constants instead of hardcoded values
On Tue, Sep 02, 2014 at 12:00:14PM +0400, Andrey Vagin wrote: MAX_HANDLE_SZ is equal to 128, but currently the size of pad is only 64 bytes, so exportfs_encode_inode_fh can return an error. Cc: Cyrill Gorcunov gorcu...@openvz.org Cc: Alexander Viro v...@zeniv.linux.org.uk Cc: Andrew Morton a...@linux-foundation.org Signed-off-by: Andrey Vagin ava...@openvz.org Acked-by: Cyrill Gorcunov gorcu...@openvz.org -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH 1/2] fsnotify/fdinfo: use named constants instead of hardcoded values
On Tue, Sep 02, 2014 at 12:14:08PM +0400, Cyrill Gorcunov wrote: On Tue, Sep 02, 2014 at 12:00:14PM +0400, Andrey Vagin wrote: MAX_HANDLE_SZ is equal to 128, but currently the size of pad is only 64 bytes, so exportfs_encode_inode_fh can return an error. Cc: Cyrill Gorcunov gorcu...@openvz.org Cc: Alexander Viro v...@zeniv.linux.org.uk Cc: Andrew Morton a...@linux-foundation.org Signed-off-by: Andrey Vagin ava...@openvz.org Acked-by: Cyrill Gorcunov gorcu...@openvz.org Btw, I think both are good candidates for @stable. -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
