Re: [PATCH 1/2] hso: Earlier catch of error condition

2013-08-21 Thread David Miller
From: Greg KH 
Date: Wed, 21 Aug 2013 09:25:07 -0700

> On Wed, Aug 21, 2013 at 01:43:07AM -0700, Daniel Gimpelevich wrote:
>> There is no need to get an interface specification if we know it's the
>> wrong one. 
>> 
>> Signed-off-by: Daniel Gimpelevich 
> 
> Acked-by: Greg Kroah-Hartman 

Applied.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/


Re: [PATCH 1/2] hso: Earlier catch of error condition

2013-08-21 Thread Greg KH
On Wed, Aug 21, 2013 at 01:43:07AM -0700, Daniel Gimpelevich wrote:
> There is no need to get an interface specification if we know it's the
> wrong one. 
> 
> Signed-off-by: Daniel Gimpelevich 

Acked-by: Greg Kroah-Hartman 
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/


[PATCH 1/2] hso: Earlier catch of error condition

2013-08-21 Thread Daniel Gimpelevich
There is no need to get an interface specification if we know it's the
wrong one. 

Signed-off-by: Daniel Gimpelevich 
---
 drivers/net/usb/hso.c |9 +
 1 file changed, 5 insertions(+), 4 deletions(-)

diff --git a/drivers/net/usb/hso.c b/drivers/net/usb/hso.c
index cba1d46..5fb36ed 100644
--- a/drivers/net/usb/hso.c
+++ b/drivers/net/usb/hso.c
@@ -2886,6 +2886,11 @@ static int hso_probe(struct usb_interface *interface,
struct hso_shared_int *shared_int;
struct hso_device *tmp_dev = NULL;
 
+   if (interface->cur_altsetting->desc.bInterfaceClass != 0xFF) {
+   dev_err(&interface->dev, "Not our interface\n");
+   return -ENODEV;
+   }
+
if_num = interface->altsetting->desc.bInterfaceNumber;
 
/* Get the interface/port specification from either driver_info or from
@@ -2895,10 +2900,6 @@ static int hso_probe(struct usb_interface *interface,
else
port_spec = hso_get_config_data(interface);
 
-   if (interface->cur_altsetting->desc.bInterfaceClass != 0xFF) {
-   dev_err(&interface->dev, "Not our interface\n");
-   return -ENODEV;
-   }
/* Check if we need to switch to alt interfaces prior to port
 * configuration */
if (interface->num_altsetting > 1)
-- 
1.7.9.5

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/