Re: [PATCH 1/2] mtd: cmdlinepart: Make it into a module

2013-01-18 Thread Artem Bityutskiy
On Wed, 2013-01-16 at 02:12 +0100, Lubomir Rintel wrote:
> All other partitioning schemes can be compiled as modules
> 
> Signed-off-by: Lubomir Rintel 

Both pushed to l2-mtd.git, thanks!

-- 
Best Regards,
Artem Bityutskiy


signature.asc
Description: This is a digitally signed message part


Re: [PATCH 1/2] mtd: cmdlinepart: Make it into a module

2013-01-18 Thread Artem Bityutskiy
On Wed, 2013-01-16 at 02:12 +0100, Lubomir Rintel wrote:
 All other partitioning schemes can be compiled as modules
 
 Signed-off-by: Lubomir Rintel lkund...@v3.sk

Both pushed to l2-mtd.git, thanks!

-- 
Best Regards,
Artem Bityutskiy


signature.asc
Description: This is a digitally signed message part


[PATCH 1/2] mtd: cmdlinepart: Make it into a module

2013-01-15 Thread Lubomir Rintel
All other partitioning schemes can be compiled as modules

Signed-off-by: Lubomir Rintel 
---
 drivers/mtd/Kconfig   |4 ++--
 drivers/mtd/cmdlinepart.c |8 +++-
 2 files changed, 9 insertions(+), 3 deletions(-)

diff --git a/drivers/mtd/Kconfig b/drivers/mtd/Kconfig
index 73fcbbe..4dd3b38 100644
--- a/drivers/mtd/Kconfig
+++ b/drivers/mtd/Kconfig
@@ -74,8 +74,8 @@ config MTD_REDBOOT_PARTS_READONLY
 endif # MTD_REDBOOT_PARTS
 
 config MTD_CMDLINE_PARTS
-   bool "Command line partition table parsing"
-   depends on MTD = "y"
+   tristate "Command line partition table parsing"
+   depends on MTD
---help---
  Allow generic configuration of the MTD partition tables via the kernel
  command line. Multiple flash resources are supported for hardware 
where
diff --git a/drivers/mtd/cmdlinepart.c b/drivers/mtd/cmdlinepart.c
index aed1b8a..a2bb2ea 100644
--- a/drivers/mtd/cmdlinepart.c
+++ b/drivers/mtd/cmdlinepart.c
@@ -70,6 +70,7 @@ struct cmdline_mtd_partition {
 static struct cmdline_mtd_partition *partitions;
 
 /* the command line passed to mtdpart_setup() */
+static char *mtdparts;
 static char *cmdline;
 static int cmdline_parsed;
 
@@ -360,7 +361,7 @@ static int parse_cmdline_partitions(struct mtd_info *master,
  *
  * This function needs to be visible for bootloaders.
  */
-static int mtdpart_setup(char *s)
+static int __init mtdpart_setup(char *s)
 {
cmdline = s;
return 1;
@@ -376,11 +377,16 @@ static struct mtd_part_parser cmdline_parser = {
 
 static int __init cmdline_parser_init(void)
 {
+   if (mtdparts)
+   mtdpart_setup(mtdparts);
return register_mtd_parser(_parser);
 }
 
 module_init(cmdline_parser_init);
 
+MODULE_PARM_DESC(mtdparts, "Partitioning specification");
+module_param(mtdparts, charp, 0);
+
 MODULE_LICENSE("GPL");
 MODULE_AUTHOR("Marius Groeger ");
 MODULE_DESCRIPTION("Command line configuration of MTD partitions");
-- 
1.7.1

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/


[PATCH 1/2] mtd: cmdlinepart: Make it into a module

2013-01-15 Thread Lubomir Rintel
All other partitioning schemes can be compiled as modules

Signed-off-by: Lubomir Rintel lkund...@v3.sk
---
 drivers/mtd/Kconfig   |4 ++--
 drivers/mtd/cmdlinepart.c |8 +++-
 2 files changed, 9 insertions(+), 3 deletions(-)

diff --git a/drivers/mtd/Kconfig b/drivers/mtd/Kconfig
index 73fcbbe..4dd3b38 100644
--- a/drivers/mtd/Kconfig
+++ b/drivers/mtd/Kconfig
@@ -74,8 +74,8 @@ config MTD_REDBOOT_PARTS_READONLY
 endif # MTD_REDBOOT_PARTS
 
 config MTD_CMDLINE_PARTS
-   bool Command line partition table parsing
-   depends on MTD = y
+   tristate Command line partition table parsing
+   depends on MTD
---help---
  Allow generic configuration of the MTD partition tables via the kernel
  command line. Multiple flash resources are supported for hardware 
where
diff --git a/drivers/mtd/cmdlinepart.c b/drivers/mtd/cmdlinepart.c
index aed1b8a..a2bb2ea 100644
--- a/drivers/mtd/cmdlinepart.c
+++ b/drivers/mtd/cmdlinepart.c
@@ -70,6 +70,7 @@ struct cmdline_mtd_partition {
 static struct cmdline_mtd_partition *partitions;
 
 /* the command line passed to mtdpart_setup() */
+static char *mtdparts;
 static char *cmdline;
 static int cmdline_parsed;
 
@@ -360,7 +361,7 @@ static int parse_cmdline_partitions(struct mtd_info *master,
  *
  * This function needs to be visible for bootloaders.
  */
-static int mtdpart_setup(char *s)
+static int __init mtdpart_setup(char *s)
 {
cmdline = s;
return 1;
@@ -376,11 +377,16 @@ static struct mtd_part_parser cmdline_parser = {
 
 static int __init cmdline_parser_init(void)
 {
+   if (mtdparts)
+   mtdpart_setup(mtdparts);
return register_mtd_parser(cmdline_parser);
 }
 
 module_init(cmdline_parser_init);
 
+MODULE_PARM_DESC(mtdparts, Partitioning specification);
+module_param(mtdparts, charp, 0);
+
 MODULE_LICENSE(GPL);
 MODULE_AUTHOR(Marius Groeger m...@sysgo.de);
 MODULE_DESCRIPTION(Command line configuration of MTD partitions);
-- 
1.7.1

--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/