Re: [PATCH 1/2] perf script: allow extended console debug output
Em Mon, Oct 22, 2018 at 11:40:33AM +0200, Jiri Olsa escreveu: > On Sun, Oct 21, 2018 at 09:14:23PM +0200, Milian Wolff wrote: > > The script tool isn't using a browser, yet use_browser > > wasn't set explicitly to zero. This in turn lead to confusing > > output such as: > > > > ``` > > $ perf script -vvv ... > > ... > > overlapping maps in /home/milian/foobar (disable tui for more info) > > ... > > ``` > > > > Explicitly set use_browser to 0 now, which gives us the extended > > debug information now in perf script as expected. > > > > Signed-off-by: Milian Wolff > > Cc: Arnaldo Carvalho de Melo > > Acked-by: Jiri Olsa Thanks, applied. - Arnaldo
Re: [PATCH 1/2] perf script: allow extended console debug output
Em Mon, Oct 22, 2018 at 11:40:33AM +0200, Jiri Olsa escreveu: > On Sun, Oct 21, 2018 at 09:14:23PM +0200, Milian Wolff wrote: > > The script tool isn't using a browser, yet use_browser > > wasn't set explicitly to zero. This in turn lead to confusing > > output such as: > > > > ``` > > $ perf script -vvv ... > > ... > > overlapping maps in /home/milian/foobar (disable tui for more info) > > ... > > ``` > > > > Explicitly set use_browser to 0 now, which gives us the extended > > debug information now in perf script as expected. > > > > Signed-off-by: Milian Wolff > > Cc: Arnaldo Carvalho de Melo > > Acked-by: Jiri Olsa Thanks, applied. - Arnaldo
Re: [PATCH 1/2] perf script: allow extended console debug output
On Sun, Oct 21, 2018 at 09:14:23PM +0200, Milian Wolff wrote:
> The script tool isn't using a browser, yet use_browser
> wasn't set explicitly to zero. This in turn lead to confusing
> output such as:
>
> ```
> $ perf script -vvv ...
> ...
> overlapping maps in /home/milian/foobar (disable tui for more info)
> ...
> ```
>
> Explicitly set use_browser to 0 now, which gives us the extended
> debug information now in perf script as expected.
>
> Signed-off-by: Milian Wolff
> Cc: Arnaldo Carvalho de Melo
Acked-by: Jiri Olsa
thanks,
jirka
> ---
> tools/perf/builtin-script.c | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/tools/perf/builtin-script.c b/tools/perf/builtin-script.c
> index 4da5e32b9e03..bd468b90801b 100644
> --- a/tools/perf/builtin-script.c
> +++ b/tools/perf/builtin-script.c
> @@ -3417,8 +3417,10 @@ int cmd_script(int argc, const char **argv)
> exit(-1);
> }
>
> - if (!script_name)
> + if (!script_name) {
> setup_pager();
> + use_browser = 0;
> + }
>
> session = perf_session__new(, false, );
> if (session == NULL)
> --
> 2.19.1
Re: [PATCH 1/2] perf script: allow extended console debug output
On Sun, Oct 21, 2018 at 09:14:23PM +0200, Milian Wolff wrote:
> The script tool isn't using a browser, yet use_browser
> wasn't set explicitly to zero. This in turn lead to confusing
> output such as:
>
> ```
> $ perf script -vvv ...
> ...
> overlapping maps in /home/milian/foobar (disable tui for more info)
> ...
> ```
>
> Explicitly set use_browser to 0 now, which gives us the extended
> debug information now in perf script as expected.
>
> Signed-off-by: Milian Wolff
> Cc: Arnaldo Carvalho de Melo
Acked-by: Jiri Olsa
thanks,
jirka
> ---
> tools/perf/builtin-script.c | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/tools/perf/builtin-script.c b/tools/perf/builtin-script.c
> index 4da5e32b9e03..bd468b90801b 100644
> --- a/tools/perf/builtin-script.c
> +++ b/tools/perf/builtin-script.c
> @@ -3417,8 +3417,10 @@ int cmd_script(int argc, const char **argv)
> exit(-1);
> }
>
> - if (!script_name)
> + if (!script_name) {
> setup_pager();
> + use_browser = 0;
> + }
>
> session = perf_session__new(, false, );
> if (session == NULL)
> --
> 2.19.1
[PATCH 1/2] perf script: allow extended console debug output
The script tool isn't using a browser, yet use_browser
wasn't set explicitly to zero. This in turn lead to confusing
output such as:
```
$ perf script -vvv ...
...
overlapping maps in /home/milian/foobar (disable tui for more info)
...
```
Explicitly set use_browser to 0 now, which gives us the extended
debug information now in perf script as expected.
Signed-off-by: Milian Wolff
Cc: Arnaldo Carvalho de Melo
---
tools/perf/builtin-script.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/tools/perf/builtin-script.c b/tools/perf/builtin-script.c
index 4da5e32b9e03..bd468b90801b 100644
--- a/tools/perf/builtin-script.c
+++ b/tools/perf/builtin-script.c
@@ -3417,8 +3417,10 @@ int cmd_script(int argc, const char **argv)
exit(-1);
}
- if (!script_name)
+ if (!script_name) {
setup_pager();
+ use_browser = 0;
+ }
session = perf_session__new(, false, );
if (session == NULL)
--
2.19.1
[PATCH 1/2] perf script: allow extended console debug output
The script tool isn't using a browser, yet use_browser
wasn't set explicitly to zero. This in turn lead to confusing
output such as:
```
$ perf script -vvv ...
...
overlapping maps in /home/milian/foobar (disable tui for more info)
...
```
Explicitly set use_browser to 0 now, which gives us the extended
debug information now in perf script as expected.
Signed-off-by: Milian Wolff
Cc: Arnaldo Carvalho de Melo
---
tools/perf/builtin-script.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/tools/perf/builtin-script.c b/tools/perf/builtin-script.c
index 4da5e32b9e03..bd468b90801b 100644
--- a/tools/perf/builtin-script.c
+++ b/tools/perf/builtin-script.c
@@ -3417,8 +3417,10 @@ int cmd_script(int argc, const char **argv)
exit(-1);
}
- if (!script_name)
+ if (!script_name) {
setup_pager();
+ use_browser = 0;
+ }
session = perf_session__new(, false, );
if (session == NULL)
--
2.19.1
