[PATCH 1/2] rpmsg: glink: use put_device() if device_register fail

[Arvind Yadav]

if device_register() returned an error! Always use put_device()
to give up the reference initialized. And unregister device for
other return error.

Signed-off-by: Arvind Yadav 
---
 drivers/rpmsg/qcom_glink_smem.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/drivers/rpmsg/qcom_glink_smem.c b/drivers/rpmsg/qcom_glink_smem.c
index 892f2b9..3fa9d43 100644
--- a/drivers/rpmsg/qcom_glink_smem.c
+++ b/drivers/rpmsg/qcom_glink_smem.c
@@ -217,6 +217,7 @@ struct qcom_glink *qcom_glink_smem_register(struct device 
*parent,
ret = device_register(dev);
if (ret) {
pr_err("failed to register glink edge\n");
+   put_device(dev);
return ERR_PTR(ret);
}
 
@@ -299,7 +300,7 @@ struct qcom_glink *qcom_glink_smem_register(struct device 
*parent,
return glink;
 
 err_put_dev:
-   put_device(dev);
+   device_unregister(dev);
 
return ERR_PTR(ret);
 }
-- 
1.9.1

[PATCH 1/2] rpmsg: glink: use put_device() if device_register fail

[Arvind Yadav]

if device_register() returned an error! Always use put_device()
to give up the reference initialized. And unregister device for
other return error.

Signed-off-by: Arvind Yadav 
---
 drivers/rpmsg/qcom_glink_smem.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/drivers/rpmsg/qcom_glink_smem.c b/drivers/rpmsg/qcom_glink_smem.c
index 892f2b9..3fa9d43 100644
--- a/drivers/rpmsg/qcom_glink_smem.c
+++ b/drivers/rpmsg/qcom_glink_smem.c
@@ -217,6 +217,7 @@ struct qcom_glink *qcom_glink_smem_register(struct device 
*parent,
ret = device_register(dev);
if (ret) {
pr_err("failed to register glink edge\n");
+   put_device(dev);
return ERR_PTR(ret);
}
 
@@ -299,7 +300,7 @@ struct qcom_glink *qcom_glink_smem_register(struct device 
*parent,
return glink;
 
 err_put_dev:
-   put_device(dev);
+   device_unregister(dev);
 
return ERR_PTR(ret);
 }
-- 
1.9.1