Re: [PATCH 1/2] video: ssd1307fb: Use gpiod_set_value_cansleep() for reset

2018-09-19 Thread Fabio Estevam
Hi Michal,

On Wed, Sep 19, 2018 at 6:18 AM, Michal Vokáč  wrote:
> The reset signal can be produced by GPIO expander that can sleep.
> In that case the probe function fails. Allow using GPIO expanders for
> the reset signal by using the non-atomic gpiod_set_value_cansleep()
> function.
>
> Signed-off-by: Michal Vokáč 

Reviewed-by: Fabio Estevam 


[PATCH 1/2] video: ssd1307fb: Use gpiod_set_value_cansleep() for reset

2018-09-19 Thread Michal Vokáč
The reset signal can be produced by GPIO expander that can sleep.
In that case the probe function fails. Allow using GPIO expanders for
the reset signal by using the non-atomic gpiod_set_value_cansleep()
function.

Signed-off-by: Michal Vokáč 
---
 drivers/video/fbdev/ssd1307fb.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/video/fbdev/ssd1307fb.c b/drivers/video/fbdev/ssd1307fb.c
index ba66c02..e7ae135 100644
--- a/drivers/video/fbdev/ssd1307fb.c
+++ b/drivers/video/fbdev/ssd1307fb.c
@@ -728,9 +728,9 @@ static int ssd1307fb_probe(struct i2c_client *client,
 
if (par->reset) {
/* Reset the screen */
-   gpiod_set_value(par->reset, 0);
+   gpiod_set_value_cansleep(par->reset, 0);
udelay(4);
-   gpiod_set_value(par->reset, 1);
+   gpiod_set_value_cansleep(par->reset, 1);
udelay(4);
}
 
-- 
2.1.4