Re: [PATCH 1/3] MODSIGN: Fix comparison erros in scripts/sign-file

[Rusty Russell]

Michal Marek  writes:

> Signed-off-by: Michal Marek 
> ---
>  scripts/sign-file |6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/scripts/sign-file b/scripts/sign-file
> index 87ca59d..974a20b 100755
> --- a/scripts/sign-file
> +++ b/scripts/sign-file
> @@ -156,12 +156,12 @@ sub asn1_extract($$@)
>  
>   if ($l == 0x1) {
>   $len = unpack("C", substr(${$cursor->[2]}, $cursor->[0], 1));
> - } elsif ($l = 0x2) {
> + } elsif ($l == 0x2) {
>   $len = unpack("n", substr(${$cursor->[2]}, $cursor->[0], 2));
> - } elsif ($l = 0x3) {
> + } elsif ($l == 0x3) {
>   $len = unpack("C", substr(${$cursor->[2]}, $cursor->[0], 1)) << 16;
>   $len = unpack("n", substr(${$cursor->[2]}, $cursor->[0] + 1, 2));
> - } elsif ($l = 0x4) {
> + } elsif ($l == 0x4) {
>   $len = unpack("N", substr(${$cursor->[2]}, $cursor->[0], 4));
>   } else {
>   die $x509, ": ", $cursor->[0], ": ASN.1 element too long (", $l, 
> ")\n";

This was already applied to Linus' tree as 

commit 916492b1e1a186260951831c53a53d8a448dc026
Author: Chun-Yi Lee 
Date:   Wed Nov 21 11:26:09 2012 +

Thanks,
Rusty.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Re: [PATCH 1/3] MODSIGN: Fix comparison erros in scripts/sign-file

[David Howells]

Michal Marek  wrote:

> Signed-off-by: Michal Marek 

If only perl gave you warnings for this as gcc does...

Acked-by: David Howells 
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[PATCH 1/3] MODSIGN: Fix comparison erros in scripts/sign-file

[Michal Marek]

Signed-off-by: Michal Marek 
---
 scripts/sign-file |6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/scripts/sign-file b/scripts/sign-file
index 87ca59d..974a20b 100755
--- a/scripts/sign-file
+++ b/scripts/sign-file
@@ -156,12 +156,12 @@ sub asn1_extract($$@)
 
if ($l == 0x1) {
$len = unpack("C", substr(${$cursor->[2]}, $cursor->[0], 1));
-   } elsif ($l = 0x2) {
+   } elsif ($l == 0x2) {
$len = unpack("n", substr(${$cursor->[2]}, $cursor->[0], 2));
-   } elsif ($l = 0x3) {
+   } elsif ($l == 0x3) {
$len = unpack("C", substr(${$cursor->[2]}, $cursor->[0], 1)) << 16;
$len = unpack("n", substr(${$cursor->[2]}, $cursor->[0] + 1, 2));
-   } elsif ($l = 0x4) {
+   } elsif ($l == 0x4) {
$len = unpack("N", substr(${$cursor->[2]}, $cursor->[0], 4));
} else {
die $x509, ": ", $cursor->[0], ": ASN.1 element too long (", $l, 
")\n";
-- 
1.7.10.4

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/