Re: [PATCH 1/3] lightnvm: do not free unused metadata on rrpc

[Matias Bjørling]

On 04/27/2016 07:28 PM, Javier González wrote:

rrpc does not save any metadata on a given request. Thus, do not attempt
to free the metadata dma region.

Signed-off-by: Javier González 
---
  drivers/lightnvm/rrpc.c | 2 --
  1 file changed, 2 deletions(-)

diff --git a/drivers/lightnvm/rrpc.c b/drivers/lightnvm/rrpc.c
index c7fef71..ffcfee6 100644
--- a/drivers/lightnvm/rrpc.c
+++ b/drivers/lightnvm/rrpc.c
@@ -711,8 +711,6 @@ static void rrpc_end_io(struct nvm_rq *rqd)

if (npages > 1)
nvm_dev_dma_free(rrpc->dev, rqd->ppa_list, rqd->dma_ppa_list);
-   if (rqd->metadata)
-   nvm_dev_dma_free(rrpc->dev, rqd->metadata, rqd->dma_metadata);

mempool_free(rqd, rrpc->rq_pool);
  }



Thanks Javier. Applied for 4.7.

Re: [PATCH 1/3] lightnvm: do not free unused metadata on rrpc

[Matias Bjørling]

On 04/27/2016 07:28 PM, Javier González wrote:

rrpc does not save any metadata on a given request. Thus, do not attempt
to free the metadata dma region.

Signed-off-by: Javier González 
---
  drivers/lightnvm/rrpc.c | 2 --
  1 file changed, 2 deletions(-)

diff --git a/drivers/lightnvm/rrpc.c b/drivers/lightnvm/rrpc.c
index c7fef71..ffcfee6 100644
--- a/drivers/lightnvm/rrpc.c
+++ b/drivers/lightnvm/rrpc.c
@@ -711,8 +711,6 @@ static void rrpc_end_io(struct nvm_rq *rqd)

if (npages > 1)
nvm_dev_dma_free(rrpc->dev, rqd->ppa_list, rqd->dma_ppa_list);
-   if (rqd->metadata)
-   nvm_dev_dma_free(rrpc->dev, rqd->metadata, rqd->dma_metadata);

mempool_free(rqd, rrpc->rq_pool);
  }



Thanks Javier. Applied for 4.7.

Re: [PATCH 1/3] lightnvm: do not free unused metadata on rrpc

[Matias Bjørling]

On 04/27/2016 07:28 PM, Javier González wrote:

rrpc does not save any metadata on a given request. Thus, do not attempt
to free the metadata dma region.

Signed-off-by: Javier González 
---
  drivers/lightnvm/rrpc.c | 2 --
  1 file changed, 2 deletions(-)

diff --git a/drivers/lightnvm/rrpc.c b/drivers/lightnvm/rrpc.c
index c7fef71..ffcfee6 100644
--- a/drivers/lightnvm/rrpc.c
+++ b/drivers/lightnvm/rrpc.c
@@ -711,8 +711,6 @@ static void rrpc_end_io(struct nvm_rq *rqd)

if (npages > 1)
nvm_dev_dma_free(rrpc->dev, rqd->ppa_list, rqd->dma_ppa_list);
-   if (rqd->metadata)
-   nvm_dev_dma_free(rrpc->dev, rqd->metadata, rqd->dma_metadata);

mempool_free(rqd, rrpc->rq_pool);
  }



Thanks. Applied for 4.7.

Re: [PATCH 1/3] lightnvm: do not free unused metadata on rrpc

[Matias Bjørling]

On 04/27/2016 07:28 PM, Javier González wrote:

rrpc does not save any metadata on a given request. Thus, do not attempt
to free the metadata dma region.

Signed-off-by: Javier González 
---
  drivers/lightnvm/rrpc.c | 2 --
  1 file changed, 2 deletions(-)

diff --git a/drivers/lightnvm/rrpc.c b/drivers/lightnvm/rrpc.c
index c7fef71..ffcfee6 100644
--- a/drivers/lightnvm/rrpc.c
+++ b/drivers/lightnvm/rrpc.c
@@ -711,8 +711,6 @@ static void rrpc_end_io(struct nvm_rq *rqd)

if (npages > 1)
nvm_dev_dma_free(rrpc->dev, rqd->ppa_list, rqd->dma_ppa_list);
-   if (rqd->metadata)
-   nvm_dev_dma_free(rrpc->dev, rqd->metadata, rqd->dma_metadata);

mempool_free(rqd, rrpc->rq_pool);
  }



Thanks. Applied for 4.7.

[PATCH 1/3] lightnvm: do not free unused metadata on rrpc

[Javier González]

rrpc does not save any metadata on a given request. Thus, do not attempt
to free the metadata dma region.

Signed-off-by: Javier González 
---
 drivers/lightnvm/rrpc.c | 2 --
 1 file changed, 2 deletions(-)

diff --git a/drivers/lightnvm/rrpc.c b/drivers/lightnvm/rrpc.c
index c7fef71..ffcfee6 100644
--- a/drivers/lightnvm/rrpc.c
+++ b/drivers/lightnvm/rrpc.c
@@ -711,8 +711,6 @@ static void rrpc_end_io(struct nvm_rq *rqd)
 
if (npages > 1)
nvm_dev_dma_free(rrpc->dev, rqd->ppa_list, rqd->dma_ppa_list);
-   if (rqd->metadata)
-   nvm_dev_dma_free(rrpc->dev, rqd->metadata, rqd->dma_metadata);
 
mempool_free(rqd, rrpc->rq_pool);
 }
-- 
2.5.0

[PATCH 1/3] lightnvm: do not free unused metadata on rrpc

[Javier González]

rrpc does not save any metadata on a given request. Thus, do not attempt
to free the metadata dma region.

Signed-off-by: Javier González 
---
 drivers/lightnvm/rrpc.c | 2 --
 1 file changed, 2 deletions(-)

diff --git a/drivers/lightnvm/rrpc.c b/drivers/lightnvm/rrpc.c
index c7fef71..ffcfee6 100644
--- a/drivers/lightnvm/rrpc.c
+++ b/drivers/lightnvm/rrpc.c
@@ -711,8 +711,6 @@ static void rrpc_end_io(struct nvm_rq *rqd)
 
if (npages > 1)
nvm_dev_dma_free(rrpc->dev, rqd->ppa_list, rqd->dma_ppa_list);
-   if (rqd->metadata)
-   nvm_dev_dma_free(rrpc->dev, rqd->metadata, rqd->dma_metadata);
 
mempool_free(rqd, rrpc->rq_pool);
 }
-- 
2.5.0