Re: [PATCH 1/3] regulator: max8907: Fix using wrong dev argument for calling of_regulator_match
On Fri, Jan 25, 2013 at 10:20:29AM +0800, Axel Lin wrote: > The dev parameter is the device requesting the data. > In this case it should be >dev rather than pdev->dev.parent. Applied all, thanks. signature.asc Description: Digital signature
Re: [PATCH 1/3] regulator: max8907: Fix using wrong dev argument for calling of_regulator_match
On Fri, Jan 25, 2013 at 10:20:29AM +0800, Axel Lin wrote: The dev parameter is the device requesting the data. In this case it should be pdev-dev rather than pdev-dev.parent. Applied all, thanks. signature.asc Description: Digital signature
Re: [PATCH 1/3] regulator: max8907: Fix using wrong dev argument for calling of_regulator_match
On 01/24/2013 06:20 PM, Axel Lin wrote: > The dev parameter is the device requesting the data. > In this case it should be >dev rather than pdev->dev.parent. > > The dev parameter is used to call devm_kzalloc in > of_get_regulator_init_data(), > which means this fixes a memory leak because the memory is allocated every > time > probe() is called, thus it should be freed when this driver is unloaded. Reviewed-by: Stephen Warren -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
[PATCH 1/3] regulator: max8907: Fix using wrong dev argument for calling of_regulator_match
The dev parameter is the device requesting the data.
In this case it should be >dev rather than pdev->dev.parent.
The dev parameter is used to call devm_kzalloc in of_get_regulator_init_data(),
which means this fixes a memory leak because the memory is allocated every time
probe() is called, thus it should be freed when this driver is unloaded.
Signed-off-by: Axel Lin
---
drivers/regulator/max8907-regulator.c |3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/regulator/max8907-regulator.c
b/drivers/regulator/max8907-regulator.c
index d1a7751..d40cf7f 100644
--- a/drivers/regulator/max8907-regulator.c
+++ b/drivers/regulator/max8907-regulator.c
@@ -237,8 +237,7 @@ static int max8907_regulator_parse_dt(struct
platform_device *pdev)
return -EINVAL;
}
- ret = of_regulator_match(pdev->dev.parent, regulators,
-max8907_matches,
+ ret = of_regulator_match(>dev, regulators, max8907_matches,
ARRAY_SIZE(max8907_matches));
if (ret < 0) {
dev_err(>dev, "Error parsing regulator init data: %d\n",
--
1.7.9.5
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
[PATCH 1/3] regulator: max8907: Fix using wrong dev argument for calling of_regulator_match
The dev parameter is the device requesting the data.
In this case it should be pdev-dev rather than pdev-dev.parent.
The dev parameter is used to call devm_kzalloc in of_get_regulator_init_data(),
which means this fixes a memory leak because the memory is allocated every time
probe() is called, thus it should be freed when this driver is unloaded.
Signed-off-by: Axel Lin axel@ingics.com
---
drivers/regulator/max8907-regulator.c |3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/regulator/max8907-regulator.c
b/drivers/regulator/max8907-regulator.c
index d1a7751..d40cf7f 100644
--- a/drivers/regulator/max8907-regulator.c
+++ b/drivers/regulator/max8907-regulator.c
@@ -237,8 +237,7 @@ static int max8907_regulator_parse_dt(struct
platform_device *pdev)
return -EINVAL;
}
- ret = of_regulator_match(pdev-dev.parent, regulators,
-max8907_matches,
+ ret = of_regulator_match(pdev-dev, regulators, max8907_matches,
ARRAY_SIZE(max8907_matches));
if (ret 0) {
dev_err(pdev-dev, Error parsing regulator init data: %d\n,
--
1.7.9.5
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH 1/3] regulator: max8907: Fix using wrong dev argument for calling of_regulator_match
On 01/24/2013 06:20 PM, Axel Lin wrote: The dev parameter is the device requesting the data. In this case it should be pdev-dev rather than pdev-dev.parent. The dev parameter is used to call devm_kzalloc in of_get_regulator_init_data(), which means this fixes a memory leak because the memory is allocated every time probe() is called, thus it should be freed when this driver is unloaded. Reviewed-by: Stephen Warren swar...@nvidia.com -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
