Re: [PATCH 1/3] watchdog: cadence: Simplify with dev_err_probe()

2020-10-02 Thread Guenter Roeck 
On Fri, Oct 02, 2020 at 06:31:24PM +0200, Krzysztof Kozlowski wrote:
> On Tue, Sep 01, 2020 at 08:49:52AM -0700, Guenter Roeck wrote:
> > On Tue, Sep 01, 2020 at 05:31:39PM +0200, Krzysztof Kozlowski wrote:
> > > Common pattern of handling deferred probe can be simplified with
> > > dev_err_probe().  Less code and the error value gets printed.
> > > 
> > > Signed-off-by: Krzysztof Kozlowski 
> > 
> > Reviewed-by: Guenter Roeck 
> 
> Thanks for the review. Who could pick up these patches?
> 

They are queued up in my watchdog-next branch, and Wim usually
picks up patches from there.

Guenter

Re: [PATCH 1/3] watchdog: cadence: Simplify with dev_err_probe()

2020-10-02 Thread Krzysztof Kozlowski 
On Tue, Sep 01, 2020 at 08:49:52AM -0700, Guenter Roeck wrote:
> On Tue, Sep 01, 2020 at 05:31:39PM +0200, Krzysztof Kozlowski wrote:
> > Common pattern of handling deferred probe can be simplified with
> > dev_err_probe().  Less code and the error value gets printed.
> > 
> > Signed-off-by: Krzysztof Kozlowski 
> 
> Reviewed-by: Guenter Roeck 

Thanks for the review. Who could pick up these patches?

Best regards,
Krzysztof

Re: [PATCH 1/3] watchdog: cadence: Simplify with dev_err_probe()

2020-09-01 Thread Guenter Roeck 
On Tue, Sep 01, 2020 at 05:31:39PM +0200, Krzysztof Kozlowski wrote:
> Common pattern of handling deferred probe can be simplified with
> dev_err_probe().  Less code and the error value gets printed.
> 
> Signed-off-by: Krzysztof Kozlowski 

Hmm, I had replied to this but I don't see it on patchwork.
Trying again.

Reviewed-by: Guenter Roeck 

Guenter

> ---
>  drivers/watchdog/cadence_wdt.c | 9 +++--
>  1 file changed, 3 insertions(+), 6 deletions(-)
> 
> diff --git a/drivers/watchdog/cadence_wdt.c b/drivers/watchdog/cadence_wdt.c
> index 672b184da875..bc99e9164930 100644
> --- a/drivers/watchdog/cadence_wdt.c
> +++ b/drivers/watchdog/cadence_wdt.c
> @@ -334,12 +334,9 @@ static int cdns_wdt_probe(struct platform_device *pdev)
>   watchdog_set_drvdata(cdns_wdt_device, wdt);
>  
>   wdt->clk = devm_clk_get(dev, NULL);
> - if (IS_ERR(wdt->clk)) {
> - ret = PTR_ERR(wdt->clk);
> - if (ret != -EPROBE_DEFER)
> - dev_err(dev, "input clock not found\n");
> - return ret;
> - }
> + if (IS_ERR(wdt->clk))
> + return dev_err_probe(dev, PTR_ERR(wdt->clk),
> +  "input clock not found\n");
>  
>   ret = clk_prepare_enable(wdt->clk);
>   if (ret) {
> -- 
> 2.17.1
>

[PATCH 1/3] watchdog: cadence: Simplify with dev_err_probe()

2020-09-01 Thread Krzysztof Kozlowski 
Common pattern of handling deferred probe can be simplified with
dev_err_probe().  Less code and the error value gets printed.

Signed-off-by: Krzysztof Kozlowski 
---
 drivers/watchdog/cadence_wdt.c | 9 +++--
 1 file changed, 3 insertions(+), 6 deletions(-)

diff --git a/drivers/watchdog/cadence_wdt.c b/drivers/watchdog/cadence_wdt.c
index 672b184da875..bc99e9164930 100644
--- a/drivers/watchdog/cadence_wdt.c
+++ b/drivers/watchdog/cadence_wdt.c
@@ -334,12 +334,9 @@ static int cdns_wdt_probe(struct platform_device *pdev)
watchdog_set_drvdata(cdns_wdt_device, wdt);
 
wdt->clk = devm_clk_get(dev, NULL);
-   if (IS_ERR(wdt->clk)) {
-   ret = PTR_ERR(wdt->clk);
-   if (ret != -EPROBE_DEFER)
-   dev_err(dev, "input clock not found\n");
-   return ret;
-   }
+   if (IS_ERR(wdt->clk))
+   return dev_err_probe(dev, PTR_ERR(wdt->clk),
+"input clock not found\n");
 
ret = clk_prepare_enable(wdt->clk);
if (ret) {
-- 
2.17.1

Re: [PATCH 1/3] watchdog: cadence: Simplify with dev_err_probe()

2020-09-01 Thread Guenter Roeck 
On Tue, Sep 01, 2020 at 05:31:39PM +0200, Krzysztof Kozlowski wrote:
> Common pattern of handling deferred probe can be simplified with
> dev_err_probe().  Less code and the error value gets printed.
> 
> Signed-off-by: Krzysztof Kozlowski 

Reviewed-by: Guenter Roeck 

> ---
>  drivers/watchdog/cadence_wdt.c | 9 +++--
>  1 file changed, 3 insertions(+), 6 deletions(-)
> 
> diff --git a/drivers/watchdog/cadence_wdt.c b/drivers/watchdog/cadence_wdt.c
> index 672b184da875..bc99e9164930 100644
> --- a/drivers/watchdog/cadence_wdt.c
> +++ b/drivers/watchdog/cadence_wdt.c
> @@ -334,12 +334,9 @@ static int cdns_wdt_probe(struct platform_device *pdev)
>   watchdog_set_drvdata(cdns_wdt_device, wdt);
>  
>   wdt->clk = devm_clk_get(dev, NULL);
> - if (IS_ERR(wdt->clk)) {
> - ret = PTR_ERR(wdt->clk);
> - if (ret != -EPROBE_DEFER)
> - dev_err(dev, "input clock not found\n");
> - return ret;
> - }
> + if (IS_ERR(wdt->clk))
> + return dev_err_probe(dev, PTR_ERR(wdt->clk),
> +  "input clock not found\n");
>  
>   ret = clk_prepare_enable(wdt->clk);
>   if (ret) {
> -- 
> 2.17.1
>