Re: [PATCH 1/4] ARM: dt: mvebu: ix4-300d: remove whole flash partition
Hi Sebastian and Andrew, On sam., nov. 28 2015, Andrew Lunn wrote: >>On Sat, Nov 28, 2015 at 12:14:05PM +0100, Sebastian Hesselbarth wrote: >> Current NAND node has an additional flash partition for the whole >> flash overlapping with real partitions. Remove this partition as >> the whole flash is already represented by the NAND device itself. >> >> Signed-off-by: Sebastian Hesselbarth > > Given Benoit comment > > Acked-by: Andrew Lunn Applied on mvebu/dt Thanks, Gregory > > Andrew -- Gregory Clement, Free Electrons Kernel, drivers, real-time and embedded Linux development, consulting, training and support. http://free-electrons.com -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH 1/4] ARM: dt: mvebu: ix4-300d: remove whole flash partition
>On Sat, Nov 28, 2015 at 12:14:05PM +0100, Sebastian Hesselbarth wrote: > Current NAND node has an additional flash partition for the whole > flash overlapping with real partitions. Remove this partition as > the whole flash is already represented by the NAND device itself. > > Signed-off-by: Sebastian Hesselbarth Given Benoit comment Acked-by: Andrew Lunn Andrew -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH 1/4] ARM: dt: mvebu: ix4-300d: remove whole flash partition
>From mobile > Le 28 nov. 2015 à 18:38, Sebastian Hesselbarth > a écrit : > >> On 28.11.2015 17:52, Andrew Lunn wrote: >>> On Sat, Nov 28, 2015 at 12:14:05PM +0100, Sebastian Hesselbarth wrote: >>> Current NAND node has an additional flash partition for the whole >>> flash overlapping with real partitions. Remove this partition as >>> the whole flash is already represented by the NAND device itself. >> >> If i remember correctly, we discussed this when the contribution was >> made. I think the stock firmware might use this for applying updates. >> Maybe Benoit can comment? > > Yes, please. >From my memory since I'm not running the stock firmware it uses the MTD device directly. This is safe to remove. I was not very contort able with this flash dts part it was copied over from a netgear mevbu device ... > >> If so, removing this will break compatibility with stock firmware. Do >> we want to do that? There are a few other mvebu dts files with a >> partition spanning the whole flash. Should we remove them as well? > > Well, there is already a mtd device that spans the whole flash so > what is the purpose of another "partition" that isn't a part but > all of the device? Actually, I doubt that a FW update will wipe > the flash as a whole, i.e. including boot loader, boot env, user > config. > > Anyway, let's see if Benoit can shed some light on this. > > FWIW, neither single partitions nor a combined partitions node > should be a direct sub-node of the _controller_ but a NAND > _device_ node instead. Luckily, multi-device systems are not that > common, so I guess we wait with it until such a system pops up for > testing. > > Sebastian > > -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH 1/4] ARM: dt: mvebu: ix4-300d: remove whole flash partition
On 28.11.2015 17:52, Andrew Lunn wrote: > On Sat, Nov 28, 2015 at 12:14:05PM +0100, Sebastian Hesselbarth wrote: >> Current NAND node has an additional flash partition for the whole >> flash overlapping with real partitions. Remove this partition as >> the whole flash is already represented by the NAND device itself. > > If i remember correctly, we discussed this when the contribution was > made. I think the stock firmware might use this for applying updates. > Maybe Benoit can comment? Yes, please. > If so, removing this will break compatibility with stock firmware. Do > we want to do that? There are a few other mvebu dts files with a > partition spanning the whole flash. Should we remove them as well? Well, there is already a mtd device that spans the whole flash so what is the purpose of another "partition" that isn't a part but all of the device? Actually, I doubt that a FW update will wipe the flash as a whole, i.e. including boot loader, boot env, user config. Anyway, let's see if Benoit can shed some light on this. FWIW, neither single partitions nor a combined partitions node should be a direct sub-node of the _controller_ but a NAND _device_ node instead. Luckily, multi-device systems are not that common, so I guess we wait with it until such a system pops up for testing. Sebastian -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH 1/4] ARM: dt: mvebu: ix4-300d: remove whole flash partition
On Sat, Nov 28, 2015 at 12:14:05PM +0100, Sebastian Hesselbarth wrote: > Current NAND node has an additional flash partition for the whole > flash overlapping with real partitions. Remove this partition as > the whole flash is already represented by the NAND device itself. If i remember correctly, we discussed this when the contribution was made. I think the stock firmware might use this for applying updates. Maybe Benoit can comment? If so, removing this will break compatibility with stock firmware. Do we want to do that? There are a few other mvebu dts files with a partition spanning the whole flash. Should we remove them as well? Andrew -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
[PATCH 1/4] ARM: dt: mvebu: ix4-300d: remove whole flash partition
Current NAND node has an additional flash partition for the whole
flash overlapping with real partitions. Remove this partition as
the whole flash is already represented by the NAND device itself.
Signed-off-by: Sebastian Hesselbarth
---
Cc: Jason Cooper
Cc: Andrew Lunn
Cc: Gregory Clement
Cc: Rob Herring
Cc: Pawel Moll
Cc: Mark Rutland
Cc: Ian Campbell
Cc: Kumar Gala
Cc: Russell King
Cc: Benoit Masson
Cc: linux-arm-ker...@lists.infradead.org
Cc: devicet...@vger.kernel.org
Cc: linux-kernel@vger.kernel.org
---
arch/arm/boot/dts/armada-xp-lenovo-ix4-300d.dts | 5 -
1 file changed, 5 deletions(-)
diff --git a/arch/arm/boot/dts/armada-xp-lenovo-ix4-300d.dts
b/arch/arm/boot/dts/armada-xp-lenovo-ix4-300d.dts
index 58b500873bfd..30a0a6eac645 100644
--- a/arch/arm/boot/dts/armada-xp-lenovo-ix4-300d.dts
+++ b/arch/arm/boot/dts/armada-xp-lenovo-ix4-300d.dts
@@ -183,11 +183,6 @@
label = "boot";
reg = <0xE0 0x3F20>;
};
-
- partition@flash {
- label = "flash";
- reg = <0x0 0x4000>;
- };
};
};
};
--
2.1.4
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
