Re: [PATCH 1/4] Input: db9 - use setup_timer
On Sun, Apr 09, 2017 at 09:39:35AM +0800, Geliang Tang wrote: > Use setup_timer() instead of init_timer() to simplify the code. > > Signed-off-by: Geliang TangApplied the lot, thank you. > --- > drivers/input/joystick/db9.c | 4 +--- > 1 file changed, 1 insertion(+), 3 deletions(-) > > diff --git a/drivers/input/joystick/db9.c b/drivers/input/joystick/db9.c > index da32609..f4ad83e 100644 > --- a/drivers/input/joystick/db9.c > +++ b/drivers/input/joystick/db9.c > @@ -609,9 +609,7 @@ static void db9_attach(struct parport *pp) > db9->pd = pd; > db9->mode = mode; > db9->parportno = pp->number; > - init_timer(>timer); > - db9->timer.data = (long) db9; > - db9->timer.function = db9_timer; > + setup_timer(>timer, db9_timer, (long)db9); > > for (i = 0; i < (min(db9_mode->n_pads, DB9_MAX_DEVICES)); i++) { > > -- > 2.9.3 > -- Dmitry
Re: [PATCH 1/4] Input: db9 - use setup_timer
On Sun, Apr 09, 2017 at 09:39:35AM +0800, Geliang Tang wrote: > Use setup_timer() instead of init_timer() to simplify the code. > > Signed-off-by: Geliang Tang Applied the lot, thank you. > --- > drivers/input/joystick/db9.c | 4 +--- > 1 file changed, 1 insertion(+), 3 deletions(-) > > diff --git a/drivers/input/joystick/db9.c b/drivers/input/joystick/db9.c > index da32609..f4ad83e 100644 > --- a/drivers/input/joystick/db9.c > +++ b/drivers/input/joystick/db9.c > @@ -609,9 +609,7 @@ static void db9_attach(struct parport *pp) > db9->pd = pd; > db9->mode = mode; > db9->parportno = pp->number; > - init_timer(>timer); > - db9->timer.data = (long) db9; > - db9->timer.function = db9_timer; > + setup_timer(>timer, db9_timer, (long)db9); > > for (i = 0; i < (min(db9_mode->n_pads, DB9_MAX_DEVICES)); i++) { > > -- > 2.9.3 > -- Dmitry
[PATCH 1/4] Input: db9 - use setup_timer
Use setup_timer() instead of init_timer() to simplify the code. Signed-off-by: Geliang Tang--- drivers/input/joystick/db9.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/drivers/input/joystick/db9.c b/drivers/input/joystick/db9.c index da32609..f4ad83e 100644 --- a/drivers/input/joystick/db9.c +++ b/drivers/input/joystick/db9.c @@ -609,9 +609,7 @@ static void db9_attach(struct parport *pp) db9->pd = pd; db9->mode = mode; db9->parportno = pp->number; - init_timer(>timer); - db9->timer.data = (long) db9; - db9->timer.function = db9_timer; + setup_timer(>timer, db9_timer, (long)db9); for (i = 0; i < (min(db9_mode->n_pads, DB9_MAX_DEVICES)); i++) { -- 2.9.3
[PATCH 1/4] Input: db9 - use setup_timer
Use setup_timer() instead of init_timer() to simplify the code. Signed-off-by: Geliang Tang --- drivers/input/joystick/db9.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/drivers/input/joystick/db9.c b/drivers/input/joystick/db9.c index da32609..f4ad83e 100644 --- a/drivers/input/joystick/db9.c +++ b/drivers/input/joystick/db9.c @@ -609,9 +609,7 @@ static void db9_attach(struct parport *pp) db9->pd = pd; db9->mode = mode; db9->parportno = pp->number; - init_timer(>timer); - db9->timer.data = (long) db9; - db9->timer.function = db9_timer; + setup_timer(>timer, db9_timer, (long)db9); for (i = 0; i < (min(db9_mode->n_pads, DB9_MAX_DEVICES)); i++) { -- 2.9.3