Re: [PATCH 1/4] dma: add dma_flags_set_dmaflush() to dma interface

2007-09-27 Thread akepner 
On Tue, Sep 25, 2007 at 10:13:33PM -0700, Randy Dunlap wrote:
> On Tue, 25 Sep 2007 17:00:57 -0700 [EMAIL PROTECTED] wrote:
> ..
> 1.  Function signature should be on one line if possible (and it is).
> Aw crud, I looked at dma-mapping.h and it uses this format sometimes.
> Well, it's undesirable, so please don't propagate it.
> 
> 2.  No parens on return: it's not a function.
> 
> static inline int dma_flags_set_dmaflush(int dir)
> {
>   return dir;
> }
> 
> 
> Similar comments for patch 2/4: sn-ia64.
> 

Both fixed in next version. Thanks, Randy.

-- 
Arthur

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Re: [PATCH 1/4] dma: add dma_flags_set_dmaflush() to dma interface

2007-09-27 Thread akepner 
On Tue, Sep 25, 2007 at 10:13:33PM -0700, Randy Dunlap wrote:
 On Tue, 25 Sep 2007 17:00:57 -0700 [EMAIL PROTECTED] wrote:
 ..
 1.  Function signature should be on one line if possible (and it is).
 Aw crud, I looked at dma-mapping.h and it uses this format sometimes.
 Well, it's undesirable, so please don't propagate it.
 
 2.  No parens on return: it's not a function.
 
 static inline int dma_flags_set_dmaflush(int dir)
 {
   return dir;
 }
 
 
 Similar comments for patch 2/4: sn-ia64.
 

Both fixed in next version. Thanks, Randy.

-- 
Arthur

-
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to [EMAIL PROTECTED]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Re: [PATCH 1/4] dma: add dma_flags_set_dmaflush() to dma interface

2007-09-25 Thread Randy Dunlap 
On Tue, 25 Sep 2007 17:00:57 -0700 [EMAIL PROTECTED] wrote:

[adding James Bottomley to cc: since I think he's interested in
all of these patches]


> Introduce the dma_flags_set_dmaflush() interface and give it
> a default no-op implementation.
> 
> Signed-off-by: Arthur Kepner <[EMAIL PROTECTED]>
> -- 
> 
>  dma-mapping.h |7 +++
>  1 file changed, 7 insertions(+)
> 
> diff --git a/include/linux/dma-mapping.h b/include/linux/dma-mapping.h
> index 2dc21cb..a0f27b9 100644
> --- a/include/linux/dma-mapping.h
> +++ b/include/linux/dma-mapping.h
> @@ -99,4 +99,11 @@ static inline void dmam_release_declared_memory(struct 
> device *dev)
>  }
>  #endif /* ARCH_HAS_DMA_DECLARE_COHERENT_MEMORY */
>  
> +#ifndef ARCH_CAN_REORDER_DMA
> +static inline int
> +dma_flags_set_dmaflush(int dir) {
> + return (dir);
> +}
> +#endif /* ARCH_CAN_REORDER_DMA */
> +
>  #endif


1.  Function signature should be on one line if possible (and it is).
Aw crud, I looked at dma-mapping.h and it uses this format sometimes.
Well, it's undesirable, so please don't propagate it.

2.  No parens on return: it's not a function.

static inline int dma_flags_set_dmaflush(int dir)
{
return dir;
}


Similar comments for patch 2/4: sn-ia64.

---
~Randy
Phaedrus says that Quality is about caring.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[PATCH 1/4] dma: add dma_flags_set_dmaflush() to dma interface

2007-09-25 Thread akepner 

Introduce the dma_flags_set_dmaflush() interface and give it
a default no-op implementation.

Signed-off-by: Arthur Kepner <[EMAIL PROTECTED]>
-- 

 dma-mapping.h |7 +++
 1 file changed, 7 insertions(+)

diff --git a/include/linux/dma-mapping.h b/include/linux/dma-mapping.h
index 2dc21cb..a0f27b9 100644
--- a/include/linux/dma-mapping.h
+++ b/include/linux/dma-mapping.h
@@ -99,4 +99,11 @@ static inline void dmam_release_declared_memory(struct 
device *dev)
 }
 #endif /* ARCH_HAS_DMA_DECLARE_COHERENT_MEMORY */
 
+#ifndef ARCH_CAN_REORDER_DMA
+static inline int
+dma_flags_set_dmaflush(int dir) {
+   return (dir);
+}
+#endif /* ARCH_CAN_REORDER_DMA */
+
 #endif
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[PATCH 1/4] dma: add dma_flags_set_dmaflush() to dma interface

2007-09-25 Thread akepner 

Introduce the dma_flags_set_dmaflush() interface and give it
a default no-op implementation.

Signed-off-by: Arthur Kepner [EMAIL PROTECTED]
-- 

 dma-mapping.h |7 +++
 1 file changed, 7 insertions(+)

diff --git a/include/linux/dma-mapping.h b/include/linux/dma-mapping.h
index 2dc21cb..a0f27b9 100644
--- a/include/linux/dma-mapping.h
+++ b/include/linux/dma-mapping.h
@@ -99,4 +99,11 @@ static inline void dmam_release_declared_memory(struct 
device *dev)
 }
 #endif /* ARCH_HAS_DMA_DECLARE_COHERENT_MEMORY */
 
+#ifndef ARCH_CAN_REORDER_DMA
+static inline int
+dma_flags_set_dmaflush(int dir) {
+   return (dir);
+}
+#endif /* ARCH_CAN_REORDER_DMA */
+
 #endif
-
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to [EMAIL PROTECTED]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Re: [PATCH 1/4] dma: add dma_flags_set_dmaflush() to dma interface

2007-09-25 Thread Randy Dunlap 
On Tue, 25 Sep 2007 17:00:57 -0700 [EMAIL PROTECTED] wrote:

[adding James Bottomley to cc: since I think he's interested in
all of these patches]


 Introduce the dma_flags_set_dmaflush() interface and give it
 a default no-op implementation.
 
 Signed-off-by: Arthur Kepner [EMAIL PROTECTED]
 -- 
 
  dma-mapping.h |7 +++
  1 file changed, 7 insertions(+)
 
 diff --git a/include/linux/dma-mapping.h b/include/linux/dma-mapping.h
 index 2dc21cb..a0f27b9 100644
 --- a/include/linux/dma-mapping.h
 +++ b/include/linux/dma-mapping.h
 @@ -99,4 +99,11 @@ static inline void dmam_release_declared_memory(struct 
 device *dev)
  }
  #endif /* ARCH_HAS_DMA_DECLARE_COHERENT_MEMORY */
  
 +#ifndef ARCH_CAN_REORDER_DMA
 +static inline int
 +dma_flags_set_dmaflush(int dir) {
 + return (dir);
 +}
 +#endif /* ARCH_CAN_REORDER_DMA */
 +
  #endif


1.  Function signature should be on one line if possible (and it is).
Aw crud, I looked at dma-mapping.h and it uses this format sometimes.
Well, it's undesirable, so please don't propagate it.

2.  No parens on return: it's not a function.

static inline int dma_flags_set_dmaflush(int dir)
{
return dir;
}


Similar comments for patch 2/4: sn-ia64.

---
~Randy
Phaedrus says that Quality is about caring.
-
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to [EMAIL PROTECTED]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/