Re: [PATCH 1/4] dt-bindings: PCI: ti, j721e: Add bindings to specify legacy interrupts

2021-03-25 Thread Rob Herring 
On Thu, 25 Mar 2021 14:39:33 +0530, Kishon Vijay Abraham I wrote:
> Add bindings to specify interrupt controller for legacy interrupts.
> 
> Signed-off-by: Kishon Vijay Abraham I 
> ---
>  .../devicetree/bindings/pci/ti,j721e-pci-host.yaml  | 13 +
>  1 file changed, 13 insertions(+)
> 

My bot found errors running 'make dt_binding_check' on your patch:

yamllint warnings/errors:

dtschema/dtc warnings/errors:
Error: 
Documentation/devicetree/bindings/pci/ti,j721e-pci-host.example.dts:59.39-40 
syntax error
FATAL ERROR: Unable to parse input tree
make[1]: *** [scripts/Makefile.lib:349: 
Documentation/devicetree/bindings/pci/ti,j721e-pci-host.example.dt.yaml] Error 1
make[1]: *** Waiting for unfinished jobs
make: *** [Makefile:1380: dt_binding_check] Error 2

See https://patchwork.ozlabs.org/patch/1458255

This check can fail if there are any dependencies. The base for a patch
series is generally the most recent rc1.

If you already ran 'make dt_binding_check' and didn't see the above
error(s), then make sure 'yamllint' is installed and dt-schema is up to
date:

pip3 install dtschema --upgrade

Please check and re-submit.

[PATCH 1/4] dt-bindings: PCI: ti,j721e: Add bindings to specify legacy interrupts

2021-03-25 Thread Kishon Vijay Abraham I 
Add bindings to specify interrupt controller for legacy interrupts.

Signed-off-by: Kishon Vijay Abraham I 
---
 .../devicetree/bindings/pci/ti,j721e-pci-host.yaml  | 13 +
 1 file changed, 13 insertions(+)

diff --git a/Documentation/devicetree/bindings/pci/ti,j721e-pci-host.yaml 
b/Documentation/devicetree/bindings/pci/ti,j721e-pci-host.yaml
index 05aeb1aa362a..3e70a8049eea 100644
--- a/Documentation/devicetree/bindings/pci/ti,j721e-pci-host.yaml
+++ b/Documentation/devicetree/bindings/pci/ti,j721e-pci-host.yaml
@@ -73,6 +73,11 @@ properties:
 
   msi-map: true
 
+patternProperties:
+  "interrupt-controller":
+type: object
+description: interrupt controller to handle legacy interrupts.
+
 required:
   - compatible
   - reg
@@ -130,5 +135,13 @@ examples:
 ranges = <0x0100 0x0 0x10001000  0x00 0x10001000  0x0 
0x001>,
  <0x0200 0x0 0x10011000  0x00 0x10011000  0x0 
0x7fef000>;
 dma-ranges = <0x0200 0x0 0x0 0x0 0x0 0x1 0x0>;
+
+
+pcie0_intc: interrupt-controller {
+interrupt-controller;
+#interrupt-cells = <1>;
+interrupt-parent = <>;
+interrupts = ;
+};
 };
 };
-- 
2.17.1