RE: [PATCH 1/5] dt-bindings: fsl: scu: add scu power key binding

[Anson Huang]

Hi, Rob

> On Fri, Aug 30, 2019 at 04:53:45PM -0400, Anson Huang wrote:
> > NXP i.MX8QXP is an ARMv8 SoC with a Cortex-M4 core inside as system
> > controller, the system controller is in charge of system power, clock
> > and power key event etc. management, Linux kernel has to communicate
> > with system controller via MU (message unit) IPC to get power key
> > event, add binding doc for i.MX system controller power key driver.
> >
> > Signed-off-by: Anson Huang 
> > ---
> >  .../devicetree/bindings/arm/freescale/fsl,scu.txt  | 18
> ++
> >  1 file changed, 18 insertions(+)
> >
> > diff --git
> > a/Documentation/devicetree/bindings/arm/freescale/fsl,scu.txt
> > b/Documentation/devicetree/bindings/arm/freescale/fsl,scu.txt
> > index c149fad..001d0b7 100644
> > --- a/Documentation/devicetree/bindings/arm/freescale/fsl,scu.txt
> > +++ b/Documentation/devicetree/bindings/arm/freescale/fsl,scu.txt
> > @@ -157,6 +157,17 @@ Required properties:
> >  Optional properties:
> >  - timeout-sec: contains the watchdog timeout in seconds.
> >
> > +Power key bindings based on SCU Message Protocol
> > +
> > +
> > +Required properties:
> > +- compatible: should be:
> > +  "fsl,imx8qxp-sc-pwrkey"
> > +  followed by "fsl,imx-sc-pwrkey";
> > +- linux,keycodes: See
> > +Documentation/devicetree/bindings/input/keys.txt
> > +Optional Properties:
> > +- wakeup-source: See
> > +Documentation/devicetree/bindings/power/wakeup-source.txt
> > +
> >  Example (imx8qxp):
> >  -
> >  aliases {
> > @@ -220,6 +231,13 @@ firmware {
> > compatible = "fsl,imx8qxp-sc-rtc";
> > };
> >
> > +   scu_pwrkey: scu-pwrkey {
> > +   compatible = "fsl,imx8qxp-sc-pwrkey", "fsl,imx-sc-
> pwrkey";
> > +   linux,keycode = ;
> > +   wakeup-source;
> 
> wakeup-source implies an interrupt property.

After further check, I confirm this "wakeup-source" property is NOT needed for 
SCU general interrupt
wakeup, remove it in V2. 

> 
> > +   status = "disabled";
> 
> Don't should status in examples.

Removed it in V2, please help review, thanks.

Anson

Re: [PATCH 1/5] dt-bindings: fsl: scu: add scu power key binding

[Rob Herring]

On Fri, Aug 30, 2019 at 04:53:45PM -0400, Anson Huang wrote:
> NXP i.MX8QXP is an ARMv8 SoC with a Cortex-M4 core inside as
> system controller, the system controller is in charge of system
> power, clock and power key event etc. management, Linux kernel
> has to communicate with system controller via MU (message unit)
> IPC to get power key event, add binding doc for i.MX system
> controller power key driver.
> 
> Signed-off-by: Anson Huang 
> ---
>  .../devicetree/bindings/arm/freescale/fsl,scu.txt  | 18 
> ++
>  1 file changed, 18 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/arm/freescale/fsl,scu.txt 
> b/Documentation/devicetree/bindings/arm/freescale/fsl,scu.txt
> index c149fad..001d0b7 100644
> --- a/Documentation/devicetree/bindings/arm/freescale/fsl,scu.txt
> +++ b/Documentation/devicetree/bindings/arm/freescale/fsl,scu.txt
> @@ -157,6 +157,17 @@ Required properties:
>  Optional properties:
>  - timeout-sec: contains the watchdog timeout in seconds.
>  
> +Power key bindings based on SCU Message Protocol
> +
> +
> +Required properties:
> +- compatible: should be:
> +  "fsl,imx8qxp-sc-pwrkey"
> +  followed by "fsl,imx-sc-pwrkey";
> +- linux,keycodes: See Documentation/devicetree/bindings/input/keys.txt
> +Optional Properties:
> +- wakeup-source: See 
> Documentation/devicetree/bindings/power/wakeup-source.txt
> +
>  Example (imx8qxp):
>  -
>  aliases {
> @@ -220,6 +231,13 @@ firmware {
>   compatible = "fsl,imx8qxp-sc-rtc";
>   };
>  
> + scu_pwrkey: scu-pwrkey {
> + compatible = "fsl,imx8qxp-sc-pwrkey", 
> "fsl,imx-sc-pwrkey";
> + linux,keycode = ;
> + wakeup-source;

wakeup-source implies an interrupt property.

> + status = "disabled";

Don't should status in examples.

> + };
> +
>   watchdog {
>   compatible = "fsl,imx8qxp-sc-wdt", "fsl,imx-sc-wdt";
>   timeout-sec = <60>;
> -- 
> 2.7.4
> 

[PATCH 1/5] dt-bindings: fsl: scu: add scu power key binding

[Anson Huang]

NXP i.MX8QXP is an ARMv8 SoC with a Cortex-M4 core inside as
system controller, the system controller is in charge of system
power, clock and power key event etc. management, Linux kernel
has to communicate with system controller via MU (message unit)
IPC to get power key event, add binding doc for i.MX system
controller power key driver.

Signed-off-by: Anson Huang 
---
 .../devicetree/bindings/arm/freescale/fsl,scu.txt  | 18 ++
 1 file changed, 18 insertions(+)

diff --git a/Documentation/devicetree/bindings/arm/freescale/fsl,scu.txt 
b/Documentation/devicetree/bindings/arm/freescale/fsl,scu.txt
index c149fad..001d0b7 100644
--- a/Documentation/devicetree/bindings/arm/freescale/fsl,scu.txt
+++ b/Documentation/devicetree/bindings/arm/freescale/fsl,scu.txt
@@ -157,6 +157,17 @@ Required properties:
 Optional properties:
 - timeout-sec: contains the watchdog timeout in seconds.
 
+Power key bindings based on SCU Message Protocol
+
+
+Required properties:
+- compatible: should be:
+  "fsl,imx8qxp-sc-pwrkey"
+  followed by "fsl,imx-sc-pwrkey";
+- linux,keycodes: See Documentation/devicetree/bindings/input/keys.txt
+Optional Properties:
+- wakeup-source: See Documentation/devicetree/bindings/power/wakeup-source.txt
+
 Example (imx8qxp):
 -
 aliases {
@@ -220,6 +231,13 @@ firmware {
compatible = "fsl,imx8qxp-sc-rtc";
};
 
+   scu_pwrkey: scu-pwrkey {
+   compatible = "fsl,imx8qxp-sc-pwrkey", 
"fsl,imx-sc-pwrkey";
+   linux,keycode = ;
+   wakeup-source;
+   status = "disabled";
+   };
+
watchdog {
compatible = "fsl,imx8qxp-sc-wdt", "fsl,imx-sc-wdt";
timeout-sec = <60>;
-- 
2.7.4