RE: [PATCH 1/5 v2] thermal: rcar_gen3_thermal: Document the R-Car Gen3

[Khiem Nguyen]

Hi Geert,

Thanks for your comment.

> > --- /dev/null
> > +++ b/Documentation/devicetree/bindings/thermal/rcar-gen3-thermal.txt
> > @@ -0,0 +1,79 @@
> > +* DT bindings for Renesas R-Car Gen3 Thermal Sensor driver
> > +
> > +On R-Car Gen3 SoCs, the thermal sensor controllers (TSC) control the
> > +thermal sensors (THS) which are the analog circuits for measuring 
> > temperature
> (Tj) inside the LSI.
> > +
> > +Required properties:
> > +- compatible   : "renesas,-thermal",
> > + Examples with soctypes are:
> > +   - "renesas,r8a7795-thermal" (R-Car H3)
> > +   - "renesas,r8a7796-thermal" (R-Car M3)
> 
> M3-W

OK.
I will follow upstream style. Will update in v3.

Best regards,
KHIEM Nguyen

RE: [PATCH 1/5 v2] thermal: rcar_gen3_thermal: Document the R-Car Gen3

[Khiem Nguyen]

Hi Geert,

Thanks for your comment.

> > --- /dev/null
> > +++ b/Documentation/devicetree/bindings/thermal/rcar-gen3-thermal.txt
> > @@ -0,0 +1,79 @@
> > +* DT bindings for Renesas R-Car Gen3 Thermal Sensor driver
> > +
> > +On R-Car Gen3 SoCs, the thermal sensor controllers (TSC) control the
> > +thermal sensors (THS) which are the analog circuits for measuring 
> > temperature
> (Tj) inside the LSI.
> > +
> > +Required properties:
> > +- compatible   : "renesas,-thermal",
> > + Examples with soctypes are:
> > +   - "renesas,r8a7795-thermal" (R-Car H3)
> > +   - "renesas,r8a7796-thermal" (R-Car M3)
> 
> M3-W

OK.
I will follow upstream style. Will update in v3.

Best regards,
KHIEM Nguyen

Re: [PATCH 1/5 v2] thermal: rcar_gen3_thermal: Document the R-Car Gen3

[Geert Uytterhoeven]

On Sat, Sep 3, 2016 at 7:24 AM, Khiem Nguyen
 wrote:
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/thermal/rcar-gen3-thermal.txt
> @@ -0,0 +1,79 @@
> +* DT bindings for Renesas R-Car Gen3 Thermal Sensor driver
> +
> +On R-Car Gen3 SoCs, the thermal sensor controllers (TSC) control the thermal 
> sensors (THS)
> +which are the analog circuits for measuring temperature (Tj) inside the LSI.
> +
> +Required properties:
> +- compatible   : "renesas,-thermal",
> + Examples with soctypes are:
> +   - "renesas,r8a7795-thermal" (R-Car H3)
> +   - "renesas,r8a7796-thermal" (R-Car M3)

M3-W

Gr{oetje,eeting}s,

Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- ge...@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds

Re: [PATCH 1/5 v2] thermal: rcar_gen3_thermal: Document the R-Car Gen3

[Geert Uytterhoeven]

On Sat, Sep 3, 2016 at 7:24 AM, Khiem Nguyen
 wrote:
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/thermal/rcar-gen3-thermal.txt
> @@ -0,0 +1,79 @@
> +* DT bindings for Renesas R-Car Gen3 Thermal Sensor driver
> +
> +On R-Car Gen3 SoCs, the thermal sensor controllers (TSC) control the thermal 
> sensors (THS)
> +which are the analog circuits for measuring temperature (Tj) inside the LSI.
> +
> +Required properties:
> +- compatible   : "renesas,-thermal",
> + Examples with soctypes are:
> +   - "renesas,r8a7795-thermal" (R-Car H3)
> +   - "renesas,r8a7796-thermal" (R-Car M3)

M3-W

Gr{oetje,eeting}s,

Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- ge...@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds

[PATCH 1/5 v2] thermal: rcar_gen3_thermal: Document the R-Car Gen3

[Khiem Nguyen]

Signed-off-by: Hien Dang 
Signed-off-by: Khiem Nguyen 
---

v2:
 * Update the format of compatible string.
 * Add explanation for keyword tsc.
 
 .../bindings/thermal/rcar-gen3-thermal.txt | 79 ++
 1 file changed, 79 insertions(+)
 create mode 100644 
Documentation/devicetree/bindings/thermal/rcar-gen3-thermal.txt

diff --git a/Documentation/devicetree/bindings/thermal/rcar-gen3-thermal.txt 
b/Documentation/devicetree/bindings/thermal/rcar-gen3-thermal.txt
new file mode 100644
index 000..163f794
--- /dev/null
+++ b/Documentation/devicetree/bindings/thermal/rcar-gen3-thermal.txt
@@ -0,0 +1,79 @@
+* DT bindings for Renesas R-Car Gen3 Thermal Sensor driver
+
+On R-Car Gen3 SoCs, the thermal sensor controllers (TSC) control the thermal 
sensors (THS)
+which are the analog circuits for measuring temperature (Tj) inside the LSI.
+
+Required properties:
+- compatible   : "renesas,-thermal",
+ Examples with soctypes are:
+   - "renesas,r8a7795-thermal" (R-Car H3)
+   - "renesas,r8a7796-thermal" (R-Car M3)
+- reg  : Address range of the thermal registers.
+- clocks   : Must contain a reference to the functional clock.
+- #thermal-sensor-cells : Please see ./thermal.txt
+
+Option properties:
+
+- interrupts   : Use interrupt
+- power-domain : Must contain a reference to the power domain. This 
property is
+ mandatory if the thermal sensor instance is part of a 
controllable power
+ domain.
+
+Example (non interrupt support):
+
+   tsc1: thermal@e6198000 {
+   compatible = "renesas,r8a7795-thermal";
+   reg = <0 0xe6198000 0 0x5c>;
+   clocks = < CPG_MOD 522>;
+   power-domains = < R8A7795_PD_ALWAYS_ON>;
+   #thermal-sensor-cells = <0>;
+   status = "okay";
+   };
+
+   thermal-zones {
+   sensor_thermal1: sensor-thermal1 {
+   polling-delay-passive = <250>;
+   polling-delay = <1000>;
+
+   /* sensor ID */
+   thermal-sensors = <>;
+
+   trips {
+   sensor1_crit: sensor1-crit {
+   temperature = <9>;
+   hysteresis = <2000>;
+   type = "critical";
+   };
+   };
+   };
+   };
+
+Example (interrupt support):
+
+   tsc1: thermal@e6198000 {
+   compatible = "renesas,r8a7795-thermal";
+   reg = <0 0xe6198000 0 0x5c>;
+   interrupts = ;
+   clocks = < CPG_MOD 522>;
+   power-domains = < R8A7795_PD_ALWAYS_ON>;
+   #thermal-sensor-cells = <0>;
+   status = "okay";
+   };
+
+   thermal-zones {
+   sensor_thermal1: sensor-thermal1 {
+   polling-delay-passive = <250>;
+   polling-delay = <0>;
+
+   /* sensor ID */
+   thermal-sensors = <>;
+
+   trips {
+   sensor1_crit: sensor1-crit {
+   temperature = <9>;
+   hysteresis = <2000>;
+   type = "critical";
+   };
+   };
+   };
+   };
-- 
1.9.1

[PATCH 1/5 v2] thermal: rcar_gen3_thermal: Document the R-Car Gen3

[Khiem Nguyen]

Signed-off-by: Hien Dang 
Signed-off-by: Khiem Nguyen 
---

v2:
 * Update the format of compatible string.
 * Add explanation for keyword tsc.
 
 .../bindings/thermal/rcar-gen3-thermal.txt | 79 ++
 1 file changed, 79 insertions(+)
 create mode 100644 
Documentation/devicetree/bindings/thermal/rcar-gen3-thermal.txt

diff --git a/Documentation/devicetree/bindings/thermal/rcar-gen3-thermal.txt 
b/Documentation/devicetree/bindings/thermal/rcar-gen3-thermal.txt
new file mode 100644
index 000..163f794
--- /dev/null
+++ b/Documentation/devicetree/bindings/thermal/rcar-gen3-thermal.txt
@@ -0,0 +1,79 @@
+* DT bindings for Renesas R-Car Gen3 Thermal Sensor driver
+
+On R-Car Gen3 SoCs, the thermal sensor controllers (TSC) control the thermal 
sensors (THS)
+which are the analog circuits for measuring temperature (Tj) inside the LSI.
+
+Required properties:
+- compatible   : "renesas,-thermal",
+ Examples with soctypes are:
+   - "renesas,r8a7795-thermal" (R-Car H3)
+   - "renesas,r8a7796-thermal" (R-Car M3)
+- reg  : Address range of the thermal registers.
+- clocks   : Must contain a reference to the functional clock.
+- #thermal-sensor-cells : Please see ./thermal.txt
+
+Option properties:
+
+- interrupts   : Use interrupt
+- power-domain : Must contain a reference to the power domain. This 
property is
+ mandatory if the thermal sensor instance is part of a 
controllable power
+ domain.
+
+Example (non interrupt support):
+
+   tsc1: thermal@e6198000 {
+   compatible = "renesas,r8a7795-thermal";
+   reg = <0 0xe6198000 0 0x5c>;
+   clocks = < CPG_MOD 522>;
+   power-domains = < R8A7795_PD_ALWAYS_ON>;
+   #thermal-sensor-cells = <0>;
+   status = "okay";
+   };
+
+   thermal-zones {
+   sensor_thermal1: sensor-thermal1 {
+   polling-delay-passive = <250>;
+   polling-delay = <1000>;
+
+   /* sensor ID */
+   thermal-sensors = <>;
+
+   trips {
+   sensor1_crit: sensor1-crit {
+   temperature = <9>;
+   hysteresis = <2000>;
+   type = "critical";
+   };
+   };
+   };
+   };
+
+Example (interrupt support):
+
+   tsc1: thermal@e6198000 {
+   compatible = "renesas,r8a7795-thermal";
+   reg = <0 0xe6198000 0 0x5c>;
+   interrupts = ;
+   clocks = < CPG_MOD 522>;
+   power-domains = < R8A7795_PD_ALWAYS_ON>;
+   #thermal-sensor-cells = <0>;
+   status = "okay";
+   };
+
+   thermal-zones {
+   sensor_thermal1: sensor-thermal1 {
+   polling-delay-passive = <250>;
+   polling-delay = <0>;
+
+   /* sensor ID */
+   thermal-sensors = <>;
+
+   trips {
+   sensor1_crit: sensor1-crit {
+   temperature = <9>;
+   hysteresis = <2000>;
+   type = "critical";
+   };
+   };
+   };
+   };
-- 
1.9.1