Re: [PATCH 1/6] dmaengine: at_hdmac: simplify getting .drvdata

[Ludovic Desroches]

On Sun, Apr 22, 2018 at 11:14:09AM +0200, Wolfram Sang wrote:
> We should get drvdata from struct device directly. Going via
> platform_device is an unneeded step back and forth.
> 
> Signed-off-by: Wolfram Sang 
Acked-by: Ludovic Desroches  

Thanks
> ---
> 
> Build tested only. buildbot is happy. Please apply to your tree directly.
> 
>  drivers/dma/at_hdmac.c | 9 +++--
>  1 file changed, 3 insertions(+), 6 deletions(-)
> 
> diff --git a/drivers/dma/at_hdmac.c b/drivers/dma/at_hdmac.c
> index a861b5b4d443..75f38d19fcbe 100644
> --- a/drivers/dma/at_hdmac.c
> +++ b/drivers/dma/at_hdmac.c
> @@ -2041,8 +2041,7 @@ static void at_dma_shutdown(struct platform_device 
> *pdev)
>  
>  static int at_dma_prepare(struct device *dev)
>  {
> - struct platform_device *pdev = to_platform_device(dev);
> - struct at_dma *atdma = platform_get_drvdata(pdev);
> + struct at_dma *atdma = dev_get_drvdata(dev);
>   struct dma_chan *chan, *_chan;
>  
>   list_for_each_entry_safe(chan, _chan, >dma_common.channels,
> @@ -2076,8 +2075,7 @@ static void atc_suspend_cyclic(struct at_dma_chan 
> *atchan)
>  
>  static int at_dma_suspend_noirq(struct device *dev)
>  {
> - struct platform_device *pdev = to_platform_device(dev);
> - struct at_dma *atdma = platform_get_drvdata(pdev);
> + struct at_dma *atdma = dev_get_drvdata(dev);
>   struct dma_chan *chan, *_chan;
>  
>   /* preserve data */
> @@ -2118,8 +2116,7 @@ static void atc_resume_cyclic(struct at_dma_chan 
> *atchan)
>  
>  static int at_dma_resume_noirq(struct device *dev)
>  {
> - struct platform_device *pdev = to_platform_device(dev);
> - struct at_dma *atdma = platform_get_drvdata(pdev);
> + struct at_dma *atdma = dev_get_drvdata(dev);
>   struct dma_chan *chan, *_chan;
>  
>   /* bring back DMA controller */
> -- 
> 2.11.0
> 

Re: [PATCH 1/6] dmaengine: at_hdmac: simplify getting .drvdata

[Ludovic Desroches]

On Sun, Apr 22, 2018 at 11:14:09AM +0200, Wolfram Sang wrote:
> We should get drvdata from struct device directly. Going via
> platform_device is an unneeded step back and forth.
> 
> Signed-off-by: Wolfram Sang 
Acked-by: Ludovic Desroches  

Thanks
> ---
> 
> Build tested only. buildbot is happy. Please apply to your tree directly.
> 
>  drivers/dma/at_hdmac.c | 9 +++--
>  1 file changed, 3 insertions(+), 6 deletions(-)
> 
> diff --git a/drivers/dma/at_hdmac.c b/drivers/dma/at_hdmac.c
> index a861b5b4d443..75f38d19fcbe 100644
> --- a/drivers/dma/at_hdmac.c
> +++ b/drivers/dma/at_hdmac.c
> @@ -2041,8 +2041,7 @@ static void at_dma_shutdown(struct platform_device 
> *pdev)
>  
>  static int at_dma_prepare(struct device *dev)
>  {
> - struct platform_device *pdev = to_platform_device(dev);
> - struct at_dma *atdma = platform_get_drvdata(pdev);
> + struct at_dma *atdma = dev_get_drvdata(dev);
>   struct dma_chan *chan, *_chan;
>  
>   list_for_each_entry_safe(chan, _chan, >dma_common.channels,
> @@ -2076,8 +2075,7 @@ static void atc_suspend_cyclic(struct at_dma_chan 
> *atchan)
>  
>  static int at_dma_suspend_noirq(struct device *dev)
>  {
> - struct platform_device *pdev = to_platform_device(dev);
> - struct at_dma *atdma = platform_get_drvdata(pdev);
> + struct at_dma *atdma = dev_get_drvdata(dev);
>   struct dma_chan *chan, *_chan;
>  
>   /* preserve data */
> @@ -2118,8 +2116,7 @@ static void atc_resume_cyclic(struct at_dma_chan 
> *atchan)
>  
>  static int at_dma_resume_noirq(struct device *dev)
>  {
> - struct platform_device *pdev = to_platform_device(dev);
> - struct at_dma *atdma = platform_get_drvdata(pdev);
> + struct at_dma *atdma = dev_get_drvdata(dev);
>   struct dma_chan *chan, *_chan;
>  
>   /* bring back DMA controller */
> -- 
> 2.11.0
> 

[PATCH 1/6] dmaengine: at_hdmac: simplify getting .drvdata

[Wolfram Sang]

We should get drvdata from struct device directly. Going via
platform_device is an unneeded step back and forth.

Signed-off-by: Wolfram Sang 
---

Build tested only. buildbot is happy. Please apply to your tree directly.

 drivers/dma/at_hdmac.c | 9 +++--
 1 file changed, 3 insertions(+), 6 deletions(-)

diff --git a/drivers/dma/at_hdmac.c b/drivers/dma/at_hdmac.c
index a861b5b4d443..75f38d19fcbe 100644
--- a/drivers/dma/at_hdmac.c
+++ b/drivers/dma/at_hdmac.c
@@ -2041,8 +2041,7 @@ static void at_dma_shutdown(struct platform_device *pdev)
 
 static int at_dma_prepare(struct device *dev)
 {
-   struct platform_device *pdev = to_platform_device(dev);
-   struct at_dma *atdma = platform_get_drvdata(pdev);
+   struct at_dma *atdma = dev_get_drvdata(dev);
struct dma_chan *chan, *_chan;
 
list_for_each_entry_safe(chan, _chan, >dma_common.channels,
@@ -2076,8 +2075,7 @@ static void atc_suspend_cyclic(struct at_dma_chan *atchan)
 
 static int at_dma_suspend_noirq(struct device *dev)
 {
-   struct platform_device *pdev = to_platform_device(dev);
-   struct at_dma *atdma = platform_get_drvdata(pdev);
+   struct at_dma *atdma = dev_get_drvdata(dev);
struct dma_chan *chan, *_chan;
 
/* preserve data */
@@ -2118,8 +2116,7 @@ static void atc_resume_cyclic(struct at_dma_chan *atchan)
 
 static int at_dma_resume_noirq(struct device *dev)
 {
-   struct platform_device *pdev = to_platform_device(dev);
-   struct at_dma *atdma = platform_get_drvdata(pdev);
+   struct at_dma *atdma = dev_get_drvdata(dev);
struct dma_chan *chan, *_chan;
 
/* bring back DMA controller */
-- 
2.11.0

[PATCH 1/6] dmaengine: at_hdmac: simplify getting .drvdata

[Wolfram Sang]

We should get drvdata from struct device directly. Going via
platform_device is an unneeded step back and forth.

Signed-off-by: Wolfram Sang 
---

Build tested only. buildbot is happy. Please apply to your tree directly.

 drivers/dma/at_hdmac.c | 9 +++--
 1 file changed, 3 insertions(+), 6 deletions(-)

diff --git a/drivers/dma/at_hdmac.c b/drivers/dma/at_hdmac.c
index a861b5b4d443..75f38d19fcbe 100644
--- a/drivers/dma/at_hdmac.c
+++ b/drivers/dma/at_hdmac.c
@@ -2041,8 +2041,7 @@ static void at_dma_shutdown(struct platform_device *pdev)
 
 static int at_dma_prepare(struct device *dev)
 {
-   struct platform_device *pdev = to_platform_device(dev);
-   struct at_dma *atdma = platform_get_drvdata(pdev);
+   struct at_dma *atdma = dev_get_drvdata(dev);
struct dma_chan *chan, *_chan;
 
list_for_each_entry_safe(chan, _chan, >dma_common.channels,
@@ -2076,8 +2075,7 @@ static void atc_suspend_cyclic(struct at_dma_chan *atchan)
 
 static int at_dma_suspend_noirq(struct device *dev)
 {
-   struct platform_device *pdev = to_platform_device(dev);
-   struct at_dma *atdma = platform_get_drvdata(pdev);
+   struct at_dma *atdma = dev_get_drvdata(dev);
struct dma_chan *chan, *_chan;
 
/* preserve data */
@@ -2118,8 +2116,7 @@ static void atc_resume_cyclic(struct at_dma_chan *atchan)
 
 static int at_dma_resume_noirq(struct device *dev)
 {
-   struct platform_device *pdev = to_platform_device(dev);
-   struct at_dma *atdma = platform_get_drvdata(pdev);
+   struct at_dma *atdma = dev_get_drvdata(dev);
struct dma_chan *chan, *_chan;
 
/* bring back DMA controller */
-- 
2.11.0