Re: [PATCH 1/6] dt-bindings: omap: Update PRM binding for genpd

2020-07-15 Thread Rob Herring 
On Thu, 02 Jul 2020 08:45:08 -0700, Tony Lindgren wrote:
> The PRM (Power and Reset Module) has a register to enable and disable
> the related power domain, so let's update the binding for that.
> 
> Cc: devicet...@vger.kernel.org
> Cc: Rob Herring 
> Signed-off-by: Tony Lindgren 
> ---
>  Documentation/devicetree/bindings/arm/omap/prm-inst.txt | 2 ++
>  1 file changed, 2 insertions(+)
> 

Acked-by: Rob Herring

[PATCH 1/6] dt-bindings: omap: Update PRM binding for genpd

2020-07-02 Thread Tony Lindgren 
The PRM (Power and Reset Module) has a register to enable and disable
the related power domain, so let's update the binding for that.

Cc: devicet...@vger.kernel.org
Cc: Rob Herring 
Signed-off-by: Tony Lindgren 
---
 Documentation/devicetree/bindings/arm/omap/prm-inst.txt | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/Documentation/devicetree/bindings/arm/omap/prm-inst.txt 
b/Documentation/devicetree/bindings/arm/omap/prm-inst.txt
--- a/Documentation/devicetree/bindings/arm/omap/prm-inst.txt
+++ b/Documentation/devicetree/bindings/arm/omap/prm-inst.txt
@@ -18,6 +18,7 @@ Required properties:
(base address and length)
 
 Optional properties:
+- #power-domain-cells: Should be 0 if the instance is a power domain provider.
 - #reset-cells:Should be 1 if the PRM instance in question supports 
resets.
 
 Example:
@@ -25,5 +26,6 @@ Example:
 prm_dsp2: prm@1b00 {
compatible = "ti,dra7-prm-inst", "ti,omap-prm-inst";
reg = <0x1b00 0x40>;
+   #power-domain-cells = <0>;
#reset-cells = <1>;
 };
-- 
2.27.0

[PATCH 1/6] dt-bindings: omap: Update PRM binding for genpd

2020-06-22 Thread Tony Lindgren 
The PRM (Power and Reset Module) has a register to enable and disable
the related power domain, so let's update the binding for that.

Cc: devicet...@vger.kernel.org
Cc: Rob Herring 
Signed-off-by: Tony Lindgren 
---
 Documentation/devicetree/bindings/arm/omap/prm-inst.txt | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/Documentation/devicetree/bindings/arm/omap/prm-inst.txt 
b/Documentation/devicetree/bindings/arm/omap/prm-inst.txt
--- a/Documentation/devicetree/bindings/arm/omap/prm-inst.txt
+++ b/Documentation/devicetree/bindings/arm/omap/prm-inst.txt
@@ -18,6 +18,7 @@ Required properties:
(base address and length)
 
 Optional properties:
+- #power-domain-cells: Should be 0 if the instance is a power domain provider.
 - #reset-cells:Should be 1 if the PRM instance in question supports 
resets.
 
 Example:
@@ -25,5 +26,6 @@ Example:
 prm_dsp2: prm@1b00 {
compatible = "ti,dra7-prm-inst", "ti,omap-prm-inst";
reg = <0x1b00 0x40>;
+   #power-domain-cells = <0>;
#reset-cells = <1>;
 };
-- 
2.27.0

Re: [PATCH 1/6] dt-bindings: omap: Update PRM binding for genpd

2020-05-28 Thread Rob Herring 
On Wed, May 20, 2020 at 02:13:29PM -0700, Tony Lindgren wrote:
> The PRM (Power and Reset Module) has registers to enable and disable
> power domains, so let's update the binding for that.

multiple domains? Then why 0 cells?

> 
> Cc: devicet...@vger.kernel.org
> Cc: Rob Herring 
> Signed-off-by: Tony Lindgren 
> ---
>  Documentation/devicetree/bindings/arm/omap/prm-inst.txt | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/arm/omap/prm-inst.txt 
> b/Documentation/devicetree/bindings/arm/omap/prm-inst.txt
> --- a/Documentation/devicetree/bindings/arm/omap/prm-inst.txt
> +++ b/Documentation/devicetree/bindings/arm/omap/prm-inst.txt
> @@ -18,6 +18,7 @@ Required properties:
>   (base address and length)
>  
>  Optional properties:
> +- #power-domain-cells:   Should be 0 if the PRM instance is a power 
> domain.

...power domain provider.

>  - #reset-cells:  Should be 1 if the PRM instance in question supports 
> resets.
>  
>  Example:
> @@ -25,5 +26,6 @@ Example:
>  prm_dsp2: prm@1b00 {
>   compatible = "ti,dra7-prm-inst", "ti,omap-prm-inst";
>   reg = <0x1b00 0x40>;
> + #power-domain-cells = <0>;
>   #reset-cells = <1>;
>  };
> -- 
> 2.26.2

[PATCH 1/6] dt-bindings: omap: Update PRM binding for genpd

2020-05-20 Thread Tony Lindgren 
The PRM (Power and Reset Module) has registers to enable and disable
power domains, so let's update the binding for that.

Cc: devicet...@vger.kernel.org
Cc: Rob Herring 
Signed-off-by: Tony Lindgren 
---
 Documentation/devicetree/bindings/arm/omap/prm-inst.txt | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/Documentation/devicetree/bindings/arm/omap/prm-inst.txt 
b/Documentation/devicetree/bindings/arm/omap/prm-inst.txt
--- a/Documentation/devicetree/bindings/arm/omap/prm-inst.txt
+++ b/Documentation/devicetree/bindings/arm/omap/prm-inst.txt
@@ -18,6 +18,7 @@ Required properties:
(base address and length)
 
 Optional properties:
+- #power-domain-cells: Should be 0 if the PRM instance is a power domain.
 - #reset-cells:Should be 1 if the PRM instance in question supports 
resets.
 
 Example:
@@ -25,5 +26,6 @@ Example:
 prm_dsp2: prm@1b00 {
compatible = "ti,dra7-prm-inst", "ti,omap-prm-inst";
reg = <0x1b00 0x40>;
+   #power-domain-cells = <0>;
#reset-cells = <1>;
 };
-- 
2.26.2

Re: [PATCH 1/6] dt-bindings: omap: Update PRM binding for genpd

2020-05-14 Thread Tony Lindgren 
* Tero Kristo  [200514 07:40]:
> On 12/05/2020 23:38, Tony Lindgren wrote:
> > The PRM (Power and Reset Module) has registers to enable and disable
> > power domains, so let's update the binding for that.
> > 
> > Cc: devicet...@vger.kernel.org
> > Cc: Rob Herring 
> > Signed-off-by: Tony Lindgren 
> > ---
> >   Documentation/devicetree/bindings/arm/omap/prm-inst.txt | 4 
> >   1 file changed, 4 insertions(+)
> > 
> > diff --git a/Documentation/devicetree/bindings/arm/omap/prm-inst.txt 
> > b/Documentation/devicetree/bindings/arm/omap/prm-inst.txt
> > --- a/Documentation/devicetree/bindings/arm/omap/prm-inst.txt
> > +++ b/Documentation/devicetree/bindings/arm/omap/prm-inst.txt
> > @@ -18,12 +18,16 @@ Required properties:
> > (base address and length)
> >   Optional properties:
> > +- #power-domain-cells: Should be 0 if the PRM instance is a power 
> > domain.
> >   - #reset-cells:   Should be 1 if the PRM instance in question supports 
> > resets.
> > +- clocks: Functional and interface clocks managed by the power domain
> > +- clock-names: Names for the clocks using "fck" and "ick" naming
> 
> Whats the purpose of the clocks for PRM? It looks like you are using this
> with ABE domain on omap4/omap5, but why is this needed?

Hmm good point, seems to be just confusion at my end on what should
handle the clocks for the interconnect instances. We can just leave
out the clocks here probably.

Regards,

Tony

Re: [PATCH 1/6] dt-bindings: omap: Update PRM binding for genpd

2020-05-14 Thread Tero Kristo 

On 12/05/2020 23:38, Tony Lindgren wrote:

The PRM (Power and Reset Module) has registers to enable and disable
power domains, so let's update the binding for that.

Cc: devicet...@vger.kernel.org
Cc: Rob Herring 
Signed-off-by: Tony Lindgren 
---
  Documentation/devicetree/bindings/arm/omap/prm-inst.txt | 4 
  1 file changed, 4 insertions(+)

diff --git a/Documentation/devicetree/bindings/arm/omap/prm-inst.txt 
b/Documentation/devicetree/bindings/arm/omap/prm-inst.txt
--- a/Documentation/devicetree/bindings/arm/omap/prm-inst.txt
+++ b/Documentation/devicetree/bindings/arm/omap/prm-inst.txt
@@ -18,12 +18,16 @@ Required properties:
(base address and length)
  
  Optional properties:

+- #power-domain-cells: Should be 0 if the PRM instance is a power domain.
  - #reset-cells:   Should be 1 if the PRM instance in question supports 
resets.
+- clocks: Functional and interface clocks managed by the power domain
+- clock-names: Names for the clocks using "fck" and "ick" naming


Whats the purpose of the clocks for PRM? It looks like you are using 
this with ABE domain on omap4/omap5, but why is this needed?


-Tero

  
  Example:
  
  prm_dsp2: prm@1b00 {

compatible = "ti,dra7-prm-inst", "ti,omap-prm-inst";
reg = <0x1b00 0x40>;
+   #power-domain-cells = <0>;
#reset-cells = <1>;
  };



--
Texas Instruments Finland Oy, Porkkalankatu 22, 00180 Helsinki. 
Y-tunnus/Business ID: 0615521-4. Kotipaikka/Domicile: Helsinki

[PATCH 1/6] dt-bindings: omap: Update PRM binding for genpd

2020-05-12 Thread Tony Lindgren 
The PRM (Power and Reset Module) has registers to enable and disable
power domains, so let's update the binding for that.

Cc: devicet...@vger.kernel.org
Cc: Rob Herring 
Signed-off-by: Tony Lindgren 
---
 Documentation/devicetree/bindings/arm/omap/prm-inst.txt | 4 
 1 file changed, 4 insertions(+)

diff --git a/Documentation/devicetree/bindings/arm/omap/prm-inst.txt 
b/Documentation/devicetree/bindings/arm/omap/prm-inst.txt
--- a/Documentation/devicetree/bindings/arm/omap/prm-inst.txt
+++ b/Documentation/devicetree/bindings/arm/omap/prm-inst.txt
@@ -18,12 +18,16 @@ Required properties:
(base address and length)
 
 Optional properties:
+- #power-domain-cells: Should be 0 if the PRM instance is a power domain.
 - #reset-cells:Should be 1 if the PRM instance in question supports 
resets.
+- clocks: Functional and interface clocks managed by the power domain
+- clock-names: Names for the clocks using "fck" and "ick" naming
 
 Example:
 
 prm_dsp2: prm@1b00 {
compatible = "ti,dra7-prm-inst", "ti,omap-prm-inst";
reg = <0x1b00 0x40>;
+   #power-domain-cells = <0>;
#reset-cells = <1>;
 };
-- 
2.26.2