Re: [PATCH 1/7] MIPS: Loongson64: cleanup all cs5536 files to use SPDX Identifier

[Philippe Ombredanne]

On Tue, Dec 26, 2017 at 2:23 PM, Jiaxun Yang  wrote:
> To reduce unnecessary license text.



> diff --git a/arch/mips/loongson64/common/cs5536/cs5536_acc.c 
> b/arch/mips/loongson64/common/cs5536/cs5536_acc.c
> index ab4d6cc57384..ba0474bb4a3d 100644
> --- a/arch/mips/loongson64/common/cs5536/cs5536_acc.c
> +++ b/arch/mips/loongson64/common/cs5536/cs5536_acc.c
> @@ -1,3 +1,5 @@
> +/* SPDX-License-Identifier: GPL-2.0 */

Please use  // comment in .c files as requested by Linus and discussed on list.
This is also documented in Thomas doc patches.
This applies to the whole patch set.



> diff --git a/arch/mips/loongson64/common/cs5536/cs5536_isa.c 
> b/arch/mips/loongson64/common/cs5536/cs5536_isa.c
> index 924be39e7733..c358c0755eff 100644
> --- a/arch/mips/loongson64/common/cs5536/cs5536_isa.c
> +++ b/arch/mips/loongson64/common/cs5536/cs5536_isa.c
> @@ -1,3 +1,5 @@
> +/* SPDX-License-Identifier: GPL-2.0 */

And this is the correct comment style for .h files.

Thanks!

-- 
Cordially
Philippe Ombredanne

Re: [PATCH 1/7] MIPS: Loongson64: cleanup all cs5536 files to use SPDX Identifier

[Philippe Ombredanne]

On Tue, Dec 26, 2017 at 2:23 PM, Jiaxun Yang  wrote:
> To reduce unnecessary license text.



> diff --git a/arch/mips/loongson64/common/cs5536/cs5536_acc.c 
> b/arch/mips/loongson64/common/cs5536/cs5536_acc.c
> index ab4d6cc57384..ba0474bb4a3d 100644
> --- a/arch/mips/loongson64/common/cs5536/cs5536_acc.c
> +++ b/arch/mips/loongson64/common/cs5536/cs5536_acc.c
> @@ -1,3 +1,5 @@
> +/* SPDX-License-Identifier: GPL-2.0 */

Please use  // comment in .c files as requested by Linus and discussed on list.
This is also documented in Thomas doc patches.
This applies to the whole patch set.



> diff --git a/arch/mips/loongson64/common/cs5536/cs5536_isa.c 
> b/arch/mips/loongson64/common/cs5536/cs5536_isa.c
> index 924be39e7733..c358c0755eff 100644
> --- a/arch/mips/loongson64/common/cs5536/cs5536_isa.c
> +++ b/arch/mips/loongson64/common/cs5536/cs5536_isa.c
> @@ -1,3 +1,5 @@
> +/* SPDX-License-Identifier: GPL-2.0 */

And this is the correct comment style for .h files.

Thanks!

-- 
Cordially
Philippe Ombredanne

[PATCH 1/7] MIPS: Loongson64: cleanup all cs5536 files to use SPDX Identifier

[Jiaxun Yang]

To reduce unnecessary license text.

Signed-off-by: Jiaxun Yang 
---
 arch/mips/loongson64/common/cs5536/Makefile   | 1 +
 arch/mips/loongson64/common/cs5536/cs5536_acc.c   | 6 ++
 arch/mips/loongson64/common/cs5536/cs5536_ehci.c  | 6 ++
 arch/mips/loongson64/common/cs5536/cs5536_ide.c   | 6 ++
 arch/mips/loongson64/common/cs5536/cs5536_isa.c   | 6 ++
 arch/mips/loongson64/common/cs5536/cs5536_mfgpt.c | 6 ++
 arch/mips/loongson64/common/cs5536/cs5536_ohci.c  | 6 ++
 arch/mips/loongson64/common/cs5536/cs5536_pci.c   | 7 ++-
 8 files changed, 15 insertions(+), 29 deletions(-)

diff --git a/arch/mips/loongson64/common/cs5536/Makefile 
b/arch/mips/loongson64/common/cs5536/Makefile
index f12e64007347..b0c805a0dcc6 100644
--- a/arch/mips/loongson64/common/cs5536/Makefile
+++ b/arch/mips/loongson64/common/cs5536/Makefile
@@ -1,3 +1,4 @@
+# SPDX-License-Identifier: GPL-2.0
 #
 # Makefile for CS5536 support.
 #
diff --git a/arch/mips/loongson64/common/cs5536/cs5536_acc.c 
b/arch/mips/loongson64/common/cs5536/cs5536_acc.c
index ab4d6cc57384..ba0474bb4a3d 100644
--- a/arch/mips/loongson64/common/cs5536/cs5536_acc.c
+++ b/arch/mips/loongson64/common/cs5536/cs5536_acc.c
@@ -1,3 +1,5 @@
+/* SPDX-License-Identifier: GPL-2.0 */
+
 /*
  * the ACC Virtual Support Module of AMD CS5536
  *
@@ -7,10 +9,6 @@
  * Copyright (C) 2009 Lemote, Inc.
  * Author: Wu Zhangjin, wuzhang...@gmail.com
  *
- * This program is free software; you can redistribute it and/or modify it
- * under  the terms of the GNU General  Public License as published by the
- * Free Software Foundation;  either version 2 of the  License, or (at your
- * option) any later version.
  */
 
 #include 
diff --git a/arch/mips/loongson64/common/cs5536/cs5536_ehci.c 
b/arch/mips/loongson64/common/cs5536/cs5536_ehci.c
index ec2e360267a8..c7a6ef09a978 100644
--- a/arch/mips/loongson64/common/cs5536/cs5536_ehci.c
+++ b/arch/mips/loongson64/common/cs5536/cs5536_ehci.c
@@ -1,3 +1,5 @@
+/* SPDX-License-Identifier: GPL-2.0 */
+
 /*
  * the EHCI Virtual Support Module of AMD CS5536
  *
@@ -7,10 +9,6 @@
  * Copyright (C) 2009 Lemote, Inc.
  * Author: Wu Zhangjin, wuzhang...@gmail.com
  *
- * This program is free software; you can redistribute it and/or modify it
- * under  the terms of the GNU General  Public License as published by the
- * Free Software Foundation;  either version 2 of the  License, or (at your
- * option) any later version.
  */
 
 #include 
diff --git a/arch/mips/loongson64/common/cs5536/cs5536_ide.c 
b/arch/mips/loongson64/common/cs5536/cs5536_ide.c
index a73414d9ee51..b88c7a20619e 100644
--- a/arch/mips/loongson64/common/cs5536/cs5536_ide.c
+++ b/arch/mips/loongson64/common/cs5536/cs5536_ide.c
@@ -1,3 +1,5 @@
+/* SPDX-License-Identifier: GPL-2.0 */
+
 /*
  * the IDE Virtual Support Module of AMD CS5536
  *
@@ -7,10 +9,6 @@
  * Copyright (C) 2009 Lemote, Inc.
  * Author: Wu Zhangjin, wuzhang...@gmail.com
  *
- * This program is free software; you can redistribute it and/or modify it
- * under  the terms of the GNU General  Public License as published by the
- * Free Software Foundation;  either version 2 of the  License, or (at your
- * option) any later version.
  */
 
 #include 
diff --git a/arch/mips/loongson64/common/cs5536/cs5536_isa.c 
b/arch/mips/loongson64/common/cs5536/cs5536_isa.c
index 924be39e7733..c358c0755eff 100644
--- a/arch/mips/loongson64/common/cs5536/cs5536_isa.c
+++ b/arch/mips/loongson64/common/cs5536/cs5536_isa.c
@@ -1,3 +1,5 @@
+/* SPDX-License-Identifier: GPL-2.0 */
+
 /*
  * the ISA Virtual Support Module of AMD CS5536
  *
@@ -7,10 +9,6 @@
  * Copyright (C) 2009 Lemote, Inc.
  * Author: Wu Zhangjin, wuzhang...@gmail.com
  *
- * This program is free software; you can redistribute it and/or modify it
- * under  the terms of the GNU General  Public License as published by the
- * Free Software Foundation;  either version 2 of the  License, or (at your
- * option) any later version.
  */
 
 #include 
diff --git a/arch/mips/loongson64/common/cs5536/cs5536_mfgpt.c 
b/arch/mips/loongson64/common/cs5536/cs5536_mfgpt.c
index a6adcc4f8960..0acb7e3fa660 100644
--- a/arch/mips/loongson64/common/cs5536/cs5536_mfgpt.c
+++ b/arch/mips/loongson64/common/cs5536/cs5536_mfgpt.c
@@ -1,3 +1,5 @@
+/* SPDX-License-Identifier: GPL-2.0 */
+
 /*
  * CS5536 General timer functions
  *
@@ -9,10 +11,6 @@
  *
  * Reference: AMD Geode(TM) CS5536 Companion Device Data Book
  *
- *  This program is free software; you can redistribute it and/or 
modify it
- *  under  the terms of the GNU General  Public License as published 
by the
- *  Free Software Foundation;  either version 2 of the License, or (at your
- *  option) any later version.
  */
 
 #include 
diff --git a/arch/mips/loongson64/common/cs5536/cs5536_ohci.c 
b/arch/mips/loongson64/common/cs5536/cs5536_ohci.c
index f7c905e50dc4..e82393273be7 100644
--- a/arch/mips/loongson64/common/cs5536/cs5536_ohci.c
+++ 

[PATCH 1/7] MIPS: Loongson64: cleanup all cs5536 files to use SPDX Identifier

[Jiaxun Yang]

To reduce unnecessary license text.

Signed-off-by: Jiaxun Yang 
---
 arch/mips/loongson64/common/cs5536/Makefile   | 1 +
 arch/mips/loongson64/common/cs5536/cs5536_acc.c   | 6 ++
 arch/mips/loongson64/common/cs5536/cs5536_ehci.c  | 6 ++
 arch/mips/loongson64/common/cs5536/cs5536_ide.c   | 6 ++
 arch/mips/loongson64/common/cs5536/cs5536_isa.c   | 6 ++
 arch/mips/loongson64/common/cs5536/cs5536_mfgpt.c | 6 ++
 arch/mips/loongson64/common/cs5536/cs5536_ohci.c  | 6 ++
 arch/mips/loongson64/common/cs5536/cs5536_pci.c   | 7 ++-
 8 files changed, 15 insertions(+), 29 deletions(-)

diff --git a/arch/mips/loongson64/common/cs5536/Makefile 
b/arch/mips/loongson64/common/cs5536/Makefile
index f12e64007347..b0c805a0dcc6 100644
--- a/arch/mips/loongson64/common/cs5536/Makefile
+++ b/arch/mips/loongson64/common/cs5536/Makefile
@@ -1,3 +1,4 @@
+# SPDX-License-Identifier: GPL-2.0
 #
 # Makefile for CS5536 support.
 #
diff --git a/arch/mips/loongson64/common/cs5536/cs5536_acc.c 
b/arch/mips/loongson64/common/cs5536/cs5536_acc.c
index ab4d6cc57384..ba0474bb4a3d 100644
--- a/arch/mips/loongson64/common/cs5536/cs5536_acc.c
+++ b/arch/mips/loongson64/common/cs5536/cs5536_acc.c
@@ -1,3 +1,5 @@
+/* SPDX-License-Identifier: GPL-2.0 */
+
 /*
  * the ACC Virtual Support Module of AMD CS5536
  *
@@ -7,10 +9,6 @@
  * Copyright (C) 2009 Lemote, Inc.
  * Author: Wu Zhangjin, wuzhang...@gmail.com
  *
- * This program is free software; you can redistribute it and/or modify it
- * under  the terms of the GNU General  Public License as published by the
- * Free Software Foundation;  either version 2 of the  License, or (at your
- * option) any later version.
  */
 
 #include 
diff --git a/arch/mips/loongson64/common/cs5536/cs5536_ehci.c 
b/arch/mips/loongson64/common/cs5536/cs5536_ehci.c
index ec2e360267a8..c7a6ef09a978 100644
--- a/arch/mips/loongson64/common/cs5536/cs5536_ehci.c
+++ b/arch/mips/loongson64/common/cs5536/cs5536_ehci.c
@@ -1,3 +1,5 @@
+/* SPDX-License-Identifier: GPL-2.0 */
+
 /*
  * the EHCI Virtual Support Module of AMD CS5536
  *
@@ -7,10 +9,6 @@
  * Copyright (C) 2009 Lemote, Inc.
  * Author: Wu Zhangjin, wuzhang...@gmail.com
  *
- * This program is free software; you can redistribute it and/or modify it
- * under  the terms of the GNU General  Public License as published by the
- * Free Software Foundation;  either version 2 of the  License, or (at your
- * option) any later version.
  */
 
 #include 
diff --git a/arch/mips/loongson64/common/cs5536/cs5536_ide.c 
b/arch/mips/loongson64/common/cs5536/cs5536_ide.c
index a73414d9ee51..b88c7a20619e 100644
--- a/arch/mips/loongson64/common/cs5536/cs5536_ide.c
+++ b/arch/mips/loongson64/common/cs5536/cs5536_ide.c
@@ -1,3 +1,5 @@
+/* SPDX-License-Identifier: GPL-2.0 */
+
 /*
  * the IDE Virtual Support Module of AMD CS5536
  *
@@ -7,10 +9,6 @@
  * Copyright (C) 2009 Lemote, Inc.
  * Author: Wu Zhangjin, wuzhang...@gmail.com
  *
- * This program is free software; you can redistribute it and/or modify it
- * under  the terms of the GNU General  Public License as published by the
- * Free Software Foundation;  either version 2 of the  License, or (at your
- * option) any later version.
  */
 
 #include 
diff --git a/arch/mips/loongson64/common/cs5536/cs5536_isa.c 
b/arch/mips/loongson64/common/cs5536/cs5536_isa.c
index 924be39e7733..c358c0755eff 100644
--- a/arch/mips/loongson64/common/cs5536/cs5536_isa.c
+++ b/arch/mips/loongson64/common/cs5536/cs5536_isa.c
@@ -1,3 +1,5 @@
+/* SPDX-License-Identifier: GPL-2.0 */
+
 /*
  * the ISA Virtual Support Module of AMD CS5536
  *
@@ -7,10 +9,6 @@
  * Copyright (C) 2009 Lemote, Inc.
  * Author: Wu Zhangjin, wuzhang...@gmail.com
  *
- * This program is free software; you can redistribute it and/or modify it
- * under  the terms of the GNU General  Public License as published by the
- * Free Software Foundation;  either version 2 of the  License, or (at your
- * option) any later version.
  */
 
 #include 
diff --git a/arch/mips/loongson64/common/cs5536/cs5536_mfgpt.c 
b/arch/mips/loongson64/common/cs5536/cs5536_mfgpt.c
index a6adcc4f8960..0acb7e3fa660 100644
--- a/arch/mips/loongson64/common/cs5536/cs5536_mfgpt.c
+++ b/arch/mips/loongson64/common/cs5536/cs5536_mfgpt.c
@@ -1,3 +1,5 @@
+/* SPDX-License-Identifier: GPL-2.0 */
+
 /*
  * CS5536 General timer functions
  *
@@ -9,10 +11,6 @@
  *
  * Reference: AMD Geode(TM) CS5536 Companion Device Data Book
  *
- *  This program is free software; you can redistribute it and/or 
modify it
- *  under  the terms of the GNU General  Public License as published 
by the
- *  Free Software Foundation;  either version 2 of the License, or (at your
- *  option) any later version.
  */
 
 #include 
diff --git a/arch/mips/loongson64/common/cs5536/cs5536_ohci.c 
b/arch/mips/loongson64/common/cs5536/cs5536_ohci.c
index f7c905e50dc4..e82393273be7 100644
--- a/arch/mips/loongson64/common/cs5536/cs5536_ohci.c
+++ b/arch/mips/loongson64/common/cs5536/cs5536_ohci.c