Re: [PATCH 1/8] compacting file_ra_state
On Fri, Jul 20, 2007 at 11:13:34PM -0700, Linus Torvalds wrote: > > I thought the new patches were some some restructured code, but > > essentially the tested algorithms? > > No, this series is a further cleanup on top of the restructured code, with > some new features too. The series _looks_ fine to me, but it still makes > sense to go through -mm, I think. What I meant was: iirc he first had a "very complex" patchkit in -mm* (the one with multiple predictors working together); then that got then replaced with a simpler easier to review one and now he's feeding the stuff from the complex one piece by piece back. Just pointed out that the newer stuff was likely already in -mm* for some time, just before one of the simplifications. But I guess more testing cannot hurt anyways. Anyways it's good we're finally making forward progress on this. It has the potential for real nice performance gains. -Andi - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH 1/8] compacting file_ra_state
On Sat, 21 Jul 2007, Andi Kleen wrote: > > Haven't the readahead patches already essentially been in -mm* for some time? They have indeed, and I merged them this week. > I thought the new patches were some some restructured code, but > essentially the tested algorithms? No, this series is a further cleanup on top of the restructured code, with some new features too. The series _looks_ fine to me, but it still makes sense to go through -mm, I think. Linus - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH 1/8] compacting file_ra_state
On Sat, 21 Jul 2007 07:57:06 +0200 Andi Kleen <[EMAIL PROTECTED]> wrote: > On Fri, Jul 20, 2007 at 09:27:01PM -0700, Linus Torvalds wrote: > > > > > > On Sat, 21 Jul 2007, Fengguang Wu wrote: > > > > > > Sorry, forgot to prefix the patch titles with [readahead]. > > > Should I repost? > > > > Not for me, but on the other hand, I'd prefer for this to be in -mm a bit, > > Haven't the readahead patches already essentially been in -mm* for some time? > I thought the new patches were some some restructured code, but essentially > the tested algorithms? > The all-singing all-dancging readahead code was in -mm for maybe a year. Then the much-reduced, feasible-for-merging code was in -mm for several months. It went mainline this week. This new patch series is some optimisation and algorithm tweaking on top of the recently-merged well-tested stuff. Waiting for 2.6.24 is appropriate. - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH 1/8] compacting file_ra_state
On Fri, Jul 20, 2007 at 09:27:01PM -0700, Linus Torvalds wrote: > > > On Sat, 21 Jul 2007, Fengguang Wu wrote: > > > > Sorry, forgot to prefix the patch titles with [readahead]. > > Should I repost? > > Not for me, but on the other hand, I'd prefer for this to be in -mm a bit, Haven't the readahead patches already essentially been in -mm* for some time? I thought the new patches were some some restructured code, but essentially the tested algorithms? -Andi - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH 1/8] compacting file_ra_state
On Fri, Jul 20, 2007 at 09:27:01PM -0700, Linus Torvalds wrote: > > > On Sat, 21 Jul 2007, Fengguang Wu wrote: > > > > Sorry, forgot to prefix the patch titles with [readahead]. > > Should I repost? > > Not for me, but on the other hand, I'd prefer for this to be in -mm a bit, > even if it does mean missing the merge window this time around. OK. Let me repost it... - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH 1/8] compacting file_ra_state
On Sat, 21 Jul 2007, Fengguang Wu wrote: > > Sorry, forgot to prefix the patch titles with [readahead]. > Should I repost? Not for me, but on the other hand, I'd prefer for this to be in -mm a bit, even if it does mean missing the merge window this time around. Linus - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH 1/8] compacting file_ra_state
Sorry, forgot to prefix the patch titles with [readahead]. Should I repost? - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
[PATCH 1/8] compacting file_ra_state
Use 'unsigned int' instead of 'unsigned long' for readahead sizes.
This helps reduce memory consumption on 64bit CPU when
a lot of files are opened.
CC: Andi Kleen <[EMAIL PROTECTED]>
Signed-off-by: Fengguang Wu <[EMAIL PROTECTED]>
---
include/linux/fs.h |8
mm/readahead.c |2 +-
2 files changed, 5 insertions(+), 5 deletions(-)
--- linux-2.6.22-git15.orig/include/linux/fs.h
+++ linux-2.6.22-git15/include/linux/fs.h
@@ -697,12 +697,12 @@ struct fown_struct {
* Track a single file's readahead state
*/
struct file_ra_state {
- pgoff_t start; /* where readahead started */
- unsigned long size; /* # of readahead pages */
- unsigned long async_size; /* do asynchronous readahead when
+ pgoff_t start; /* where readahead started */
+ unsigned int size; /* # of readahead pages */
+ unsigned int async_size;/* do asynchronous readahead when
there are only # of pages ahead */
- unsigned long ra_pages; /* Maximum readahead window */
+ unsigned int ra_pages; /* Maximum readahead window */
unsigned long mmap_hit; /* Cache hit stat for mmap accesses */
unsigned long mmap_miss;/* Cache miss stat for mmap accesses */
unsigned long prev_index; /* Cache last read() position */
--- linux-2.6.22-git15.orig/mm/readahead.c
+++ linux-2.6.22-git15/mm/readahead.c
@@ -350,7 +350,7 @@ ondemand_readahead(struct address_space
bool hit_readahead_marker, pgoff_t offset,
unsigned long req_size)
{
- unsigned long max; /* max readahead pages */
+ int max;/* max readahead pages */
int sequential;
max = ra->ra_pages;
--
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
