[PATCH 10/10 v2] Input: palmas-pwrbutton: Handle return value of platform_get_irq

2017-11-18 Thread Arvind Yadav
platform_get_irq() can fail here and we must check its return value.

Signed-off-by: Arvind Yadav 
---
changes in v2 :
  Add failure case '<= 0' instead of '< 0'. IRQ0 is not valid.

 drivers/input/misc/palmas-pwrbutton.c | 5 +
 1 file changed, 5 insertions(+)

diff --git a/drivers/input/misc/palmas-pwrbutton.c 
b/drivers/input/misc/palmas-pwrbutton.c
index 1e1baed..f9b05cf 100644
--- a/drivers/input/misc/palmas-pwrbutton.c
+++ b/drivers/input/misc/palmas-pwrbutton.c
@@ -210,6 +210,11 @@ static int palmas_pwron_probe(struct platform_device *pdev)
INIT_DELAYED_WORK(>input_work, palmas_power_button_work);
 
pwron->irq = platform_get_irq(pdev, 0);
+   if (pwron->irq <= 0) {
+   error = pwron->irq;
+   goto err_free_input;
+   }
+
error = request_threaded_irq(pwron->irq, NULL, pwron_irq,
 IRQF_TRIGGER_HIGH |
IRQF_TRIGGER_LOW |
-- 
2.7.4



[PATCH 10/10 v2] Input: palmas-pwrbutton: Handle return value of platform_get_irq

2017-11-18 Thread Arvind Yadav
platform_get_irq() can fail here and we must check its return value.

Signed-off-by: Arvind Yadav 
---
changes in v2 :
  Add failure case '<= 0' instead of '< 0'. IRQ0 is not valid.

 drivers/input/misc/palmas-pwrbutton.c | 5 +
 1 file changed, 5 insertions(+)

diff --git a/drivers/input/misc/palmas-pwrbutton.c 
b/drivers/input/misc/palmas-pwrbutton.c
index 1e1baed..f9b05cf 100644
--- a/drivers/input/misc/palmas-pwrbutton.c
+++ b/drivers/input/misc/palmas-pwrbutton.c
@@ -210,6 +210,11 @@ static int palmas_pwron_probe(struct platform_device *pdev)
INIT_DELAYED_WORK(>input_work, palmas_power_button_work);
 
pwron->irq = platform_get_irq(pdev, 0);
+   if (pwron->irq <= 0) {
+   error = pwron->irq;
+   goto err_free_input;
+   }
+
error = request_threaded_irq(pwron->irq, NULL, pwron_irq,
 IRQF_TRIGGER_HIGH |
IRQF_TRIGGER_LOW |
-- 
2.7.4