Re: [PATCH 10/11] arm64: tegra: Add clock properties on cpu0 for Tegra210

[Jon Hunter]

On 22/04/16 14:23, Thierry Reding wrote:
> * PGP Signed by an unknown key
> 
> On Fri, Apr 22, 2016 at 12:44:21PM +0100, Jon Hunter wrote:
>> Hi Penny,
>>
>> On 22/04/16 11:31, Penny Chiu wrote:
>>> Add clocks, clock-names, and clock-latency into cpu0 node.
>>> These properties will be used by cpufreq driver.
>>>
>>> Signed-off-by: Penny Chiu 
>>> ---
>>>  arch/arm64/boot/dts/nvidia/tegra210.dtsi | 6 ++
>>>  1 file changed, 6 insertions(+)
>>>
>>> diff --git a/arch/arm64/boot/dts/nvidia/tegra210.dtsi 
>>> b/arch/arm64/boot/dts/nvidia/tegra210.dtsi
>>> index 204d9cd..1a85857 100644
>>> --- a/arch/arm64/boot/dts/nvidia/tegra210.dtsi
>>> +++ b/arch/arm64/boot/dts/nvidia/tegra210.dtsi
>>> @@ -782,6 +782,12 @@
>>> device_type = "cpu";
>>> compatible = "arm,cortex-a57";
>>> reg = <0>;
>>> +   clocks = <_car TEGRA210_CLK_CCLK_G>,
>>> +<_car TEGRA210_CLK_PLL_X>,
>>> +<_car TEGRA210_CLK_PLL_P_OUT4>,
>>> +<>;
>>> +   clock-names = "cpu_g", "pll_x", "pll_p", "dfll";
>>> +   clock-latency = <30>;
>>> };
>>>  
>>> cpu@1 {
>>>
>>
>> Can you include a patch with this series to update the binding
>> documentation for the nvidia,tegra124-cpufreq.txt? I think that although
>> there is no specific nvidia,tegra210-cpufreq compatible string the
>> documentation should state that both tegra124 and tegra210 are supported
>> so it is clear.
>>
>> Also I see the above binding no longer includes the "cpu_lp" for
>> tegra210 which I understand we don't use here. However, the binding
>> documentation should reflect this. Having said that, looking at the
>> driver it appears the "cpu_lp" clock is not even used for tegra124. I
>> wonder if we should drop this from the binding documentation and the
>> tegra124.dtsi altogether?
>>
>> What about the "vdd-cpu-supply" property? Don't we need this?
> 
> For some reason that seems to have moved into the clock@7011 node.

Yes I saw that. I surprised that the cpufreq driver would probe without
this, unless I am missing something ...

Jon

Re: [PATCH 10/11] arm64: tegra: Add clock properties on cpu0 for Tegra210

[Jon Hunter]

On 22/04/16 14:23, Thierry Reding wrote:
> * PGP Signed by an unknown key
> 
> On Fri, Apr 22, 2016 at 12:44:21PM +0100, Jon Hunter wrote:
>> Hi Penny,
>>
>> On 22/04/16 11:31, Penny Chiu wrote:
>>> Add clocks, clock-names, and clock-latency into cpu0 node.
>>> These properties will be used by cpufreq driver.
>>>
>>> Signed-off-by: Penny Chiu 
>>> ---
>>>  arch/arm64/boot/dts/nvidia/tegra210.dtsi | 6 ++
>>>  1 file changed, 6 insertions(+)
>>>
>>> diff --git a/arch/arm64/boot/dts/nvidia/tegra210.dtsi 
>>> b/arch/arm64/boot/dts/nvidia/tegra210.dtsi
>>> index 204d9cd..1a85857 100644
>>> --- a/arch/arm64/boot/dts/nvidia/tegra210.dtsi
>>> +++ b/arch/arm64/boot/dts/nvidia/tegra210.dtsi
>>> @@ -782,6 +782,12 @@
>>> device_type = "cpu";
>>> compatible = "arm,cortex-a57";
>>> reg = <0>;
>>> +   clocks = <_car TEGRA210_CLK_CCLK_G>,
>>> +<_car TEGRA210_CLK_PLL_X>,
>>> +<_car TEGRA210_CLK_PLL_P_OUT4>,
>>> +<>;
>>> +   clock-names = "cpu_g", "pll_x", "pll_p", "dfll";
>>> +   clock-latency = <30>;
>>> };
>>>  
>>> cpu@1 {
>>>
>>
>> Can you include a patch with this series to update the binding
>> documentation for the nvidia,tegra124-cpufreq.txt? I think that although
>> there is no specific nvidia,tegra210-cpufreq compatible string the
>> documentation should state that both tegra124 and tegra210 are supported
>> so it is clear.
>>
>> Also I see the above binding no longer includes the "cpu_lp" for
>> tegra210 which I understand we don't use here. However, the binding
>> documentation should reflect this. Having said that, looking at the
>> driver it appears the "cpu_lp" clock is not even used for tegra124. I
>> wonder if we should drop this from the binding documentation and the
>> tegra124.dtsi altogether?
>>
>> What about the "vdd-cpu-supply" property? Don't we need this?
> 
> For some reason that seems to have moved into the clock@7011 node.

Yes I saw that. I surprised that the cpufreq driver would probe without
this, unless I am missing something ...

Jon

Re: [PATCH 10/11] arm64: tegra: Add clock properties on cpu0 for Tegra210

[Thierry Reding]

On Fri, Apr 22, 2016 at 12:44:21PM +0100, Jon Hunter wrote:
> Hi Penny,
> 
> On 22/04/16 11:31, Penny Chiu wrote:
> > Add clocks, clock-names, and clock-latency into cpu0 node.
> > These properties will be used by cpufreq driver.
> > 
> > Signed-off-by: Penny Chiu 
> > ---
> >  arch/arm64/boot/dts/nvidia/tegra210.dtsi | 6 ++
> >  1 file changed, 6 insertions(+)
> > 
> > diff --git a/arch/arm64/boot/dts/nvidia/tegra210.dtsi 
> > b/arch/arm64/boot/dts/nvidia/tegra210.dtsi
> > index 204d9cd..1a85857 100644
> > --- a/arch/arm64/boot/dts/nvidia/tegra210.dtsi
> > +++ b/arch/arm64/boot/dts/nvidia/tegra210.dtsi
> > @@ -782,6 +782,12 @@
> > device_type = "cpu";
> > compatible = "arm,cortex-a57";
> > reg = <0>;
> > +   clocks = <_car TEGRA210_CLK_CCLK_G>,
> > +<_car TEGRA210_CLK_PLL_X>,
> > +<_car TEGRA210_CLK_PLL_P_OUT4>,
> > +<>;
> > +   clock-names = "cpu_g", "pll_x", "pll_p", "dfll";
> > +   clock-latency = <30>;
> > };
> >  
> > cpu@1 {
> > 
> 
> Can you include a patch with this series to update the binding
> documentation for the nvidia,tegra124-cpufreq.txt? I think that although
> there is no specific nvidia,tegra210-cpufreq compatible string the
> documentation should state that both tegra124 and tegra210 are supported
> so it is clear.
> 
> Also I see the above binding no longer includes the "cpu_lp" for
> tegra210 which I understand we don't use here. However, the binding
> documentation should reflect this. Having said that, looking at the
> driver it appears the "cpu_lp" clock is not even used for tegra124. I
> wonder if we should drop this from the binding documentation and the
> tegra124.dtsi altogether?
> 
> What about the "vdd-cpu-supply" property? Don't we need this?

For some reason that seems to have moved into the clock@7011 node.

Thierry


signature.asc
Description: PGP signature

Re: [PATCH 10/11] arm64: tegra: Add clock properties on cpu0 for Tegra210

[Thierry Reding]

On Fri, Apr 22, 2016 at 12:44:21PM +0100, Jon Hunter wrote:
> Hi Penny,
> 
> On 22/04/16 11:31, Penny Chiu wrote:
> > Add clocks, clock-names, and clock-latency into cpu0 node.
> > These properties will be used by cpufreq driver.
> > 
> > Signed-off-by: Penny Chiu 
> > ---
> >  arch/arm64/boot/dts/nvidia/tegra210.dtsi | 6 ++
> >  1 file changed, 6 insertions(+)
> > 
> > diff --git a/arch/arm64/boot/dts/nvidia/tegra210.dtsi 
> > b/arch/arm64/boot/dts/nvidia/tegra210.dtsi
> > index 204d9cd..1a85857 100644
> > --- a/arch/arm64/boot/dts/nvidia/tegra210.dtsi
> > +++ b/arch/arm64/boot/dts/nvidia/tegra210.dtsi
> > @@ -782,6 +782,12 @@
> > device_type = "cpu";
> > compatible = "arm,cortex-a57";
> > reg = <0>;
> > +   clocks = <_car TEGRA210_CLK_CCLK_G>,
> > +<_car TEGRA210_CLK_PLL_X>,
> > +<_car TEGRA210_CLK_PLL_P_OUT4>,
> > +<>;
> > +   clock-names = "cpu_g", "pll_x", "pll_p", "dfll";
> > +   clock-latency = <30>;
> > };
> >  
> > cpu@1 {
> > 
> 
> Can you include a patch with this series to update the binding
> documentation for the nvidia,tegra124-cpufreq.txt? I think that although
> there is no specific nvidia,tegra210-cpufreq compatible string the
> documentation should state that both tegra124 and tegra210 are supported
> so it is clear.
> 
> Also I see the above binding no longer includes the "cpu_lp" for
> tegra210 which I understand we don't use here. However, the binding
> documentation should reflect this. Having said that, looking at the
> driver it appears the "cpu_lp" clock is not even used for tegra124. I
> wonder if we should drop this from the binding documentation and the
> tegra124.dtsi altogether?
> 
> What about the "vdd-cpu-supply" property? Don't we need this?

For some reason that seems to have moved into the clock@7011 node.

Thierry


signature.asc
Description: PGP signature

Re: [PATCH 10/11] arm64: tegra: Add clock properties on cpu0 for Tegra210

[Jon Hunter]

Hi Penny,

On 22/04/16 11:31, Penny Chiu wrote:
> Add clocks, clock-names, and clock-latency into cpu0 node.
> These properties will be used by cpufreq driver.
> 
> Signed-off-by: Penny Chiu 
> ---
>  arch/arm64/boot/dts/nvidia/tegra210.dtsi | 6 ++
>  1 file changed, 6 insertions(+)
> 
> diff --git a/arch/arm64/boot/dts/nvidia/tegra210.dtsi 
> b/arch/arm64/boot/dts/nvidia/tegra210.dtsi
> index 204d9cd..1a85857 100644
> --- a/arch/arm64/boot/dts/nvidia/tegra210.dtsi
> +++ b/arch/arm64/boot/dts/nvidia/tegra210.dtsi
> @@ -782,6 +782,12 @@
>   device_type = "cpu";
>   compatible = "arm,cortex-a57";
>   reg = <0>;
> + clocks = <_car TEGRA210_CLK_CCLK_G>,
> +  <_car TEGRA210_CLK_PLL_X>,
> +  <_car TEGRA210_CLK_PLL_P_OUT4>,
> +  <>;
> + clock-names = "cpu_g", "pll_x", "pll_p", "dfll";
> + clock-latency = <30>;
>   };
>  
>   cpu@1 {
> 

Can you include a patch with this series to update the binding
documentation for the nvidia,tegra124-cpufreq.txt? I think that although
there is no specific nvidia,tegra210-cpufreq compatible string the
documentation should state that both tegra124 and tegra210 are supported
so it is clear.

Also I see the above binding no longer includes the "cpu_lp" for
tegra210 which I understand we don't use here. However, the binding
documentation should reflect this. Having said that, looking at the
driver it appears the "cpu_lp" clock is not even used for tegra124. I
wonder if we should drop this from the binding documentation and the
tegra124.dtsi altogether?

What about the "vdd-cpu-supply" property? Don't we need this?

Cheers
Jon

Re: [PATCH 10/11] arm64: tegra: Add clock properties on cpu0 for Tegra210

[Jon Hunter]

Hi Penny,

On 22/04/16 11:31, Penny Chiu wrote:
> Add clocks, clock-names, and clock-latency into cpu0 node.
> These properties will be used by cpufreq driver.
> 
> Signed-off-by: Penny Chiu 
> ---
>  arch/arm64/boot/dts/nvidia/tegra210.dtsi | 6 ++
>  1 file changed, 6 insertions(+)
> 
> diff --git a/arch/arm64/boot/dts/nvidia/tegra210.dtsi 
> b/arch/arm64/boot/dts/nvidia/tegra210.dtsi
> index 204d9cd..1a85857 100644
> --- a/arch/arm64/boot/dts/nvidia/tegra210.dtsi
> +++ b/arch/arm64/boot/dts/nvidia/tegra210.dtsi
> @@ -782,6 +782,12 @@
>   device_type = "cpu";
>   compatible = "arm,cortex-a57";
>   reg = <0>;
> + clocks = <_car TEGRA210_CLK_CCLK_G>,
> +  <_car TEGRA210_CLK_PLL_X>,
> +  <_car TEGRA210_CLK_PLL_P_OUT4>,
> +  <>;
> + clock-names = "cpu_g", "pll_x", "pll_p", "dfll";
> + clock-latency = <30>;
>   };
>  
>   cpu@1 {
> 

Can you include a patch with this series to update the binding
documentation for the nvidia,tegra124-cpufreq.txt? I think that although
there is no specific nvidia,tegra210-cpufreq compatible string the
documentation should state that both tegra124 and tegra210 are supported
so it is clear.

Also I see the above binding no longer includes the "cpu_lp" for
tegra210 which I understand we don't use here. However, the binding
documentation should reflect this. Having said that, looking at the
driver it appears the "cpu_lp" clock is not even used for tegra124. I
wonder if we should drop this from the binding documentation and the
tegra124.dtsi altogether?

What about the "vdd-cpu-supply" property? Don't we need this?

Cheers
Jon

[PATCH 10/11] arm64: tegra: Add clock properties on cpu0 for Tegra210

[Penny Chiu]

Add clocks, clock-names, and clock-latency into cpu0 node.
These properties will be used by cpufreq driver.

Signed-off-by: Penny Chiu 
---
 arch/arm64/boot/dts/nvidia/tegra210.dtsi | 6 ++
 1 file changed, 6 insertions(+)

diff --git a/arch/arm64/boot/dts/nvidia/tegra210.dtsi 
b/arch/arm64/boot/dts/nvidia/tegra210.dtsi
index 204d9cd..1a85857 100644
--- a/arch/arm64/boot/dts/nvidia/tegra210.dtsi
+++ b/arch/arm64/boot/dts/nvidia/tegra210.dtsi
@@ -782,6 +782,12 @@
device_type = "cpu";
compatible = "arm,cortex-a57";
reg = <0>;
+   clocks = <_car TEGRA210_CLK_CCLK_G>,
+<_car TEGRA210_CLK_PLL_X>,
+<_car TEGRA210_CLK_PLL_P_OUT4>,
+<>;
+   clock-names = "cpu_g", "pll_x", "pll_p", "dfll";
+   clock-latency = <30>;
};
 
cpu@1 {
-- 
2.8.1

[PATCH 10/11] arm64: tegra: Add clock properties on cpu0 for Tegra210

[Penny Chiu]

Add clocks, clock-names, and clock-latency into cpu0 node.
These properties will be used by cpufreq driver.

Signed-off-by: Penny Chiu 
---
 arch/arm64/boot/dts/nvidia/tegra210.dtsi | 6 ++
 1 file changed, 6 insertions(+)

diff --git a/arch/arm64/boot/dts/nvidia/tegra210.dtsi 
b/arch/arm64/boot/dts/nvidia/tegra210.dtsi
index 204d9cd..1a85857 100644
--- a/arch/arm64/boot/dts/nvidia/tegra210.dtsi
+++ b/arch/arm64/boot/dts/nvidia/tegra210.dtsi
@@ -782,6 +782,12 @@
device_type = "cpu";
compatible = "arm,cortex-a57";
reg = <0>;
+   clocks = <_car TEGRA210_CLK_CCLK_G>,
+<_car TEGRA210_CLK_PLL_X>,
+<_car TEGRA210_CLK_PLL_P_OUT4>,
+<>;
+   clock-names = "cpu_g", "pll_x", "pll_p", "dfll";
+   clock-latency = <30>;
};
 
cpu@1 {
-- 
2.8.1