[PATCH 10/12] HID: hid-lg4ff: Allow the driver to continue without sysfs interface.
Instead of aborting the initialization allow the driver to continue in a degraded mode. Signed-off-by: Michal Malý --- drivers/hid/hid-lg4ff.c | 15 +-- 1 file changed, 5 insertions(+), 10 deletions(-) diff --git a/drivers/hid/hid-lg4ff.c b/drivers/hid/hid-lg4ff.c index ad959e2..5543728 100644 --- a/drivers/hid/hid-lg4ff.c +++ b/drivers/hid/hid-lg4ff.c @@ -1226,19 +1226,14 @@ int lg4ff_init(struct hid_device *hid) /* Create sysfs interface */ error = device_create_file(>dev, _attr_range); if (error) - goto err_init; + hid_warn(hid, "Unable to create sysfs interface for \"range\", errno %d\n", error); if (mmode_ret == LG4FF_MMODE_IS_MULTIMODE) { error = device_create_file(>dev, _attr_real_id); - if (error) { - device_remove_file(>dev, _attr_range); - goto err_init; - } + if (error) + hid_warn(hid, "Unable to create sysfs interface for \"real_id\", errno %d\n", error); error = device_create_file(>dev, _attr_alternate_modes); - if (error) { - device_remove_file(>dev, _attr_real_id); - device_remove_file(>dev, _attr_range); - goto err_init; - } + if (error) + hid_warn(hid, "Unable to create sysfs interface for \"alternate_modes\", errno %d\n", error); } dbg_hid("sysfs interface created\n"); -- 2.3.3 -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
[PATCH 10/12] HID: hid-lg4ff: Allow the driver to continue without sysfs interface.
Instead of aborting the initialization allow the driver to continue in a degraded mode. Signed-off-by: Michal Malý madcatxs...@devoid-pointer.net --- drivers/hid/hid-lg4ff.c | 15 +-- 1 file changed, 5 insertions(+), 10 deletions(-) diff --git a/drivers/hid/hid-lg4ff.c b/drivers/hid/hid-lg4ff.c index ad959e2..5543728 100644 --- a/drivers/hid/hid-lg4ff.c +++ b/drivers/hid/hid-lg4ff.c @@ -1226,19 +1226,14 @@ int lg4ff_init(struct hid_device *hid) /* Create sysfs interface */ error = device_create_file(hid-dev, dev_attr_range); if (error) - goto err_init; + hid_warn(hid, Unable to create sysfs interface for \range\, errno %d\n, error); if (mmode_ret == LG4FF_MMODE_IS_MULTIMODE) { error = device_create_file(hid-dev, dev_attr_real_id); - if (error) { - device_remove_file(hid-dev, dev_attr_range); - goto err_init; - } + if (error) + hid_warn(hid, Unable to create sysfs interface for \real_id\, errno %d\n, error); error = device_create_file(hid-dev, dev_attr_alternate_modes); - if (error) { - device_remove_file(hid-dev, dev_attr_real_id); - device_remove_file(hid-dev, dev_attr_range); - goto err_init; - } + if (error) + hid_warn(hid, Unable to create sysfs interface for \alternate_modes\, errno %d\n, error); } dbg_hid(sysfs interface created\n); -- 2.3.3 -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/