Re: [PATCH 10/19] paride/pcd: use bdev_check_media_change
On 9/8/20 4:53 PM, Christoph Hellwig wrote: > The pcd driver does not have a ->revalidate_disk method, so it can just > use bdev_check_media_change without any additional changes. > > Signed-off-by: Christoph Hellwig > Reviewed-by: Johannes Thumshirn > --- > drivers/block/paride/pcd.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/block/paride/pcd.c b/drivers/block/paride/pcd.c > index 5124eca90e8337..70da8b86ce587d 100644 > --- a/drivers/block/paride/pcd.c > +++ b/drivers/block/paride/pcd.c > @@ -233,7 +233,7 @@ static int pcd_block_open(struct block_device *bdev, > fmode_t mode) > struct pcd_unit *cd = bdev->bd_disk->private_data; > int ret; > > - check_disk_change(bdev); > + bdev_check_media_change(bdev); > > mutex_lock(_mutex); > ret = cdrom_open(>info, bdev, mode); > Reviewed-by: Hannes Reinecke Cheers, Hannes -- Dr. Hannes ReineckeKernel Storage Architect h...@suse.de +49 911 74053 688 SUSE Software Solutions Germany GmbH, Maxfeldstr. 5, 90409 Nürnberg HRB 36809 (AG Nürnberg), GF: Felix Imendörffer
[PATCH 10/19] paride/pcd: use bdev_check_media_change
The pcd driver does not have a ->revalidate_disk method, so it can just use bdev_check_media_change without any additional changes. Signed-off-by: Christoph Hellwig Reviewed-by: Johannes Thumshirn --- drivers/block/paride/pcd.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/block/paride/pcd.c b/drivers/block/paride/pcd.c index 5124eca90e8337..70da8b86ce587d 100644 --- a/drivers/block/paride/pcd.c +++ b/drivers/block/paride/pcd.c @@ -233,7 +233,7 @@ static int pcd_block_open(struct block_device *bdev, fmode_t mode) struct pcd_unit *cd = bdev->bd_disk->private_data; int ret; - check_disk_change(bdev); + bdev_check_media_change(bdev); mutex_lock(_mutex); ret = cdrom_open(>info, bdev, mode); -- 2.28.0
Re: [PATCH 10/19] paride/pcd: use bdev_check_media_change
Looks good, Reviewed-by: Johannes Thumshirn
[PATCH 10/19] paride/pcd: use bdev_check_media_change
The pcd driver does not have a ->revalidate_disk method, so it can just use bdev_check_media_change without any additional changes. Signed-off-by: Christoph Hellwig --- drivers/block/paride/pcd.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/block/paride/pcd.c b/drivers/block/paride/pcd.c index 5124eca90e8337..70da8b86ce587d 100644 --- a/drivers/block/paride/pcd.c +++ b/drivers/block/paride/pcd.c @@ -233,7 +233,7 @@ static int pcd_block_open(struct block_device *bdev, fmode_t mode) struct pcd_unit *cd = bdev->bd_disk->private_data; int ret; - check_disk_change(bdev); + bdev_check_media_change(bdev); mutex_lock(_mutex); ret = cdrom_open(>info, bdev, mode); -- 2.28.0
