Re: [PATCH 11/19] regmap: regmap: avoid spurious warning in regmap_read_debugfs
On Sat, Jan 26, 2013 at 11:45:35AM +, Arnd Bergmann wrote: > Gcc warns about the case where regmap_read_debugfs tries to walk an > empty map->debugfs_off_cache list, which would results in uninitialized > variable getting returned, if we hadn't checked the same condition > just before that. Applied, thanks. signature.asc Description: Digital signature
Re: [PATCH 11/19] regmap: regmap: avoid spurious warning in regmap_read_debugfs
From: Russell King
Gcc warns about the case where regmap_read_debugfs tries to walk an
empty map->debugfs_off_cache list, which would results in uninitialized
variable getting returned, if we hadn't checked the same condition
just before that.
After an originally suggested inferior patch from Arnd Bergmann,
this is the solution that Russell King came up with, sidestepping
the problem by merging the error case for an empty list with the
normal path.
Without this patch, building mxs_defconfig results in:
drivers/base/regmap/regmap-debugfs.c: In function 'regmap_read_debugfs':
drivers/base/regmap/regmap-debugfs.c:147:9: : warning: 'ret' may be used
uninitialized in this function [-Wmaybe-uninitialized]
Reported-by: Vincent Stehle
Cc: Mark Brown
Cc: Greg Kroah-Hartman
Signed-off-by: Arnd Bergmann
diff --git a/drivers/base/regmap/regmap-debugfs.c
b/drivers/base/regmap/regmap-debugfs.c
index 41b65f6..ef35c25 100644
--- a/drivers/base/regmap/regmap-debugfs.c
+++ b/drivers/base/regmap/regmap-debugfs.c
@@ -128,10 +128,8 @@ static unsigned int regmap_debugfs_get_dump_start(struct
regmap *map,
* allocate and we should never be in this code if there are
* no registers at all.
*/
- if (list_empty(>debugfs_off_cache)) {
- WARN_ON(list_empty(>debugfs_off_cache));
- return base;
- }
+ WARN_ON(list_empty(>debugfs_off_cache));
+ ret = base;
/* Find the relevant block */
list_for_each_entry(c, >debugfs_off_cache, list) {
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH 11/19] regmap: regmap: avoid spurious warning in regmap_read_debugfs
From: Russell King rmk+ker...@arm.linux.org.uk
Gcc warns about the case where regmap_read_debugfs tries to walk an
empty map-debugfs_off_cache list, which would results in uninitialized
variable getting returned, if we hadn't checked the same condition
just before that.
After an originally suggested inferior patch from Arnd Bergmann,
this is the solution that Russell King came up with, sidestepping
the problem by merging the error case for an empty list with the
normal path.
Without this patch, building mxs_defconfig results in:
drivers/base/regmap/regmap-debugfs.c: In function 'regmap_read_debugfs':
drivers/base/regmap/regmap-debugfs.c:147:9: : warning: 'ret' may be used
uninitialized in this function [-Wmaybe-uninitialized]
Reported-by: Vincent Stehle v-ste...@ti.com
Cc: Mark Brown broo...@opensource.wolfsonmicro.com
Cc: Greg Kroah-Hartman gre...@linuxfoundation.org
Signed-off-by: Arnd Bergmann a...@arndb.de
diff --git a/drivers/base/regmap/regmap-debugfs.c
b/drivers/base/regmap/regmap-debugfs.c
index 41b65f6..ef35c25 100644
--- a/drivers/base/regmap/regmap-debugfs.c
+++ b/drivers/base/regmap/regmap-debugfs.c
@@ -128,10 +128,8 @@ static unsigned int regmap_debugfs_get_dump_start(struct
regmap *map,
* allocate and we should never be in this code if there are
* no registers at all.
*/
- if (list_empty(map-debugfs_off_cache)) {
- WARN_ON(list_empty(map-debugfs_off_cache));
- return base;
- }
+ WARN_ON(list_empty(map-debugfs_off_cache));
+ ret = base;
/* Find the relevant block */
list_for_each_entry(c, map-debugfs_off_cache, list) {
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH 11/19] regmap: regmap: avoid spurious warning in regmap_read_debugfs
On Sat, Jan 26, 2013 at 11:45:35AM +, Arnd Bergmann wrote: Gcc warns about the case where regmap_read_debugfs tries to walk an empty map-debugfs_off_cache list, which would results in uninitialized variable getting returned, if we hadn't checked the same condition just before that. Applied, thanks. signature.asc Description: Digital signature
