Re: [PATCH 13/14] kernel/irq/spurious.c: Use time_* macros
On Thu, 14 Feb 2008, S.Çağlar Onur wrote: > The functions time_before, time_before_eq, time_after, and time_after_eq are > more robust for comparing jiffies against other values. > > So following patch implements usage of the time_after() macro, defined at > linux/jiffies.h, which deals with wrapping correctly Applied. Thanks, tglx
Re: [PATCH 13/14] kernel/irq/spurious.c: Use time_* macros
On Thu, 14 Feb 2008, S.Çağlar Onur wrote: The functions time_before, time_before_eq, time_after, and time_after_eq are more robust for comparing jiffies against other values. So following patch implements usage of the time_after() macro, defined at linux/jiffies.h, which deals with wrapping correctly Applied. Thanks, tglx
[PATCH 13/14] kernel/irq/spurious.c: Use time_* macros
The functions time_before, time_before_eq, time_after, and time_after_eq are more robust for comparing jiffies against other values. So following patch implements usage of the time_after() macro, defined at linux/jiffies.h, which deals with wrapping correctly Cc: Ingo Molnar <[EMAIL PROTECTED]> Cc: Thomas Gleixner <[EMAIL PROTECTED]> Signed-off-by: S.Çağlar Onur <[EMAIL PROTECTED]> --- kernel/irq/spurious.c |3 ++- 1 files changed, 2 insertions(+), 1 deletions(-) diff --git a/kernel/irq/spurious.c b/kernel/irq/spurious.c index a6b2bc8..088dabb 100644 --- a/kernel/irq/spurious.c +++ b/kernel/irq/spurious.c @@ -6,6 +6,7 @@ * This file contains spurious interrupt handling. */ +#include #include #include #include @@ -179,7 +180,7 @@ void note_interrupt(unsigned int irq, struct irq_desc *desc, * otherwise the couter becomes a doomsday timer for otherwise * working systems */ - if (jiffies - desc->last_unhandled > HZ/10) + if (time_after(jiffies, desc->last_unhandled + HZ/10)) desc->irqs_unhandled = 1; else desc->irqs_unhandled++; -- 1.5.3.7 -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
[PATCH 13/14] kernel/irq/spurious.c: Use time_* macros
The functions time_before, time_before_eq, time_after, and time_after_eq are more robust for comparing jiffies against other values. So following patch implements usage of the time_after() macro, defined at linux/jiffies.h, which deals with wrapping correctly Cc: Ingo Molnar [EMAIL PROTECTED] Cc: Thomas Gleixner [EMAIL PROTECTED] Signed-off-by: S.Çağlar Onur [EMAIL PROTECTED] --- kernel/irq/spurious.c |3 ++- 1 files changed, 2 insertions(+), 1 deletions(-) diff --git a/kernel/irq/spurious.c b/kernel/irq/spurious.c index a6b2bc8..088dabb 100644 --- a/kernel/irq/spurious.c +++ b/kernel/irq/spurious.c @@ -6,6 +6,7 @@ * This file contains spurious interrupt handling. */ +#include linux/jiffies.h #include linux/irq.h #include linux/module.h #include linux/kallsyms.h @@ -179,7 +180,7 @@ void note_interrupt(unsigned int irq, struct irq_desc *desc, * otherwise the couter becomes a doomsday timer for otherwise * working systems */ - if (jiffies - desc-last_unhandled HZ/10) + if (time_after(jiffies, desc-last_unhandled + HZ/10)) desc-irqs_unhandled = 1; else desc-irqs_unhandled++; -- 1.5.3.7 -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
