Re: [PATCH 13/17] thermal: int340x: allow compile test

2015-09-17 Thread Srinivas Pandruvada 
On Thu, 2015-09-10 at 08:31 +0200, Geert Uytterhoeven wrote:
> On Thu, Sep 10, 2015 at 6:11 AM, Eduardo Valentin  wrote:
> > --- a/drivers/thermal/Kconfig
> > +++ b/drivers/thermal/Kconfig
> > @@ -317,7 +317,7 @@ config INTEL_QUARK_DTS_THERMAL
> >
> >  config INT340X_THERMAL
> > tristate "ACPI INT340X thermal drivers"
> > -   depends on X86 && ACPI
> > +   depends on (X86 && ACPI) || COMPILE_TEST
> > select THERMAL_GOV_USER_SPACE
> > select ACPI_THERMAL_REL
> > select ACPI_FAN
> 
> This driver selects INTEL_SOC_DTS_IOSF_CORE, which uses an x86-specific
> header file.
> 
> drivers/thermal/int340x_thermal/int3400_thermal.c: In function
> ‘int3400_thermal_get_uuids’:
> drivers/thermal/int340x_thermal/int3400_thermal.c:120: error:
> dereferencing pointer to incomplete type
> 
> Missing #include 
> 
> drivers/thermal/int340x_thermal/acpi_thermal_rel.c: In function
> ‘acpi_parse_trt’:
> drivers/thermal/int340x_thermal/acpi_thermal_rel.c:85: error: implicit
> declaration of function ‘acpi_has_method’
> 
> Missing #include 
> 
> drivers/thermal/int340x_thermal/acpi_thermal_rel.c: In function
> ‘acpi_parse_trt’:
> drivers/thermal/int340x_thermal/acpi_thermal_rel.c:125: error:
> implicit declaration of function ‘acpi_bus_get_device’
> 
> Definition depends on CONFIG_ACPI
> 
Yes. This has dependency on ACPI. We need to also include ACPI modules
to build. For IOSF we need to have stub functions for core calls.

Thanks,
Srinivas

> Gr{oetje,eeting}s,
> 
> Geert
> 
> --
> Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- 
> ge...@linux-m68k.org
> 
> In personal conversations with technical people, I call myself a hacker. But
> when I'm talking to journalists I just say "programmer" or something like 
> that.
> -- Linus Torvalds
> --
> To unsubscribe from this list: send the line "unsubscribe linux-pm" in
> the body of a message to majord...@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Re: [PATCH 13/17] thermal: int340x: allow compile test

2015-09-17 Thread Srinivas Pandruvada 
On Thu, 2015-09-10 at 08:31 +0200, Geert Uytterhoeven wrote:
> On Thu, Sep 10, 2015 at 6:11 AM, Eduardo Valentin  wrote:
> > --- a/drivers/thermal/Kconfig
> > +++ b/drivers/thermal/Kconfig
> > @@ -317,7 +317,7 @@ config INTEL_QUARK_DTS_THERMAL
> >
> >  config INT340X_THERMAL
> > tristate "ACPI INT340X thermal drivers"
> > -   depends on X86 && ACPI
> > +   depends on (X86 && ACPI) || COMPILE_TEST
> > select THERMAL_GOV_USER_SPACE
> > select ACPI_THERMAL_REL
> > select ACPI_FAN
> 
> This driver selects INTEL_SOC_DTS_IOSF_CORE, which uses an x86-specific
> header file.
> 
> drivers/thermal/int340x_thermal/int3400_thermal.c: In function
> ‘int3400_thermal_get_uuids’:
> drivers/thermal/int340x_thermal/int3400_thermal.c:120: error:
> dereferencing pointer to incomplete type
> 
> Missing #include 
> 
> drivers/thermal/int340x_thermal/acpi_thermal_rel.c: In function
> ‘acpi_parse_trt’:
> drivers/thermal/int340x_thermal/acpi_thermal_rel.c:85: error: implicit
> declaration of function ‘acpi_has_method’
> 
> Missing #include 
> 
> drivers/thermal/int340x_thermal/acpi_thermal_rel.c: In function
> ‘acpi_parse_trt’:
> drivers/thermal/int340x_thermal/acpi_thermal_rel.c:125: error:
> implicit declaration of function ‘acpi_bus_get_device’
> 
> Definition depends on CONFIG_ACPI
> 
Yes. This has dependency on ACPI. We need to also include ACPI modules
to build. For IOSF we need to have stub functions for core calls.

Thanks,
Srinivas

> Gr{oetje,eeting}s,
> 
> Geert
> 
> --
> Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- 
> ge...@linux-m68k.org
> 
> In personal conversations with technical people, I call myself a hacker. But
> when I'm talking to journalists I just say "programmer" or something like 
> that.
> -- Linus Torvalds
> --
> To unsubscribe from this list: send the line "unsubscribe linux-pm" in
> the body of a message to majord...@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Re: [PATCH 13/17] thermal: int340x: allow compile test

2015-09-10 Thread Geert Uytterhoeven 
On Thu, Sep 10, 2015 at 6:11 AM, Eduardo Valentin  wrote:
> --- a/drivers/thermal/Kconfig
> +++ b/drivers/thermal/Kconfig
> @@ -317,7 +317,7 @@ config INTEL_QUARK_DTS_THERMAL
>
>  config INT340X_THERMAL
> tristate "ACPI INT340X thermal drivers"
> -   depends on X86 && ACPI
> +   depends on (X86 && ACPI) || COMPILE_TEST
> select THERMAL_GOV_USER_SPACE
> select ACPI_THERMAL_REL
> select ACPI_FAN

This driver selects INTEL_SOC_DTS_IOSF_CORE, which uses an x86-specific
header file.

drivers/thermal/int340x_thermal/int3400_thermal.c: In function
‘int3400_thermal_get_uuids’:
drivers/thermal/int340x_thermal/int3400_thermal.c:120: error:
dereferencing pointer to incomplete type

Missing #include 

drivers/thermal/int340x_thermal/acpi_thermal_rel.c: In function
‘acpi_parse_trt’:
drivers/thermal/int340x_thermal/acpi_thermal_rel.c:85: error: implicit
declaration of function ‘acpi_has_method’

Missing #include 

drivers/thermal/int340x_thermal/acpi_thermal_rel.c: In function
‘acpi_parse_trt’:
drivers/thermal/int340x_thermal/acpi_thermal_rel.c:125: error:
implicit declaration of function ‘acpi_bus_get_device’

Definition depends on CONFIG_ACPI

Gr{oetje,eeting}s,

Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- ge...@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Re: [PATCH 13/17] thermal: int340x: allow compile test

2015-09-10 Thread Geert Uytterhoeven 
On Thu, Sep 10, 2015 at 6:11 AM, Eduardo Valentin  wrote:
> --- a/drivers/thermal/Kconfig
> +++ b/drivers/thermal/Kconfig
> @@ -317,7 +317,7 @@ config INTEL_QUARK_DTS_THERMAL
>
>  config INT340X_THERMAL
> tristate "ACPI INT340X thermal drivers"
> -   depends on X86 && ACPI
> +   depends on (X86 && ACPI) || COMPILE_TEST
> select THERMAL_GOV_USER_SPACE
> select ACPI_THERMAL_REL
> select ACPI_FAN

This driver selects INTEL_SOC_DTS_IOSF_CORE, which uses an x86-specific
header file.

drivers/thermal/int340x_thermal/int3400_thermal.c: In function
‘int3400_thermal_get_uuids’:
drivers/thermal/int340x_thermal/int3400_thermal.c:120: error:
dereferencing pointer to incomplete type

Missing #include 

drivers/thermal/int340x_thermal/acpi_thermal_rel.c: In function
‘acpi_parse_trt’:
drivers/thermal/int340x_thermal/acpi_thermal_rel.c:85: error: implicit
declaration of function ‘acpi_has_method’

Missing #include 

drivers/thermal/int340x_thermal/acpi_thermal_rel.c: In function
‘acpi_parse_trt’:
drivers/thermal/int340x_thermal/acpi_thermal_rel.c:125: error:
implicit declaration of function ‘acpi_bus_get_device’

Definition depends on CONFIG_ACPI

Gr{oetje,eeting}s,

Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- ge...@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[PATCH 13/17] thermal: int340x: allow compile test

2015-09-09 Thread Eduardo Valentin 
Adding COMPILE_TEST flag to int340x driver to facilitate
maintenance.

Cc: Zhang Rui 
Cc: Srinivas Pandruvada 
Cc: Jacob Pan 
Cc: "lan,Tianyu" 
Cc: Ilkka Koskinen 
Cc: linux...@vger.kernel.org
Cc: linux-kernel@vger.kernel.org
Signed-off-by: Eduardo Valentin 
---
 drivers/thermal/Kconfig | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/thermal/Kconfig b/drivers/thermal/Kconfig
index d0ff238..0fa5d20 100644
--- a/drivers/thermal/Kconfig
+++ b/drivers/thermal/Kconfig
@@ -317,7 +317,7 @@ config INTEL_QUARK_DTS_THERMAL
 
 config INT340X_THERMAL
tristate "ACPI INT340X thermal drivers"
-   depends on X86 && ACPI
+   depends on (X86 && ACPI) || COMPILE_TEST
select THERMAL_GOV_USER_SPACE
select ACPI_THERMAL_REL
select ACPI_FAN
-- 
2.5.0

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[PATCH 13/17] thermal: int340x: allow compile test

2015-09-09 Thread Eduardo Valentin 
Adding COMPILE_TEST flag to int340x driver to facilitate
maintenance.

Cc: Zhang Rui 
Cc: Srinivas Pandruvada 
Cc: Jacob Pan 
Cc: "lan,Tianyu" 
Cc: Ilkka Koskinen 
Cc: linux...@vger.kernel.org
Cc: linux-kernel@vger.kernel.org
Signed-off-by: Eduardo Valentin 
---
 drivers/thermal/Kconfig | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/thermal/Kconfig b/drivers/thermal/Kconfig
index d0ff238..0fa5d20 100644
--- a/drivers/thermal/Kconfig
+++ b/drivers/thermal/Kconfig
@@ -317,7 +317,7 @@ config INTEL_QUARK_DTS_THERMAL
 
 config INT340X_THERMAL
tristate "ACPI INT340X thermal drivers"
-   depends on X86 && ACPI
+   depends on (X86 && ACPI) || COMPILE_TEST
select THERMAL_GOV_USER_SPACE
select ACPI_THERMAL_REL
select ACPI_FAN
-- 
2.5.0

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/