Re: [PATCH 13/43] MAINTAINERS: fix git URL for EDAC
On Fri, Dec 18, 2015 at 03:51:36PM +0800, Fengguang Wu wrote: > CC: Doug Thompson > CC: Borislav Petkov > Signed-off-by: Fengguang Wu > --- > MAINTAINERS |4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > --- linux.orig/MAINTAINERS2015-12-18 15:43:27.677016878 +0800 > +++ linux/MAINTAINERS 2015-12-18 15:43:27.673016878 +0800 > @@ -3945,8 +3945,8 @@ M: Borislav Petkov > M: Mauro Carvalho Chehab > L: linux-e...@vger.kernel.org > W: bluesmoke.sourceforge.net > -T: git://git.kernel.org/pub/scm/linux/kernel/git/bp/bp.git#for-next > -T: > git://git.kernel.org/pub/linux/kernel/git/mchehab/linux-edac.git#linux_next > +T: git git://git.kernel.org/pub/scm/linux/kernel/git/bp/bp.git for-next > +T: git > git://git.kernel.org/pub/scm/linux/kernel/git/mchehab/linux-edac.git > linux_next Huh, "git git://"? That's twice and the protocol git:// already says what kind of a repo this is. This is redundant. -- Regards/Gruss, Boris. ECO tip #101: Trim your mails when you reply. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH 13/43] MAINTAINERS: fix git URL for EDAC
On Fri, Dec 18, 2015 at 11:49:08AM +0100, Borislav Petkov wrote: > On Fri, Dec 18, 2015 at 03:51:36PM +0800, Fengguang Wu wrote: > > CC: Doug Thompson > > CC: Borislav Petkov > > Signed-off-by: Fengguang Wu > > --- > > MAINTAINERS |4 ++-- > > 1 file changed, 2 insertions(+), 2 deletions(-) > > > > --- linux.orig/MAINTAINERS 2015-12-18 15:43:27.677016878 +0800 > > +++ linux/MAINTAINERS 2015-12-18 15:43:27.673016878 +0800 > > @@ -3945,8 +3945,8 @@ M:Borislav Petkov > > M: Mauro Carvalho Chehab > > L: linux-e...@vger.kernel.org > > W: bluesmoke.sourceforge.net > > -T: git://git.kernel.org/pub/scm/linux/kernel/git/bp/bp.git#for-next > > -T: > > git://git.kernel.org/pub/linux/kernel/git/mchehab/linux-edac.git#linux_next > > +T: git git://git.kernel.org/pub/scm/linux/kernel/git/bp/bp.git for-next > > +T: git > > git://git.kernel.org/pub/scm/linux/kernel/git/mchehab/linux-edac.git > > linux_next > > Huh, "git git://"? That's twice and the protocol git:// already says > what kind of a repo this is. > > This is redundant. That's the required format, documented earlier in MAINTAINERS: T: SCM tree type and location. Type is one of: git, hg, quilt, stgit, topgit Which is followed all other places, eg. T: git git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/tty.git T: git https://github.com/Xilinx/linux-xlnx.git Thanks, Fengguang -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH 13/43] MAINTAINERS: fix git URL for EDAC
On Fri, Dec 18, 2015 at 06:57:33PM +0800, Fengguang Wu wrote: > That's the required format, documented earlier in MAINTAINERS: > > T: SCM tree type and location. >Type is one of: git, hg, quilt, stgit, topgit > > Which is followed all other places, eg. > > T: git git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/tty.git > T: git https://github.com/Xilinx/linux-xlnx.git I saw that it is, I'm just saying that "git git://" is redundant. -- Regards/Gruss, Boris. ECO tip #101: Trim your mails when you reply. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH 13/43] MAINTAINERS: fix git URL for EDAC
On Fri, Dec 18, 2015 at 06:57:33PM +0800, Fengguang Wu wrote: > That's the required format, documented earlier in MAINTAINERS: > > T: SCM tree type and location. >Type is one of: git, hg, quilt, stgit, topgit > > Which is followed all other places, eg. > > T: git git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/tty.git > T: git https://github.com/Xilinx/linux-xlnx.git Right, and IMO it should be done something like the diff below. The T: should contain the URL and if it is not clear from the URL type, the *type* of the repository should be appended and not some commands like "hg" or "quilt" or whatever. Especially if those commands don't necessarily tell you what the repo is unless you know what the executables' names mean. --- diff --git a/MAINTAINERS b/MAINTAINERS index 7271b6189ccf..09a9c76ff83e 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -75,8 +75,8 @@ Descriptions of section entries: L: Mailing list that is relevant to this area W: Web-page with status/info Q: Patchwork web based patch tracking system site - T: SCM tree type and location. - Type is one of: git, hg, quilt, stgit, topgit + T: SCM tree type and location. If it is not clear from the SCM URL, the + SCM type is appended in brackets. S: Status, one of the following: Supported: Someone is actually paid to look after this. Maintained: Someone actually looks after it. @@ -1739,7 +1739,7 @@ M:Michal Simek R: Sören Brinkmann L: linux-arm-ker...@lists.infradead.org (moderated for non-subscribers) W: http://wiki.xilinx.com -T: git https://github.com/Xilinx/linux-xlnx.git +T: https://github.com/Xilinx/linux-xlnx.git (git) S: Supported F: arch/arm/mach-zynq/ F: drivers/cpuidle/cpuidle-zynq.c @@ -5604,7 +5604,7 @@ M:Gang Wei M: Shane Wang L: tboot-de...@lists.sourceforge.net W: http://tboot.sourceforge.net -T: hg http://tboot.hg.sourceforge.net:8000/hgroot/tboot/tboot +T: http://tboot.hg.sourceforge.net:8000/hgroot/tboot/tboot (mercurial) S: Supported F: Documentation/intel_txt.txt F: include/linux/tboot.h -- Regards/Gruss, Boris. ECO tip #101: Trim your mails when you reply. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH 13/43] MAINTAINERS: fix git URL for EDAC
On Fri, Dec 18, 2015 at 12:41:55PM +0100, Borislav Petkov wrote: > On Fri, Dec 18, 2015 at 06:57:33PM +0800, Fengguang Wu wrote: > > That's the required format, documented earlier in MAINTAINERS: > > > > T: SCM tree type and location. > >Type is one of: git, hg, quilt, stgit, topgit > > > > Which is followed all other places, eg. > > > > T: git git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/tty.git > > T: git https://github.com/Xilinx/linux-xlnx.git > > Right, and IMO it should be done something like the diff below. > > The T: should contain the URL and if it is not clear from the URL > type, the *type* of the repository should be appended and not some > commands like "hg" or "quilt" or whatever. Especially if those commands > don't necessarily tell you what the repo is unless you know what the > executables' names mean. That's all right for humans, however there are also in-tree and out-of-tree scripts that parse the MAINTAINERS file and depend on the current format. So isn't it better to change the several lines for EDAC than to convert hundreds of lines to the new format, plus converting the related scripts? Thanks, Fengguang > --- > diff --git a/MAINTAINERS b/MAINTAINERS > index 7271b6189ccf..09a9c76ff83e 100644 > --- a/MAINTAINERS > +++ b/MAINTAINERS > @@ -75,8 +75,8 @@ Descriptions of section entries: > L: Mailing list that is relevant to this area > W: Web-page with status/info > Q: Patchwork web based patch tracking system site > - T: SCM tree type and location. > -Type is one of: git, hg, quilt, stgit, topgit > + T: SCM tree type and location. If it is not clear from the SCM URL, the > +SCM type is appended in brackets. > S: Status, one of the following: > Supported: Someone is actually paid to look after this. > Maintained: Someone actually looks after it. > @@ -1739,7 +1739,7 @@ M: Michal Simek > R: Sören Brinkmann > L: linux-arm-ker...@lists.infradead.org (moderated for non-subscribers) > W: http://wiki.xilinx.com > -T: git https://github.com/Xilinx/linux-xlnx.git > +T: https://github.com/Xilinx/linux-xlnx.git (git) > S: Supported > F: arch/arm/mach-zynq/ > F: drivers/cpuidle/cpuidle-zynq.c > @@ -5604,7 +5604,7 @@ M: Gang Wei > M: Shane Wang > L: tboot-de...@lists.sourceforge.net > W: http://tboot.sourceforge.net > -T: hg http://tboot.hg.sourceforge.net:8000/hgroot/tboot/tboot > +T: http://tboot.hg.sourceforge.net:8000/hgroot/tboot/tboot (mercurial) > S: Supported > F: Documentation/intel_txt.txt > F: include/linux/tboot.h > > -- > Regards/Gruss, > Boris. > > ECO tip #101: Trim your mails when you reply. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH 13/43] MAINTAINERS: fix git URL for EDAC
On Fri, Dec 18, 2015 at 07:55:39PM +0800, Fengguang Wu wrote: > That's all right for humans, however there are also in-tree and > out-of-tree scripts that parse the MAINTAINERS file and depend on > the current format. Hmm, it doesn't say that in the T: description - I thought it was for humans only. Besides, scripts can parse stuff in brackets too. > So isn't it better to change the several lines for EDAC than to > convert hundreds of lines to the new format, plus converting the > related scripts? Not better - easier. I'm pointing out that this scheme is suboptimal. Someone might read it and decide to fix it, who knows. :) Thanks. -- Regards/Gruss, Boris. ECO tip #101: Trim your mails when you reply. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH 13/43] MAINTAINERS: fix git URL for EDAC
On Fri, Dec 18, 2015 at 03:51:36PM +0800, Fengguang Wu wrote: > CC: Doug Thompson > CC: Borislav Petkov > Signed-off-by: Fengguang Wu > --- > MAINTAINERS |4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > --- linux.orig/MAINTAINERS2015-12-18 15:43:27.677016878 +0800 > +++ linux/MAINTAINERS 2015-12-18 15:43:27.673016878 +0800 > @@ -3945,8 +3945,8 @@ M: Borislav Petkov > M: Mauro Carvalho Chehab > L: linux-e...@vger.kernel.org > W: bluesmoke.sourceforge.net > -T: git://git.kernel.org/pub/scm/linux/kernel/git/bp/bp.git#for-next > -T: > git://git.kernel.org/pub/linux/kernel/git/mchehab/linux-edac.git#linux_next > +T: git git://git.kernel.org/pub/scm/linux/kernel/git/bp/bp.git for-next > +T: git > git://git.kernel.org/pub/scm/linux/kernel/git/mchehab/linux-edac.git > linux_next > S: Supported > F: Documentation/edac.txt > F: drivers/edac/ Applied, thanks. -- Regards/Gruss, Boris. ECO tip #101: Trim your mails when you reply. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/