Re: [PATCH 15/19] md: use bdev_check_media_change

2020-09-09 Thread Hannes Reinecke
On 9/8/20 4:53 PM, Christoph Hellwig wrote:
> The md driver does not have a ->revalidate_disk method, so it can just
> use bdev_check_media_change without any additional changes.
> 
> Signed-off-by: Christoph Hellwig 
> Reviewed-by: Johannes Thumshirn 
> ---
>  drivers/md/md.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/md/md.c b/drivers/md/md.c
> index 9562ef598ae1f4..27ed61197014ef 100644
> --- a/drivers/md/md.c
> +++ b/drivers/md/md.c
> @@ -7848,7 +7848,7 @@ static int md_open(struct block_device *bdev, fmode_t 
> mode)
>   atomic_inc(>openers);
>   mutex_unlock(>open_mutex);
>  
> - check_disk_change(bdev);
> + bdev_check_media_change(bdev);
>   out:
>   if (err)
>   mddev_put(mddev);
> 
Reviewed-by: Hannes Reinecke 

Cheers,

Hannes
-- 
Dr. Hannes ReineckeKernel Storage Architect
h...@suse.de  +49 911 74053 688
SUSE Software Solutions Germany GmbH, Maxfeldstr. 5, 90409 Nürnberg
HRB 36809 (AG Nürnberg), GF: Felix Imendörffer


Re: [PATCH 15/19] md: use bdev_check_media_change

2020-09-08 Thread Song Liu
On Tue, Sep 8, 2020 at 7:55 AM Christoph Hellwig  wrote:
>
> The md driver does not have a ->revalidate_disk method, so it can just
> use bdev_check_media_change without any additional changes.
>
> Signed-off-by: Christoph Hellwig 
> Reviewed-by: Johannes Thumshirn 

Acked-by: Song Liu 

> ---
>  drivers/md/md.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/md/md.c b/drivers/md/md.c
> index 9562ef598ae1f4..27ed61197014ef 100644
> --- a/drivers/md/md.c
> +++ b/drivers/md/md.c
> @@ -7848,7 +7848,7 @@ static int md_open(struct block_device *bdev, fmode_t 
> mode)
> atomic_inc(>openers);
> mutex_unlock(>open_mutex);
>
> -   check_disk_change(bdev);
> +   bdev_check_media_change(bdev);
>   out:
> if (err)
> mddev_put(mddev);
> --
> 2.28.0
>


[PATCH 15/19] md: use bdev_check_media_change

2020-09-08 Thread Christoph Hellwig
The md driver does not have a ->revalidate_disk method, so it can just
use bdev_check_media_change without any additional changes.

Signed-off-by: Christoph Hellwig 
Reviewed-by: Johannes Thumshirn 
---
 drivers/md/md.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/md/md.c b/drivers/md/md.c
index 9562ef598ae1f4..27ed61197014ef 100644
--- a/drivers/md/md.c
+++ b/drivers/md/md.c
@@ -7848,7 +7848,7 @@ static int md_open(struct block_device *bdev, fmode_t 
mode)
atomic_inc(>openers);
mutex_unlock(>open_mutex);
 
-   check_disk_change(bdev);
+   bdev_check_media_change(bdev);
  out:
if (err)
mddev_put(mddev);
-- 
2.28.0



Re: [PATCH 15/19] md: use bdev_check_media_change

2020-09-02 Thread Sergei Shtylyov
Hello!

On 9/2/20 5:12 PM, Christoph Hellwig wrote:

> The pcd driver does not have a ->revalidate_disk method, so it can just

   s/pcd/md/?

> use bdev_check_media_change without any additional changes.
> 
> Signed-off-by: Christoph Hellwig 
> ---
>  drivers/md/md.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
[...]

MBR, Sergei


Re: [PATCH 15/19] md: use bdev_check_media_change

2020-09-02 Thread Johannes Thumshirn
On 02/09/2020 16:16, Christoph Hellwig wrote:
> The pcd driver does not have a ->revalidate_disk method, so it can just
   md ~^

Otherwise looks good,
Reviewed-by: Johannes Thumshirn 


[PATCH 15/19] md: use bdev_check_media_change

2020-09-02 Thread Christoph Hellwig
The pcd driver does not have a ->revalidate_disk method, so it can just
use bdev_check_media_change without any additional changes.

Signed-off-by: Christoph Hellwig 
---
 drivers/md/md.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/md/md.c b/drivers/md/md.c
index 9562ef598ae1f4..27ed61197014ef 100644
--- a/drivers/md/md.c
+++ b/drivers/md/md.c
@@ -7848,7 +7848,7 @@ static int md_open(struct block_device *bdev, fmode_t 
mode)
atomic_inc(>openers);
mutex_unlock(>open_mutex);
 
-   check_disk_change(bdev);
+   bdev_check_media_change(bdev);
  out:
if (err)
mddev_put(mddev);
-- 
2.28.0